Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Iog+5KIJ7x7HcREwl57FJ6AWPpylwiXjMeEm8xrRrCdC1MrSI31ReS+GBQTVqbKY+7Jb+hHj7O
 lazIXsh81a0g==
IronPort-SDR: MhTL47sbS+pRc/kLZQKHQ0AQ/M0ggkjhNBL+Z0Cal3rc4x4rO0tukFSHpVcJA3lhdBbyc3DpB6
 i/ucjTf5/PWw==
Date:   Mon, 15 Jun 2020 18:51:31 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Prarit Bhargava <prarit@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Tony Luck <tony.luck@intel.com>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Rahul Tanwar <rahul.tanwar@linux.intel.com>,
        Xiaoyao Li <xiaoyao.li@intel.com>,
        Ricardo Neri <ricardo.neri-calderon@linux.intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v3] x86/split_lock: Sanitize userspace and guest error
 output
Message-ID: <20200616015131.GA26491@linux.intel.com>
References: <20200615113900.35697-1-prarit@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200615113900.35697-1-prarit@redhat.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jun 15, 2020 at 07:39:00AM -0400, Prarit Bhargava wrote:
> There are two problems with kernel messages in fatal mode that were found
> during testing of guests and userspace programs.
> 
> The first is that no kernel message is output when the split lock detector
> is triggered with a userspace program.  As a result the userspace process
> dies from receiving SIGBUS with no indication to the user of what caused
> the process to die.
> 
> The second problem is that only the first triggering guest causes a kernel
> message to be output because the message is output with pr_warn_once().
> This also results in a loss of information to the user.
> 
> While fixing these I noticed that the same message was being output
> three times so I'm cleaning that up too.
> 
> Fix fatal mode output, and use consistent messages for fatal and
> warn modes for both userspace and guests.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>

This needs a Co-developed-by for me, and your SOB should come last, e.g.

  Co-developed-by: Sean Christopherson <sean.j.christopherson@intel.com> 
  Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
  Signed-off-by: Prarit Bhargava <prarit@redhat.com>

See "12) When to use Acked-by:, Cc:, and Co-developed-by:" in
Documentation/process/submitting-patches.rst for more details.