Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1592273581-31338-1-git-send-email-wangxidong_97@163.com>
In-Reply-To: <1592273581-31338-1-git-send-email-wangxidong_97@163.com>
From:   Tonghao Zhang <xiangxia.m.yue@gmail.com>
Date:   Tue, 16 Jun 2020 15:44:14 +0800
Message-ID: <CAMDZJNUnsQM93DiP8zGyxEAzRgDogQc7HgMhSE-3WdWJWSsW8A@mail.gmail.com>
Subject: Re: [ovs-dev] [PATCH 1/1] openvswitch: fix infoleak in conntrack
To:     Xidong Wang <wangxidong_97@163.com>
Cc:     Pravin B Shelar <pshelar@ovn.org>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Linux Kernel Network Developers <netdev@vger.kernel.org>,
        ovs dev <dev@openvswitch.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 16, 2020 at 10:13 AM Xidong Wang <wangxidong_97@163.com> wrote:
>
> From: xidongwang <wangxidong_97@163.com>
>
> The stack object =E2=80=9Czone_limit=E2=80=9D has 3 members. In function
> ovs_ct_limit_get_default_limit(), the member "count" is
> not initialized and sent out via =E2=80=9Cnla_put_nohdr=E2=80=9D.
>
> Signed-off-by: xidongwang <wangxidong_97@163.com>
> ---
>  net/openvswitch/conntrack.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/net/openvswitch/conntrack.c b/net/openvswitch/conntrack.c
> index 4340f25..1b7820a 100644
> --- a/net/openvswitch/conntrack.c
> +++ b/net/openvswitch/conntrack.c
> @@ -2020,6 +2020,7 @@ static int ovs_ct_limit_get_default_limit(struct ov=
s_ct_limit_info *info,
>  {
>         struct ovs_zone_limit zone_limit;
>         int err;
> +       memset(&zone_limit, 0, sizeof(zone_limit));
why not init zone.count =3D=3D 0, instead of memset, because zone_id/limit
will be inited later.
memset uses more cpu cycles.
>         zone_limit.zone_id =3D OVS_ZONE_LIMIT_DEFAULT_ZONE;
>         zone_limit.limit =3D info->default_limit;
> --
> 2.7.4
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


--=20
Best regards, Tonghao