Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2262675ybt;
        Tue, 16 Jun 2020 01:06:02 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwdS+ihtc2czbU/bJ7IA7dplP+KS4wNbofeI+6slTzcc42hdBjrlPvTQsDMopr6UbOEEaSE
X-Received: by 2002:a17:906:1149:: with SMTP id i9mr1733168eja.100.1592294762634;
        Tue, 16 Jun 2020 01:06:02 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592294762; cv=none;
        d=google.com; s=arc-20160816;
        b=d0SENqso3iK9CwD9kYFQ5XdZiwzV7Jk863ICC1GIvK5pn8VXFpVWCsYpV3wUU4Z92T
         HbnRIVL21u4TSwJPRiGsv5jzM2o2Bt/CMXG2lb280ajzK5rmzIqgZ984B3LOV2Xe3siC
         gv/CXXInAPzsfPMyuUFjLHnnb1Lp8x9jAjMjJaeJk0FwI6Q+4qPgMe4jqrXX2wazYICW
         q8GSZlcq6Pf87yZeKF8UBkWEx/Vz6dzzRV/ZAPeSv/THLoveAnbW3EKIFSZUYuwXuW+b
         sTZcrmpfO0XTfeuqGNsQn7KIbLHUQlwWwN9ccvmZD84v8GCONqvd6vcVfE3//80dZfTu
         3AHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=3LeCba4mbLZy+8I9XCqALq/Zp+vARf9z2EXRoJnbONI=;
        b=PJMsSOQn0CoTgwDo/GvN4v49jBUhVSJdg7hZTMlxqOnMXJiidgSkAIJu266epwkZ1l
         xYFf6S+Oq+bRemWqDFoMOMIXWOq7a+KI8B9Fsnoqt8filWEYXnMrW4RJ7UOyoAig5AAK
         fF3LJyAbJo8+yUw+8O7ytVd2ayFQeClr4XFyB9QahKOzgoOFLmEYvn+8fKnZz0WJQiDi
         Z9gW4bNsspAuyxH2MtECiIqpHARj++V9obwjjFaebCIVZ8GDsWaYRQ1S/unn1vYAnZcs
         juFVVgAgsFHW7P9CuWZzbEn1409JBkKRLOQdTItQ/KYJr3Lp5qcepqqFGV185jXN/xBe
         rSgg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BwHS5FnO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id p5si9956976edq.385.2020.06.16.01.05.40;
        Tue, 16 Jun 2020 01:06:02 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=BwHS5FnO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727826AbgFPIDL (ORCPT <rfc822;wxiaokuan@gmail.com> + 99 others);
        Tue, 16 Jun 2020 04:03:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59096 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725896AbgFPIDK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jun 2020 04:03:10 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F839C05BD43
        for <linux-kernel@vger.kernel.org>; Tue, 16 Jun 2020 01:03:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description;
        bh=3LeCba4mbLZy+8I9XCqALq/Zp+vARf9z2EXRoJnbONI=; b=BwHS5FnObgRQYIAoHrlje2lgKV
        VhlBTVM91Sy5Y12v3ohFP/7/D++XECwPyx02Nua4pH6XzzD2Uq7NQKjGa/m2p2UplmGPR6TBXHkKY
        wM0l3PtKi9EHTEbTTEkcNfXhZfJVkh/DKw6IevygP/Duflz39LXHSiPGwPktPVoWOsCrapsOrPRc1
        U+24EJztR0moL5xvvG2oDIXnlaANw0C66lJQn+jOUTjsgh27mHrhEFPee3TLmWA+rEIqVXLwXpSPD
        bB0ZJn/IPTSPf0zw/v8gwNs8FrtDsgWidh3IVJhYBWJhyUT3LSmhewi1TrUA5MULaY1GoW7ZYdihr
        odeBdVjw==;
Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux))
        id 1jl6Yn-0004oG-VA; Tue, 16 Jun 2020 08:03:09 +0000
Date:   Tue, 16 Jun 2020 01:03:09 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Nitesh Narayan Lal <nitesh@redhat.com>
Cc:     linux-kernel@vger.kernel.org, frederic@kernel.org,
        mtosatti@redhat.com, sassmann@redhat.com,
        jeffrey.t.kirsher@intel.com, jacob.e.keller@intel.com,
        jlelli@redhat.com
Subject: Re: [Patch v1] i40e: limit the msix vectors based on housekeeping
 CPUs
Message-ID: <20200616080309.GA21210@infradead.org>
References: <20200615202125.27831-1-nitesh@redhat.com>
 <20200615202125.27831-2-nitesh@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200615202125.27831-2-nitesh@redhat.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jun 15, 2020 at 04:21:25PM -0400, Nitesh Narayan Lal wrote:
> +	hk_flags = HK_FLAG_DOMAIN | HK_FLAG_WQ;
> +	mask = housekeeping_cpumask(hk_flags);
> +	cpus = cpumask_weight(mask);

Code like this has no business inside a driver.  Please provide a
proper core API for it instead.  Also please wire up
pci_alloc_irq_vectors* to use this API as well.