Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2271076ybt; Tue, 16 Jun 2020 01:22:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrbrrqouy8ZyIT7kzffjFNBCOY3e3RGZNhgSHNpQkhyX241k7y3Es4tCnFtUBH0VhwMzfW X-Received: by 2002:a17:906:4554:: with SMTP id s20mr1614431ejq.241.1592295778143; Tue, 16 Jun 2020 01:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592295778; cv=none; d=google.com; s=arc-20160816; b=mvpkX85lstJeejpASKRLTy7ukBqCT+rpdGSbXJZuBWDbbdn3DWKaLd54GkgE/c2QA1 WjB+vt7w165IChnyRJzqlyUHogO9ODRXjRyR0NGZC8K8g+KJID+U+sP+frOegGws2n0E 9kZkuMpzTEGt7ENGr/OCUkiyhhjAPEGrN5+S45zP0MCPYbDg93WIv6Mk2Enys1VU64oz zhn9pblQbWdGKZ9f5oNmwh3YTap6mgXS0rlJDk6X7xT4HbJWoV/S2Em5qAlnE1TvOAUR o/3CUJuLd7NGNgHxsZ2OujCiEOBlrDs0p1uKz4uDLqpYCZIjGLObVdggjLrVONG0g3bp Z8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=BTD3KzZKcgYtZhXCk/JZKpy26oZhjZ/yMTU3tb0m6iw=; b=NIfWZHuoJjvw6h8aOAvgtVYzzSsgEpXAD6B0EX4sG4zYDObtysRG8LNYInXEmByggG bV3tqCoKbJimR8By6GXLkwJqvDTkKkLV8mA6CWXlyyBEQ0eRJIyDOAsFmL9YM3LdAPXT gCu63yppc9gl3qe66s3PqCeb1JY70E0KrvGZO76rOde++NfhIHIsLskkH0Pw9Jsl65eW ojY32IRCTwk7n1uYUvWy+c5FYKjQvZp9OZ0ruXUsDC8nUaAfjSNiCsQTqI0bDnEGRPFj AEtUU0288zkcXq04sPMXz30jZVh3/J6qtrPSE/ItIADjR53oT4W+SLutZpbn8VpA5/oD kUvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si9774373edr.104.2020.06.16.01.22.35; Tue, 16 Jun 2020 01:22:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727103AbgFPIUp (ORCPT + 99 others); Tue, 16 Jun 2020 04:20:45 -0400 Received: from mga17.intel.com ([192.55.52.151]:62156 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726261AbgFPIUn (ORCPT ); Tue, 16 Jun 2020 04:20:43 -0400 IronPort-SDR: aOUi4FXalfg1kdXsKXuHGsIPSMLsGP4NPZIlsLmyTycRRZxJ/KnmMRkqn5fszi0oTAJRKc1yEy wF2Xju97ByBg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2020 01:20:42 -0700 IronPort-SDR: t0bpjd+Q4VKPC+61dXRLYFNPcf5pPWtmPGdNQMvv1hNVMlRocJWKWMn0DWM265is/EYejzUSYU SYOn6AFH6J1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,518,1583222400"; d="scan'208";a="262066840" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.152]) by orsmga007.jf.intel.com with ESMTP; 16 Jun 2020 01:20:42 -0700 Date: Tue, 16 Jun 2020 01:20:42 -0700 From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Vitaly Kuznetsov , Jim Mattson , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: X86: Fix MSR range of APIC registers in X2APIC mode Message-ID: <20200616082042.GE26491@linux.intel.com> References: <20200616073307.16440-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616073307.16440-1-xiaoyao.li@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 03:33:07PM +0800, Xiaoyao Li wrote: > Only MSR address range 0x800 through 0x8ff is architecturally reserved > and dedicated for accessing APIC registers in x2APIC mode. > > Fixes: 0105d1a52640 ("KVM: x2apic interface to lapic") > Signed-off-by: Xiaoyao Li > --- And perhaps more importantly, there are real MSRs that are overlapped, e.g. MSR_IA32_TME_ACTIVATE. This probably warrants a Cc to stable; as you found out the hard way, this breaks ignore_msrs. Reviewed-by: Sean Christopherson