Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2321267ybt; Tue, 16 Jun 2020 03:02:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC6ed0oZiVtKabCblv8xGq1SbZr3OcD7aZvFqrXaN3/ImLp5lY8JPCKIngjrkVzWTTzOLv X-Received: by 2002:a17:906:76c4:: with SMTP id q4mr2116585ejn.371.1592301722252; Tue, 16 Jun 2020 03:02:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592301722; cv=none; d=google.com; s=arc-20160816; b=IDRGhoE1N/krIFV3qXL6tw3dtvP8q0iVxOtyBIq1X0Zy481e4R4YAEG7hdxCOSTtId VaCvmSFZSLcT04bVtiWqvpM0QooHh2UOvgFrJ+U3WfgM61iXDCSoKs9aRc4097mdYcIs NQFP+Gr6YC403NjaKNY2pqwRmOMx6MRgek6MRNIl81fOJpsEr+VRL73jeuWrvmzxl0Aj v0md+ZnL3xm/+ZlhAm6uc9QWCmzrmp7hN3Iy3iCcLODVqhBc2PmD7yWmkvs7K1nKi763 2N0o2BKskpizPcJJuNPAd16iS4kaKGuQwF8RfPM4CDzcv7dqaXkLQ6F4OS7IFG5Del5D on5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5GoJCkf2e156E/h1oZBict3y0/ttVDi1YOE06ZixhE8=; b=FB4JlySUtHt8QK6GA69Q941ScFKpn3rjIg/egEmAY7F1IFPdCmd7dQrQcYhmvz4R+F dZJNO9FX5hbdeb/5p52hqciuLQLkEzRjmhGEYgkDVREh9/xzJwX50DMe8brqKC5NmXeQ pN+zMcgv2ktkvhOcs83YtTVlBe9xqjckkLVHYFDIrna/LnJBVZlAdONVssIeOt8KI5bs 1ZgmXs7YU3d7ajMtjJfmMsoORaXuilSsHT2MOFxJYBGJEAgihhB82gGir6WCj1niD9w2 2oDc9PBue0eA85kabalRk4qWFjJUDPHZzOCIDxOT7Y7fj8Mtz/TVgei7sowkXbp8frpg F44A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s35iCxf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd12si10917367ejb.59.2020.06.16.03.01.40; Tue, 16 Jun 2020 03:02:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=s35iCxf2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728061AbgFPJ7v (ORCPT + 99 others); Tue, 16 Jun 2020 05:59:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:60964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726052AbgFPJ7u (ORCPT ); Tue, 16 Jun 2020 05:59:50 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CA0720767; Tue, 16 Jun 2020 09:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592301590; bh=H00RGJq5KezVcrQ/vGzLRXHsGQa2G3LnLHyCG7559QU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s35iCxf2ApOcJZGyTnKb4vFHqFOY/SexyqbRTgxWkYLnGAD85dUn2XN6AYZkK4Yms bl62nwah75Ax2duvcU+bVe2CmlysoY32l9chot9A7Qr1u4UA5fiP/m2ZlZQO/ik3av tMj/TY1ARiyudeRqXH3l8XqEFpJspJfUFi6ej97w= Date: Tue, 16 Jun 2020 10:59:48 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200616095948.GJ4447@sirena.org.uk> References: <20200612141611.GI5396@sirena.org.uk> <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> <20200615145556.GY4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6xTM0kUsJcaNctaW" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6xTM0kUsJcaNctaW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jun 16, 2020 at 02:03:40AM +0000, Robin Gong wrote: > On 2020/06/15 22:56 Mark Brown wrote:=20 > struct list_head transfer_list; > + > +#define SPI_TRANS_DMA_PREP_FAIL BIT(3) /* prepare dma failed */ > + u16 flags; I'd just make this a generic flag for failures before we start interacting with the hardware rather than specifically this one error case. Otherwise this looks fine. --6xTM0kUsJcaNctaW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7omBMACgkQJNaLcl1U h9CvpQf+Nxs8GAzGWD8q5WQ5Yfk5Dd+UDwg0tf7+zdTr05h6hiN4THe7qjTZBk6+ MC0R19TGfmpOaqHJY8nh3Nr2HY2QUv+ceTtIYVmwxpG+oE9TTE1v5WQTzOTQ5HMV yq8qU6g8Tfa1uB6BLAchJMy2lBvU/mjNqRnDY4ONnr5qkrmmKgQZycDnilH3ICEy VVS2cenoNIUooeyGwBCFOO8GnxfPhYtO3P5CLZvFPmg6OEdq0qIbluxYksdknKiR cBMORkKWR3BEZwuCx2R6xjUk17zxIpc5Km7XmjrZXSSitzONPcMjcaqVq4mtuNAU 5hztHr9mzDtIlWqoD8uLxSczu7wlVg== =AZSa -----END PGP SIGNATURE----- --6xTM0kUsJcaNctaW--