Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2333946ybt; Tue, 16 Jun 2020 03:23:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzEZK8MT5ymT0G2u5omRGIBs7noM7qQKeFz1JqXWJC1yuSRE3Gx/Q1v0L3qFXCpVCzFxaQ6 X-Received: by 2002:a17:907:2052:: with SMTP id pg18mr1958993ejb.513.1592303002788; Tue, 16 Jun 2020 03:23:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592303002; cv=none; d=google.com; s=arc-20160816; b=nOTbg9RbEmFS+JZuXyupmGNTQEdIL8KD3Lt2ZJUvJ69ysG7bx9k2yIjdBasPicTcqC 67e4aPHcD4dCvz89m6Oe18x8tsY35sjLfB/KrFN37geu90kYP1keejrhyBF7PawMomrh bLGrFril207rvrlyWyexGgMHIzAgbBJ+ePv8lNxTMMqRLVVUBd8jmWT17b/6bKqjh5l8 wgvFjUchPTuRaiN0J8bs6MpzUFWHP1jSkk5kIZnNv+RLHtjEkgLoFW/diCl9trJZIjxV O8ePIiJozT3mkhcAUuHPwMywSfvHVVV2oRaIqAqzVvXTjKFK53VHxr2j3mui4/Y3XzN1 56kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=De04o2ksjI4LCRuUJymMZyN7SpLPPi/l5AwXKxXPHpw=; b=BSowcErUMxLDLvkgrnSXXt9I5tv7DNFuwNMovMo2FlePZ/o101YdCwwYuakQ+pL9Vy WM3ob/HIlkU7ZOpDNmcZy+/3O5U4CIs5CNAIifPS3f+TebX49u72AR263AhfRWXoe1f+ cI2VwaPwu6t+5zLxojAReAU3Xe122/H1k+WntmSilX4FhkJBTylufQRGfDQgE1MKCkBG jgwFbaurLcPaTkEHF/EtMaNmzktuL+58pCIUOXHtIiQSRC5O0L3lTgpjpaq7ksJ8flg7 Yrh+7BSkM2bOP44KboqDnVjYGR4B6CFaebq0SE58DyQFMRQtI14usc/sOSz9G0rD6Kzo poxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=evAMvYAV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si10287700eju.694.2020.06.16.03.23.00; Tue, 16 Jun 2020 03:23:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=evAMvYAV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728258AbgFPKU7 (ORCPT + 99 others); Tue, 16 Jun 2020 06:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgFPKU6 (ORCPT ); Tue, 16 Jun 2020 06:20:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E7D1FC08C5C2; Tue, 16 Jun 2020 03:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=De04o2ksjI4LCRuUJymMZyN7SpLPPi/l5AwXKxXPHpw=; b=evAMvYAVePPjChIJ2pN2XCAlWZ 1O2wsKHasxMhOHyx5TznFldLZCX8vPlBGY60QLWagiJzwoZxhx8CCi9wdY6ZjHwgdG/MZbnJBxhUq IeeO2W9J+DD6JzPXvPlBMJSkBLWE/is0yf7N85D5AjGTNQMLcQ9sdbxOTLRN/t3qTbgMBQ+wy7/zr DpnPNINxsMR8FgICbMOitGU8JL8VuYZ8BVSfbevT6WYIUXMjZDLPxz+dnwwwCHYofGUm6168FjLGz upqVRmpkCPXQBB/OJW9qQ0vbLCQPp9grblncarG6VQgBLjgm2tBcbZwdrdglE/FUnTRh9odWgJTJF zPHgoeXg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jl8i4-0006g0-9z; Tue, 16 Jun 2020 10:20:52 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 29B2F3017B7; Tue, 16 Jun 2020 12:20:50 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 1453C203D5DB1; Tue, 16 Jun 2020 12:20:50 +0200 (CEST) Date: Tue, 16 Jun 2020 12:20:50 +0200 From: Peter Zijlstra To: Christoph Hellwig Cc: Vitaly Kuznetsov , Dexuan Cui , Stephen Hemminger , Andy Lutomirski , Andy Lutomirski , Michael Kelley , Ju-Hyoung Lee , "x86@kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , KY Srinivasan Subject: Re: hv_hypercall_pg page permissios Message-ID: <20200616102050.GP2531@hirez.programming.kicks-ass.net> References: <20200407073830.GA29279@lst.de> <87y2ooiv5k.fsf@vitty.brq.redhat.com> <87blljicjm.fsf@vitty.brq.redhat.com> <20200616093341.GA26400@lst.de> <20200616095549.GA27917@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616095549.GA27917@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 11:55:49AM +0200, Christoph Hellwig wrote: > + hv_hypercall_pg = __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, > + VMALLOC_END, GFP_KERNEL, PAGE_KERNEL_RX, > + VM_FLUSH_RESET_PERMS, NUMA_NO_NODE, __func__); I think that's wrong, they seem to want to CALL into that page, and that doesn't unconditionally work for any page in the vmalloc range. This really ought to use module_alloc() to guarantees it gets a page in the correct range.