Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2337160ybt; Tue, 16 Jun 2020 03:29:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdtefs34pSDt9kOqTwUbE5PH5wpV3CnnKy+XIr9iu04xRTiYa9XW68nOmlgh9x81algJJM X-Received: by 2002:a17:906:14db:: with SMTP id y27mr2147877ejc.225.1592303392616; Tue, 16 Jun 2020 03:29:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592303392; cv=none; d=google.com; s=arc-20160816; b=PnkvmE532XzkAQIzT2mQRv7BbwsXUZBsSRwCGNn+yRvOB14SASeMxXWEB9O19wz6Tr 1RCeOzS6DHfN2k5yr/mfj19Jaq1N2hqp6HkPhK4jPCLW9rS74uIm0K9wS/ieCw6RHw7D Fn2KIVTrWnp5DgJYDXy6aP7GSTEqD3KI9EONGb+jdE28E5Bv3AT2pXr16AZSZEZU4Eqw dtAdptGUoGhvNFPROaZvOulCqzsNkODEKESOmcAppcCSqCSnZRmmWM6b3oRUPj3SOgto Mp18q16pAAT7kmsy/KXFx0QdemjAxEDAXw4N/eM7wRkoWU9cXzwrkI2QtdqQyeupS5DQ 5Vpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=OEZ867EI2DrsbQs+3DAIrXDrkaUkWnkmsBFEWVMjZ8E=; b=O8A3vw0cR3LC4fvNCNGJX5sXcXNuTTrWtkRBFNOmPuntXy3gjMul3CKW1PNBMdzNrc jS0n6d/IsvFzYoJKOw6q9tpx3vwqtEMgtXL67yGDOTtK6JFOMyXLyDDFN+r+kD0RyjMt YOxY490ObGPdqLxHQ4L8NVABEMj7pUbAhNqYbxlvOmtp86hatzVbqmYR1KcFmVIcBdrQ aDHcXIkIm/9zXdgkO1egDo7UKRM353tjt1rEcdCulYWXEOScmFQiREGFNi/NBc8nJ8Ag JdS+CEDN/t+AIoVsC3YT5R3L+Y7Xp/X4em2T0DP4mjj9MvuhQqYCHDK91A1u58UHhdV2 EPqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6bU3A0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y33si6510808edy.206.2020.06.16.03.29.29; Tue, 16 Jun 2020 03:29:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W6bU3A0E; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728231AbgFPK1Z (ORCPT + 99 others); Tue, 16 Jun 2020 06:27:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:52414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728131AbgFPK1C (ORCPT ); Tue, 16 Jun 2020 06:27:02 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47D932074D; Tue, 16 Jun 2020 10:27:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592303221; bh=h+uJjTNyXThELVktOw4GwJ+7MZ17efhM9W2zSlxhrfE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W6bU3A0EaWVwqB76C7G7Q8IPA9+8NDlndx78P4FO5p55YBIboAQ+ng5RuIHbh7arj cDq2IabAY/pe4YgW8N+oycWxtz82vqVOx9X8cA2CW3t6pe1ufX8DiWIRg6MbpwFL4a 4lfwdoblwodIxGq5kz8hB3BKYLT1P24WTfkeaTDQ= Date: Tue, 16 Jun 2020 11:26:59 +0100 From: Mark Brown To: Robin Gong Cc: Vinod Koul , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "festevam@gmail.com" , "robin.murphy@arm.com" , "matthias.schiffer@ew.tq-group.com" , "kernel@pengutronix.de" , dl-linux-imx , "linux-spi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v1 RFC 1/2] spi: introduce fallback to pio Message-ID: <20200616102659.GK4447@sirena.org.uk> References: <20200615123553.GP4447@sirena.org.uk> <20200615133905.GV4447@sirena.org.uk> <20200615143622.GX4447@sirena.org.uk> <20200615145556.GY4447@sirena.org.uk> <20200616095948.GJ4447@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qE0/TkNoJLLGUzs4" Content-Disposition: inline In-Reply-To: X-Cookie: Offer may end without notice. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qE0/TkNoJLLGUzs4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jun 16, 2020 at 10:13:08AM +0000, Robin Gong wrote: > On 2020/06/16 Mark Brown wrote: > > I'd just make this a generic flag for failures before we start interacting with the > > hardware rather than specifically this one error case. Otherwise this looks > > fine. > So rename to SPI_TRANS_DMA_FAIL? I think at least DMA is MUST for fallback > case... This is not purely for DMA, it's just about the failure having occurred before the transfer started. How about _FAIL_NO_START? --qE0/TkNoJLLGUzs4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7onnIACgkQJNaLcl1U h9Cs0Qf8CdBZ6A+/Gn/ijwLKgPntYUIu7iNkeoHkhYqOXmt1S4e0m5GoT+ROMOLV k1elBNRfWqVdKJfHMzmk5wANM+F5XqTCOpWx0SErZRiSHMFb5V8gClcNBYTNL/eU 3A/I62fz09JL/onIv3qEkUTsWvL3Rq7VG0mAsJvL27oMRecxS0EwEGW33kaY9axI 59Irl+2GcI/oQchTMzeHBdBMd5bqdGjDvI2xSrqnbyip+/G1p6xHPmYRyypcl+AZ X976ervmpNe4o3XKh80pDajyx5aKgyQxgtB7cjE2UPSKXAgVhG+N8LWRwoAw03+y 1fXXMrymNw+yvlVU0QNEuMOYGRjTFg== =9EtT -----END PGP SIGNATURE----- --qE0/TkNoJLLGUzs4--