Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2358537ybt;
        Tue, 16 Jun 2020 04:07:19 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJz6ftaLKOtkKVvcbKTug4vLeyVdtok1DP+Guk8BX4yTJ59kx88p+xPaobLV4MQCN1GGAvSw
X-Received: by 2002:a17:906:d043:: with SMTP id bo3mr2120827ejb.409.1592305638790;
        Tue, 16 Jun 2020 04:07:18 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1592305638; cv=none;
        d=google.com; s=arc-20160816;
        b=BT5qCB9UxJCf0E+MLWGd0GlabP6pXadcb0zHDvecPTdOPgyhJakyvHQrz43eA+WYTz
         953tE4K3Ve7zQa+ivmU6/4MwRpBuxwDFsPy9qcX+MHKbeCRDbDaC6HXnMnyCxfhiXfPg
         ulDEvZFa8TgEz+pyOx4gyE0RZWq64j5M4RDjc8Py9ajWJFg7nv4itRRurZPISDR6byBZ
         bWyAZ1N8/mXklxOlOUw2KQTrE0o9K/rFlU67++ALr/pnAx6RSBHYToY141QSZ+lEEpII
         nW4DEnsueQPQw2gpsasrDh1JKJ3onnFmT63TQ3YTAibw264hoUksnQV18gJLkunqWVUw
         OYzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-language
         :content-transfer-encoding:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=c0YGt4W2m1Q+UO0mBqh2rQ5x2VAKCqzliHOfAsOz1WQ=;
        b=b6qlh8gDPyffVB3MrrfYv8Rs/xMGm1iXWXlAhTs4CjTZOFEatbX6q0W5f32/3POjgx
         zlOpwrrm8ta5TVeQE8LnVz6r9AwB9ic3sUTXIveAyZ6Hu+5Aln1kk5SZkj7RKSQSoKzN
         IuN1L4hm1mOskTYXUNKwAePyQ/DpUBCdebY1QvQIZdzdNj7hfKUj58SI7T4gK6BUzioV
         asGP23AFJ/8kONly82MhMxxjMGcAi8V5ECi4pLFQfQ8tKoRAPMjAW510PGViCd1eXypu
         WuIdKoVRYeDTcAXP02oOtqoA3nP10whVbvADwRA+um1bCtKWsYzgKm7tYTSJlZlwXqZu
         WjgQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id dk19si10030152edb.446.2020.06.16.04.06.55;
        Tue, 16 Jun 2020 04:07:18 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726526AbgFPLEp (ORCPT <rfc822;wxiaokuan@gmail.com> + 99 others);
        Tue, 16 Jun 2020 07:04:45 -0400
Received: from szxga04-in.huawei.com ([45.249.212.190]:6340 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1725901AbgFPLEi (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 16 Jun 2020 07:04:38 -0400
Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.58])
        by Forcepoint Email with ESMTP id 4FF21990F3B21C913701;
        Tue, 16 Jun 2020 19:04:33 +0800 (CST)
Received: from [10.166.212.221] (10.166.212.221) by smtp.huawei.com
 (10.3.19.213) with Microsoft SMTP Server (TLS) id 14.3.487.0; Tue, 16 Jun
 2020 19:04:28 +0800
Subject: Re: [PATCH 1/2] drm/amdgpu/debugfs: fix memory leak when
 pm_runtime_get_sync failed
To:     =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        <airlied@linux.ie>, <daniel@ffwll.ch>
CC:     <alexander.deucher@amd.com>, <David1.Zhou@amd.com>,
        <tom.stdenis@amd.com>, <Jack.Xiao@amd.com>, <yttao@amd.com>,
        <amd-gfx@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
        <linux-kernel@vger.kernel.org>
References: <20200616063039.260990-1-chentao107@huawei.com>
 <a8fb3d27-d0f5-d28a-d24b-63be866ef76f@amd.com>
From:   "chentao (AS)" <chentao107@huawei.com>
Message-ID: <882dba73-8384-919d-671c-a300db4ef0cf@huawei.com>
Date:   Tue, 16 Jun 2020 19:04:28 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <a8fb3d27-d0f5-d28a-d24b-63be866ef76f@amd.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-Originating-IP: [10.166.212.221]
X-CFilter-Loop: Reflected
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ok, i will modify it in v2 patch.

On 2020/6/16 14:50, Christian König wrote:
> Probably better to remove the duplication of result and r here and 
> then use "goto err".