Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/5] drm/omap: Fix suspend resume regression after
 platform data removal
To:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Tony Lindgren <tony@atomide.com>
CC:     <linux-omap@vger.kernel.org>, "Andrew F . Davis" <afd@ti.com>,
        Dave Gerlach <d-gerlach@ti.com>,
        Faiz Abbas <faiz_abbas@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Keerthy <j-keerthy@ti.com>, Nishanth Menon <nm@ti.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Roger Quadros <rogerq@ti.com>, Suman Anna <s-anna@ti.com>,
        Tero Kristo <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <dri-devel@lists.freedesktop.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
References: <20200531193941.13179-1-tony@atomide.com>
 <20200531193941.13179-2-tony@atomide.com>
 <16ba1808-5c7f-573d-8dd0-c80cac2f476e@ti.com>
 <20200603140639.GG37466@atomide.com>
 <47e286dd-f87a-4440-5bde-1f7b53e8b672@ti.com>
 <20200609151943.GL37466@atomide.com>
 <9ed70121-2a53-d2b3-051a-88eb83e6c53f@ti.com>
 <d03dd04f-6f2c-25ba-fe1f-d5fc0dfb5c68@ti.com>
From:   Tomi Valkeinen <tomi.valkeinen@ti.com>
Message-ID: <592501c9-2d94-b266-ae76-e383d3bffa29@ti.com>
Date:   Tue, 16 Jun 2020 16:01:39 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <d03dd04f-6f2c-25ba-fe1f-d5fc0dfb5c68@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11/06/2020 17:00, Grygorii Strashko wrote:
> 
> 
> On 09/06/2020 18:26, Tomi Valkeinen wrote:
>> On 09/06/2020 18:19, Tony Lindgren wrote:
>>>> But there's an extra runtime PM reference (dev.power.usage_count) that seems
>>>> to come out of nowhere. So when omap_drm_suspend is finished, there's still
>>>> usage_count of 1, and dispc never suspends fully.
>>>
>>> Hmm no idea about that. My guess is that there might be an issue that was
>>> masked earlier with omap_device calling the child runtime_suspend.
>>
>> Yes. It's how PM works. It calls pm_runtime_get_noresume() before starting the suspend of a 
>> device. So I guess omapdrm's suspend has been broken all the time, but it was "fixed" by omap_device.
>>
> 
> I think I might have an idea what is going wrong.
> 
> Before:
> +----------------------+
> |omap_device_pm_domain |
> +---------------+------+------+
>                  | device      |
>                  +-------------+
>                  | omap_device |
>                  +-------------+
> 
> omap_device is embedded in DD device and PM handled by omap_device_pm_domain.
> 
> static int _od_suspend_noirq(struct device *dev)
> {
> ...
> 
>      ret = pm_generic_suspend_noirq(dev);
> [1] ^^ device suspend_noirq call
> 
>      if (!ret && !pm_runtime_status_suspended(dev)) {
>          if (pm_generic_runtime_suspend(dev) == 0) {
> [2] ^^ device pm_runtime_suspend force call
> 
>              omap_device_idle(pdev);
> [3] ^^ omap_device disable
>              od->flags |= OMAP_DEVICE_SUSPENDED;
>          }
>      }
> 
>      return ret;
> }
> 
> Now:
> +------------+
> |ti sysc dev |
> +-+----------+
>    |
>    |
>    |   +-------------+
>    |   | device      |
>    +-->+             |
>        +-------------+
> 
> With new approach the omap_device is not embedded in DD Device anymore,
> instead ti-sysc (hwmod replacement) became parent of DD Device.
> 
> As result suspend sequence became the following
> (Note. All PM runtime PUT calls became NOP during suspend by design):
> 
> device
> |-> suspend() - in case of dss omap_drm_suspend() and Co if defined
> |-> suspend_noirq() - in case of dss *not defined", equal to step [1] above
> ..
> 
> ti sysc dev (ti-sysc is parent, so called after device)
> |-> sysc_noirq_suspend
>     |-> pm_runtime_force_suspend()
>      |-> sysc_runtime_suspend() - equal to step [3] above
> 
> And step [2] is missing as of now!
> 
> I think, suspend might be fixed if all devices, which are now child of ti-sysc, will do
> pm_runtime_force_xxx() calls at noirq suspend stage by adding:
> 
>      SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
>                        pm_runtime_force_resume)
> 
> Am I missing smth?

Isn't this almost exactly the same my patch does? I just used suspend_late and resume_early. Is 
noirq phase better than late & early?

  Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki