Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2473541ybt; Tue, 16 Jun 2020 07:05:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMujc0SBYcyHCZikVv8NCXV+ZsR73a+1rcsWVbHnwu7KKsv7v07qRPg8VaCkXeRGKF7Mul X-Received: by 2002:a17:906:7746:: with SMTP id o6mr3039274ejn.75.1592316338342; Tue, 16 Jun 2020 07:05:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592316338; cv=none; d=google.com; s=arc-20160816; b=g58ezs3HCX8Hta21mTwnOc1GUB1ZXVQpp0mYeSopW1QAu/FsemRe09n3m3wT2Z2KfT Sl804dbs+zhPYM3Mv/Sum8KKg7hYhdtufzfrl92gwkETRXCNHQe88q5zkkh2zP4f9344 9pdhokAoBWudCxpVqacf7XBgg4hKFYc3PNMFLlhZ1knHt/fddfnrpqtRPJ3XQJmsLAO6 C1t+pmRc1MxNF11WobMFiBcrz7fICchDkrZv2J94HA6Z6viYBwIJOcrCqataMyCwa3+2 DeeDitz3m+uWZfCY+3i5Mr97TwP0JXz/57TSgCAtuBBnoOTMrODvadXUyh/je3idnECi AeHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=qo9CnAT+aab0Ut3f7Yuy5n9QdYXS6e410dJb6BVWkRI=; b=vpv2Q0s3vahX+yJ28Yfg2WV5s5ET5LIk/RtFNELjmS/LlTCoIUd1i9cYY969vIPl3J 4XW5PPnYBGj5q706sJQXqqzSaJRLEU+zk1V3Ww90x90LicyPUEQZTq7FMwemh97gWfak gwRlFQcIQ0U7pR5fpoJLgibCo+bhJMX834ef5/LG5jyKMng0hgs3iraqycTanhk9LkFE HjcuFIlWQRdkbhGLvRFNH8+13JCER7lUcy7u+KRyt2blfiHEb0i2JYo75w3weSRM4tLH MOeNZKaZm9AML6htg9VQrCHSjbrjecL4NXxknbixtzrvP4b4fQJnfGAWYC+EndxjaLa1 bqkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Xums47GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o11si11278961ejc.714.2020.06.16.07.05.14; Tue, 16 Jun 2020 07:05:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=Xums47GE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbgFPOC0 (ORCPT + 99 others); Tue, 16 Jun 2020 10:02:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728908AbgFPOCZ (ORCPT ); Tue, 16 Jun 2020 10:02:25 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8B1C061573 for ; Tue, 16 Jun 2020 07:02:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=qo9CnAT+aab0Ut3f7Yuy5n9QdYXS6e410dJb6BVWkRI=; b=Xums47GEWXlRQz7J1HKYxW9gMr JD0TMHDcMhQ8xkqodcrWJFLIQd5swU5qrm/olpW54z3c3jZXeCzb03CYU1OzCW/gPla8Dui8ZQxLd n3flGqm0V+23+DraWxkS6YK/kfUgiJ+BHszJqzJK/lSlL7JvVGprakhRvXTvUA31LaUcBExJR1lA6 4gqKweGxBGnoey+ksrWp0GifwLUzSYDUTaddEMsOb9l2HvPjk6UubqlgBJc73xKbG694LiWav9uHY c/2Eq9hTzgS9T2eGm5ztDHu6jRtBrpOvFB6P52AHlZOw24SwWiw+bXPSGI0L7rBTq4d/CaktbIjRN UUMHW0kQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlCA4-0003JY-UF; Tue, 16 Jun 2020 14:02:01 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id E110630018A; Tue, 16 Jun 2020 16:01:58 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id CD7F22038E4EB; Tue, 16 Jun 2020 16:01:58 +0200 (CEST) Date: Tue, 16 Jun 2020 16:01:58 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Lichao Liu , mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched/rt: Don't active rt throtting when no running cfs task Message-ID: <20200616140158.GY2531@hirez.programming.kicks-ass.net> References: <20200616123729.153430-1-liulichao@loongson.cn> <20200616095027.1a2048d0@oasis.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200616095027.1a2048d0@oasis.local.home> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 09:50:27AM -0400, Steven Rostedt wrote: > On Tue, 16 Jun 2020 20:37:29 +0800 > Lichao Liu wrote: > > > Active rt throtting will dequeue rt_rq from rq at least 50ms, > > When there is no running cfs task, do we still active it? > > > > This is something I would like to have. > > Peter, what's your thought on this? I'd love to just delete all of this.. that said, I'm not sure this change makes sense, because it doesn't deal sanely with the case where the task will appear right after we did this. The right thing to do is that fair deadline server thing.