Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <d3346d7cb9655eb111b4126d72a08499c6254fef.camel@suse.de>
Subject: Re: [PATCH v4 4/5] dm: pci: Assign controller device node to root
 bridge
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Simon Glass <sjg@chromium.org>
Cc:     Matthias Brugger <mbrugger@suse.com>,
        U-Boot Mailing List <u-boot@lists.denx.de>,
        Bin Meng <bmeng.cn@gmail.com>, Marek Vasut <marex@denx.de>,
        lk <linux-kernel@vger.kernel.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Mark Kettenis <mark.kettenis@xs4all.nl>
Date:   Tue, 16 Jun 2020 16:09:49 +0200
In-Reply-To: <CAPnjgZ2jarQArKN=0h0mNnxE7gAL0juvGhMxMF4a0CehqxWcRw@mail.gmail.com>
References: <20200612164632.25648-1-nsaenzjulienne@suse.de>
         <20200612164632.25648-5-nsaenzjulienne@suse.de>
         <CAPnjgZ2jarQArKN=0h0mNnxE7gAL0juvGhMxMF4a0CehqxWcRw@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-hRzj0/dqG4z0PRQp4I9N"
User-Agent: Evolution 3.36.3 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-hRzj0/dqG4z0PRQp4I9N
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2020-06-16 at 07:43 -0600, Simon Glass wrote:
> Hi Nicolas,
>=20
> On Fri, 12 Jun 2020 at 10:47, Nicolas Saenz Julienne
> <nsaenzjulienne@suse.de> wrote:
> > There is no distinction in DT between the PCI controller device and the
> > root bridge, whereas such distinction exists from dm's perspective. Mak=
e
> > sure the root bridge ofnode is assigned to the controller's platform
> > device node.
> >=20
> > This permits setups like this to work correctly:
> >=20
> >         pcie {
> >                 compatible =3D "...";
> >                 ...
> >                 dev {
> >                         reg =3D <0 0 0 0 0>;
> >                         ...
> >                 };
> >         };
> >=20
> > Without this the dev node is assigned to the root bridge and the
> > actual device search starts one level lower than expected.
> >=20
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> > ---
> >  drivers/pci/pci-uclass.c | 15 ++++++++++++++-
> >  1 file changed, 14 insertions(+), 1 deletion(-)
>=20
> Can you update the tests to handle this case please?

I'd be glad to, but I'm not familiar with the test FW in u-booy, coud give =
me
some pointers on where/how to test this?

Regards,
Nicolas


--=-hRzj0/dqG4z0PRQp4I9N
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl7o0q0ACgkQlfZmHno8
x/6vIAgAinbtz9aWXY9OMZDE68tOQOYWeDK5wVp7zlk4hA1VI1QmdSWkZ0KV6f+r
GV+XxzmIAvxhv/G50aP5kqKy7KxB7oWTHCI4usPn3614DBKkxTrpshmmb+QiTCIM
ugTFiw34xaKlSh4MVsiUSp4R737RR5GoX+iajIsLNpITw875SPNn6GdzyL/KWm80
2ho2ptk0k+7o/2BXJpJ4BBcXgBBt74TZ7V/u4+LDbt1ZmRW5EGnxggl4W0vxed4n
xULWrW1ipAI+7E/BDNibGEb8cVbaKBcrDg4hdKBKZWLkavJctCwoWfCXGiNOvPM6
u4lYBsRWWCjDXmjx+rU+UGiVQqDVSw==
=cIdv
-----END PGP SIGNATURE-----

--=-hRzj0/dqG4z0PRQp4I9N--