Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200615154114.13184-1-mayflowerera@gmail.com> <20200615.182343.221546986577273426.davem@davemloft.net>
In-Reply-To: <20200615.182343.221546986577273426.davem@davemloft.net>
From:   Era Mayflower <mayflowerera@gmail.com>
Date:   Wed, 17 Jun 2020 01:02:00 +0000
Message-ID: <CAMdQvKvJ7MXihELmPW2LC3PAgXMK2OG6bJjPNJkCgE6eZftDVw@mail.gmail.com>
Subject: Re: [PATCH] macsec: Support 32bit PN netlink attribute for XPN links
To:     David Miller <davem@davemloft.net>
Cc:     kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jun 16, 2020 at 1:23 AM David Miller <davem@davemloft.net> wrote:
>
> From: Era Mayflower <mayflowerera@gmail.com>
> Date: Tue, 16 Jun 2020 00:41:14 +0900
>
> > +     if (tb_sa[MACSEC_SA_ATTR_PN]) {
>
> validate_add_rxsa() requires that MACSET_SA_ATTR_PN be non-NULL, so
> you don't need to add this check here.
>

validate_add_rxsa() did not originally contain that requirement.
It does exist in validate_add_txsa(), which means that providing a PN
is necessary only when creating TXSA.
When creating an RXSA without providing a PN it will be set to 1
(init_rx_sa+15).
This is the original behavior which of course can be changed.

- Era.