Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2662653ybt; Tue, 16 Jun 2020 11:38:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4z3fTj5/RtQx4rICzKw+BIWctzhD1ItXTwv7Zb9NL84crcNtLfHX8S1wBbXaDoVaTd8Ez X-Received: by 2002:a17:906:3499:: with SMTP id g25mr3956522ejb.518.1592332720475; Tue, 16 Jun 2020 11:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592332720; cv=none; d=google.com; s=arc-20160816; b=VYjRZ8DEPy/6zFw9yQldGZw6pgBDulSapTttgHUztPYxSTlxQAIB/9hQxEHmfAM9dR IiGbcbpnigxw8oGj0/AEKcpWIxQxEHySL+2ayB5LbA0r2zbFAntiWemtYiZD4V4hL6O4 VvVy9kQkw129OtydRW+vYYSvgHRifPXzERs5ZVlb1x9D70jeux9YzDXB5n/QRtvrPmMW W1TzwUmuUpDVxWCAnY6FpvVe95wc9Cwo4fYv54FtZjGQQGuo4AJdf0D9yq5Jyt6bgzYU l/5SdAWhpDcREqRA+ixlufjj3bXiZV2PVYf+uJaoN+MVG2zbd3S1ZkMjucobPeV7OcBm bOnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=g3E7T+TsuLEPIVGX6SgU/+v1tRfvZltwBLZZbmQ5szU=; b=SMQRdVG/rD9XwySFy4GcbSLQmYNhTYOrUlDWp8Xheh9YUuAMc41gieGVcKDwn3vtzg vpYCwdkBYgMzDaMZdytGEihApVmwzF2TnImipvcvH0vLZ8HZPDIHSu8t4LTqsDikpYKm VemXBy/sOqU17XbbGR2L6MkejhUFU1AXgX3TQDDvqBBLBlzJulLnDzVP4ekV0YbkOrIy VsTqp8KYAQTp+IijR7aSvhwzz2ATGxf0/f46C/I00SY1XCcDBcM4bhKgHgr0s+gxgqiP 206/wkxucTRJXpZrYntmglPLe46a/zvVWAI503sMU+/YT3ATgYj4DcfJHJfs8ImJ5/ry GgEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tj/iyfEL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k7si10955366ejg.316.2020.06.16.11.38.17; Tue, 16 Jun 2020 11:38:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="tj/iyfEL"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729241AbgFPSgF (ORCPT + 99 others); Tue, 16 Jun 2020 14:36:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:33792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbgFPSgE (ORCPT ); Tue, 16 Jun 2020 14:36:04 -0400 Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 055CF2082F; Tue, 16 Jun 2020 18:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592332564; bh=ygQw5Actl08lZMVXKCgVgtsSty25n+2zY0/omqxOYLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tj/iyfELOQfWQKfZYRlE+bdGM9rpxcBcCT5k+18bsKLbIcMYvt0geXm/Y2GCZ6gHl /pcjFwHd0tgR6+tSlfAbCRQaMGOS5Bx3jJ7ihplGFAa4kLKlCutasfZAl2vU8IGyja VnyuM91jARusgdgYCClFkpGRHOjtZdG+lshXmLVo= Date: Tue, 16 Jun 2020 11:36:01 -0700 From: Andrew Morton To: js1304@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Rik van Riel , Minchan Kim , Michal Hocko , kernel-team@lge.com, Joonsoo Kim Subject: Re: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" Message-Id: <20200616113601.a8ab80635b6434efe43d2ffc@linux-foundation.org> In-Reply-To: <1592288204-27734-3-git-send-email-iamjoonsoo.kim@lge.com> References: <1592288204-27734-1-git-send-email-iamjoonsoo.kim@lge.com> <1592288204-27734-3-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Jun 2020 15:16:43 +0900 js1304@gmail.com wrote: > Subject: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" I'm having trouble locating such a patch. > Non-file-lru page could also be activated in mark_page_accessed() > and we need to count this activation for nonresident_age. > > Note that it's better for this patch to be squashed into the patch > "mm: workingset: age nonresident information alongside anonymous pages". > > Signed-off-by: Joonsoo Kim > --- > mm/swap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 667133d..c5d5114 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -443,8 +443,7 @@ void mark_page_accessed(struct page *page) > else > __lru_cache_activate_page(page); > ClearPageReferenced(page); > - if (page_is_file_lru(page)) > - workingset_activation(page); > + workingset_activation(page); > } > if (page_is_idle(page)) > clear_page_idle(page); AFAICT this patch Fixes: a528910e12ec7ee ("mm: thrash detection-based file cache sizing")?