Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2666726ybt; Tue, 16 Jun 2020 11:46:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4kEoTQXp4xumxBkVrrX04rR/6MHnb2WJq8++kikSV3eyjPVeqXhpWQheVXRSXakaCvLcS X-Received: by 2002:a17:906:328a:: with SMTP id 10mr3783283ejw.265.1592333162554; Tue, 16 Jun 2020 11:46:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592333162; cv=none; d=google.com; s=arc-20160816; b=iqEVxeXLojrfOMC6vnN/RdJkQ9WjoIX95VPuBqHtglhwm8N1WmeL+AN6BcX6D0zab6 GVBho2RWbr/LQ6ZWLJRoEcE24vUoc0YIw4H0uLyfbn23+o6596roZARs3ZuXPEsLogMv zYaU/3hTyWDRuw20Sn+AeT0nBlNi4OzHQZPawyX8EG6hz0pUnECiLK5u4deMicC0VwtK ROtyp9Q4D1sutJk4BfeDeIkrftnHT9SQiBdf2XPJpmDHLOLObjdQjokMD85Z2t8e2ktD 0e+dgtvoBWgdW3nJh5jW9a2P1vv5uw7nMExWBa9286SyXjxGlN/aeIy1LNxwcksufm+A Ezmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=jQRkR7McObJFQyLrKaEvXEWgrNkrjo6daR1hjZ5rIUg=; b=l2ollVCSRIIHWcfgCoxyj6BQwaN2XGlbaVSM6B3dcEGVqCYQrEl3xQFNwKj4iOSqmR uik/J3eo5Db51SgsJcaYdNN9EYBt3nTuBBVaLWTAbuZLEVB6pJr4OEIfdp7H/8WHJfb1 dlgydmi/dDywttD23k8SlQg74pj9SOUmAiSP9JA6h7S5olCWhm+vAmntTiyBuvpJ4urd QINpW4AuLTDC2iba8iilx0hX6qfuo/bVb0Np/0nF01WieKtZ63A3MpyBPhL54fFKWzbg CTQrNXQXHsXRBl5agLJdb8+GSjpm81ErK4lqosw0EQABxVZgQDJLO1kSbHZKrKtgkDOe GkwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aGv9Om6O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y2si11885069edv.25.2020.06.16.11.45.39; Tue, 16 Jun 2020 11:46:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=aGv9Om6O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbgFPSnq (ORCPT + 99 others); Tue, 16 Jun 2020 14:43:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725911AbgFPSnq (ORCPT ); Tue, 16 Jun 2020 14:43:46 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23CE4C061573 for ; Tue, 16 Jun 2020 11:43:46 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id m7so8773235plt.5 for ; Tue, 16 Jun 2020 11:43:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=jQRkR7McObJFQyLrKaEvXEWgrNkrjo6daR1hjZ5rIUg=; b=aGv9Om6OtQxg3xs0G6MCndunFofM9NkscGXm8UQatgIx5QpFMqn3s52ln98T0M4HpX 5kYwgyH5LAhdYSYBtFxmUWOfkqVLksFx9tRc3dH8CHI0VqIKXrkk8yIWvBfKFeUy+231 rXjhY93RauL3WQ3NFrpmjWHZayqrY/ilrKMrM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=jQRkR7McObJFQyLrKaEvXEWgrNkrjo6daR1hjZ5rIUg=; b=JePf54kk/T7fTGD4pcW1l97RSGz97mUDNMtQT/1hO7DFZHmmxdwop0WGEHv0MuLzQb jvEBBG1dpuIoDb32UJJkn2WoyuYuQzx5xyNMoe0hnImF9KobkddmAlMoD6mXLdzsI4WE BbxWTjhh1BuejengqvCfSwzZQeSr9kdHL+l+uoW7S7jc1nWLcKMynZQ7B7qsb55dLjqJ lV2gRA+t1KExEXQNc/T6WREeU2iytXmJ8WoDfcpVmHAjmfT4clDqFULlAMv0zRQXc1zF wMCKN8tQHrkn+la+4ZYCqCIiGunW0Msxyr0NbduJQhvXsDQpDJVoRX7aZQjFIMlxyki5 JNMw== X-Gm-Message-State: AOAM531b3Bl+idlymFCY0oYFLcYEd68O060xZIsqnXo/6CTlsyTgWnPf 6vk/TnaKElRPozzlk0eGr+X9Fw== X-Received: by 2002:a17:90a:e387:: with SMTP id b7mr4511819pjz.176.1592333025739; Tue, 16 Jun 2020 11:43:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id f14sm15445770pgj.62.2020.06.16.11.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 11:43:44 -0700 (PDT) Date: Tue, 16 Jun 2020 11:43:43 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Steve French , linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] cifs: misc: Use array_size() in if-statement controlling expression Message-ID: <202006161143.5A4226EC3A@keescook> References: <20200615224112.GA12307@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615224112.GA12307@embeddedor> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 15, 2020 at 05:41:12PM -0500, Gustavo A. R. Silva wrote: > Use array_size() instead of the open-coded version in the controlling > expression of the if statement. > > Also, while there, use the preferred form for passing a size of a struct. > The alternative form where struct name is spelled out hurts readability > and introduces an opportunity for a bug when the pointer variable type is > changed but the corresponding sizeof that is passed as argument is not. > > This issue was found with the help of Coccinelle and, audited and fixed > manually. > > Addresses-KSPP-ID: https://github.com/KSPP/linux/issues/83 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook