Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp2701206ybt; Tue, 16 Jun 2020 12:45:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyGWMq2EobWcqyT3Dr7eb44ecrTE5+qOXjtp8XjaPQVU8V5ElQPbDYyY9RfU+nJwwy/vFzs X-Received: by 2002:a17:906:3282:: with SMTP id 2mr4147120ejw.93.1592336752742; Tue, 16 Jun 2020 12:45:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592336752; cv=none; d=google.com; s=arc-20160816; b=v46bF9QQiBPNlVR6nfbOhW8fwUDpXk7A8L9//bRU2+R+pp/MWcexrSjLLW09BWT2u+ CkJolW1mty5VguW6GPg+0JYhORqCUW6X2zcHHOdriXiIxJXCqLY1VfSjQUnADuxuRa0Q vdBQq3+Vf5Z6vhNlKacCBzUyUkJAuPx2EJM0U2jsk8+daEGfHNWaBRc5bj8WSgO/izCU CZYPJZ9ehBb4YUnHehk7to6W8H8Ve7oJrt3Pk1Ma180oM75iRRCrFUCoLHvH0571xpBH +t2BpE5BlnoxKOW54HQ5XTNtFwH0qwrILJSgIR8f6EGwUIFp5i5GErPXLuUZTewHLVKg Gmig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=2/zEBBal6vWHnUavjJFtDfhVGQ032vP+7H0mYPV3gMo=; b=jRz/rPlr+8T7Msgh+a+vqwLYgPPmZbwUZEy/FhDwiAiowEgBlo5WpzDxRpLHp/STv3 ZpEQ/58YuEHSWXUf+370DQNhcYMzLaEXo86xf3vsonbZf9MfyBhpmuxWTVKDDoa/vq3a PISTZTDiTSOmh/7IxxsyJz35nuWunvk3FpjpgAZz/Er0Ab3KTFWukxK12aOujKtbOni9 ozGSkEGlDrHlFvv5/OOEzrdRbq1s9TFMfb6xioIYTMDvVHYU7nuY6nC2zIrnKwSCIPBc xSSGqWL1T2uwbjrKAx71aJViAXAnYg4zZa5qcdR8kj0hE6rIqv1kCAsTvqn71Gk04MqA gmxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zZn0AlQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rk22si11802019ejb.461.2020.06.16.12.45.29; Tue, 16 Jun 2020 12:45:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zZn0AlQA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731156AbgFPTnF (ORCPT + 99 others); Tue, 16 Jun 2020 15:43:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:44362 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728144AbgFPTnF (ORCPT ); Tue, 16 Jun 2020 15:43:05 -0400 Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB99C208C3; Tue, 16 Jun 2020 19:43:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592336585; bh=4opddBx1OaE34iQ/v5+Xpl7I6itVGPI8xn9MndRWZ3U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zZn0AlQAZEerM5YU025XmSMmwOjA1q5/ZWfpj9XaIvSPU63Tq6hdqwVRc5CtXUVVR pMNXT4aMqpj2GSENieOni8xfcTAzWN28ku+hf2rz998z/l1Xi/mMCePv3Pbg8PWu+N reE5D3WTgC3m+Sd4QbvHA4fd31flQqI8pjt6gAhU= Date: Tue, 16 Jun 2020 12:43:04 -0700 From: Andrew Morton To: Mike Rapoport Cc: Michael Ellerman , Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH] powerpc/8xx: use pmd_off() to access a PMD entry in pte_update() Message-Id: <20200616124304.bbe36933fcd48c5f467f4be9@linux-foundation.org> In-Reply-To: <20200615092229.23142-1-rppt@kernel.org> References: <20200615092229.23142-1-rppt@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Jun 2020 12:22:29 +0300 Mike Rapoport wrote: > From: Mike Rapoport > > The pte_update() implementation for PPC_8xx unfolds page table from the PGD > level to access a PMD entry. Since 8xx has only 2-level page table this can > be simplified with pmd_off() shortcut. > > Replace explicit unfolding with pmd_off() and drop defines of pgd_index() > and pgd_offset() that are no longer needed. > > Signed-off-by: Mike Rapoport > --- > > I think it's powerpc material, but I won't mind if Andrew picks it up :) Via the powerpc tree would be better, please.