Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAHk-=whfuea587g8rh2DeLFFGYxiVuh-bzq22osJwz3q4SOfmA@mail.gmail.com>
In-Reply-To: <CAHk-=whfuea587g8rh2DeLFFGYxiVuh-bzq22osJwz3q4SOfmA@mail.gmail.com>
From:   Gabriel C <nix.or.die@googlemail.com>
Date:   Tue, 16 Jun 2020 22:11:46 +0200
Message-ID: <CAEJqkgi3w+zvMkRBP4VtAewX1UJxrVNRQ03MtRN_yH-PwOOScQ@mail.gmail.com>
Subject: Re: Linux 5.8-rc1
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

* Am So., 14. Juni 2020 um 22:44 Uhr schrieb Linus Torvalds
<torvalds@linux-foundation.org>:

Hello,

> So I didn't really expect this, but 5.8 looks to be one of our biggest
> releases of all time.
>

I hit a compiler error caused by e4160b2e4b02377c67f8ecd05786811598f39acd.

x86/purgatory: Fail the build if purgatory.ro has missing symbols

Having CONFIG_STACKPROTECTOR* & CONFIG_KEXEC_FILE enabled always
results in a linking error like this:

LD      arch/x86/purgatory/purgatory.chk
ld: arch/x86/purgatory/purgatory.ro: in function `verify_sha256_digest':
purgatory.c:(.text+0x108): undefined reference to `__stack_chk_fail'
ld: arch/x86/purgatory/purgatory.ro: in function `sha256_transform':
sha256.c:(.text+0x1c74): undefined reference to `__stack_chk_fail'
ld: arch/x86/purgatory/purgatory.ro: in function `__sha256_final':
sha256.c:(.text+0x1e65): undefined reference to `__stack_chk_fail'
ld: arch/x86/purgatory/purgatory.ro: in function `_kstrtoull':
string.c:(.text+0x2107): undefined reference to `__stack_chk_fail'

I didn't look closer at that but from the error, it seems to be,
some missing -fstack-protector* vs -fno-stack-protector* checks
somewhere.


Best Regards,

Gabriel C