Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp56605ybt; Tue, 16 Jun 2020 16:25:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziZfsFa+ZvQsBfu8xr+/8qmGDZrd7aq1B8YnqdxLCR/jyTvk0H0+HmKb8CEq8VSKQd9SWH X-Received: by 2002:a17:907:7014:: with SMTP id wr20mr3108150ejb.251.1592349959537; Tue, 16 Jun 2020 16:25:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592349959; cv=none; d=google.com; s=arc-20160816; b=lYlWHHllIznT2LtVxZu2P91YrXxpiatsJBr9djy9WwxQFMKqOfLCo5UKqaKcXLgboF VkKx40NHxHbmwlLtkYfhhPzNlB3TafIVfTG+QR1D0l6LqBLH5rLNvDvk6g68DPvu3EBN CEDTZMvYywAAqtI9sEHl+nx07Kv4ZuFBjC3POLcdHOWdD2/xxfoI1uOiynE1W1apYldR w2WSs4Vox234Z2/mGQB+oAOThu15dcrIcm4GZBqGQ4LayV8BYT+5kcHTnmnWdJmt/nc3 Me8CG2hBG+NBOW4A0Q8co7DMVsx7OZmnPwkV8ejgR339VnA3k643Sreyc9PAn4x1fZME dOxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=Za6bQU8TW/1cpWCiCN5aQwouJ7nyG9toMOLoLghzm4E=; b=aSt13I5ZEe+6DgqlvkELdscQPTVptVyOkDJOJHEkq9bf9qRTUHw3kjwAljWQbXwwnY VQ4B/5jEb8pUYnqHNltkc8zfpg1IXQJo/xNH5yuh77hrFGRBnjAYQx5hc+xjYWzV5Rpo PlMjqSJphIKmVR56RZ6RPA/qUXkEXFhtVFr63q80iYP6Psu36IWyPPaWoKLoDwvci7+g qfT3flMN1eobOzjmcg7WvHQzuM0Qg/h3qvkfLnLGD/Ap2iKXw/BswrHIwbEj2DY2BVE2 0c/ZatezFOmuRYlrf2m5HnfRXI/kPuunVKw3JOOvwJ5R6d4YDwXKOKzg5uTs9k4jAyUO 2PMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=TjLBhP6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i17si15092772ejo.179.2020.06.16.16.25.37; Tue, 16 Jun 2020 16:25:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ellerman.id.au header.s=201909 header.b=TjLBhP6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726523AbgFPXVR (ORCPT + 99 others); Tue, 16 Jun 2020 19:21:17 -0400 Received: from ozlabs.org ([203.11.71.1]:42775 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgFPXVR (ORCPT ); Tue, 16 Jun 2020 19:21:17 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 49mkj62czzz9sRR; Wed, 17 Jun 2020 09:21:14 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1592349675; bh=YglC3d1qIVwIT/vjXu+XckyVGaLr6tr684jtKcQd7wA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TjLBhP6F5nvAq3REnn28vPAfAN4v2wNRC3IswZSOd3M1v2oMLUr3ZaarOk/kGkbNe l2bXoy7UF17GYKU2mlwqnp3A3sJGbG69OHzkz9w4kk9DKZrGXU3iRShzRVFHnw36Kc mlXGwtKpTsiUvUPcXeTZ/OH288mn4G1fwqul/FaDegm2WRnMaxF58Hs4pWGuM53BCx kbDgoRiGGj0QirPmEdKWaFCoYE+6QuWoHcp++BilPwisIW/Ss3Hqh9cmqu1R88H2Ne UHpEVFkkOZbaao2+YIa/+rvxgw7yOfB+lMNLRib3Za/8phJL6Y13Y8EbdWImFgTtit c//M/lvPC+WIQ== From: Michael Ellerman To: Andrew Morton , Mike Rapoport Cc: Christophe Leroy , linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Rapoport Subject: Re: [PATCH] powerpc/8xx: use pmd_off() to access a PMD entry in pte_update() In-Reply-To: <20200616124304.bbe36933fcd48c5f467f4be9@linux-foundation.org> References: <20200615092229.23142-1-rppt@kernel.org> <20200616124304.bbe36933fcd48c5f467f4be9@linux-foundation.org> Date: Wed, 17 Jun 2020 09:21:42 +1000 Message-ID: <87o8piegvt.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton writes: > On Mon, 15 Jun 2020 12:22:29 +0300 Mike Rapoport wrote: > >> From: Mike Rapoport >> >> The pte_update() implementation for PPC_8xx unfolds page table from the PGD >> level to access a PMD entry. Since 8xx has only 2-level page table this can >> be simplified with pmd_off() shortcut. >> >> Replace explicit unfolding with pmd_off() and drop defines of pgd_index() >> and pgd_offset() that are no longer needed. >> >> Signed-off-by: Mike Rapoport >> --- >> >> I think it's powerpc material, but I won't mind if Andrew picks it up :) > > Via the powerpc tree would be better, please. I'll take it into next for v5.9, unless there's a reason it needs to go into v5.8. cheers