Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932517AbWCWWdG (ORCPT ); Thu, 23 Mar 2006 17:33:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932522AbWCWWdF (ORCPT ); Thu, 23 Mar 2006 17:33:05 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:38599 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S932518AbWCWWdE (ORCPT ); Thu, 23 Mar 2006 17:33:04 -0500 Message-ID: <4423221D.6020109@garzik.org> Date: Thu, 23 Mar 2006 17:33:01 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5 (X11/20060313) MIME-Version: 1.0 To: "J.A. Magallon" CC: "Linux-Kernel, " Subject: Re: [PATCH] Lower e100 latency References: <20060323014046.2ca1d9df.akpm@osdl.org> <20060323220711.28fcb82f@werewolf.auna.net> <20060323221342.2352789d@werewolf.auna.net> In-Reply-To: <20060323221342.2352789d@werewolf.auna.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.0.5 on srv5.dvmed.net summary: Content analysis details: (-2.5 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 548 Lines: 17 J.A. Magallon wrote: > if (unlikely(!i)) { > - printk("e100.mdio_ctrl(%s) won't go Ready\n", > + DPRINTK(PROBE, ERR, "e100.mdio_ctrl(%s) won't go Ready\n", > nic->netdev->name ); NAK. Its already unlikely, and if this fails, you SHOULD print something out. The rest seems mostly OK. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/