Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp77597ybt; Tue, 16 Jun 2020 17:07:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwBQN7lSvkdTDRc2pPsLzzYFu3AXWWLGvQJfrXksrUAYvRSeTww5vLS3eFbJJRrAriZjxqh X-Received: by 2002:a17:906:2e9a:: with SMTP id o26mr4967435eji.538.1592352420903; Tue, 16 Jun 2020 17:07:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592352420; cv=none; d=google.com; s=arc-20160816; b=SP1DR1KCzb66q4TxXPai8n5cMZrVk0ZWH44X7xZpLsV1AcV3WktqbcSaAceD+4Q+gy xuh8p6aYZ1RIwmkbs4ZhuEdhGX62FD0jBE3/+/yDQnGI7rkEfUaPD8NtX42tCvyc2ydt cvrIOJc7z2n1/alAm+XWQer++QL6I8XJ0/GltyUjE8ZLpHuVbiM1akD6pfWjnRVj6OGB govO3pCl5H/eQQdIRcDSAojEtOv5ILJWKFi3WgKqYqvIYepXM12gL6dAG/Z4Q7FHrHIw Zi7yYb+z2Ma8yns1fV4zCIgk4L7xTPS/aFjvMbIzRkx3xwZXX0yNNdCnFNdif1PrwTg0 fvBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Oe/hKAKHGvJszycxiAbC2N5QfwK/kv0uW4M610gYZnY=; b=xezTK1c6lQJHCgPcTcQ2fAMjh2OzEMEHUQWw7szzjztScPN5xd+FvPDEPv8wFM3Pcz 72k/WjS/rfM1JS8z560CUYifxilKkKi/PG6bpkIWeiN8PwdApThb03GHF0A+U5j6Q/M6 1eqalUqfenFVCA0J9ISxpTK/cvus/krWiYhIRqpWt15ZnQaUoJT/J3i6rOefdxMMDOqz 7ibzS+bSSxMODZlASTLTH4BQ14xFvPR+PcF+xG+fi8TJxKu2bhxTfmtuVcC12PqZGdoa S73Gf2kzCMxdwVJg7GjqzRPlfWOMnx863re0+FvKK8P9RG4zmtEEk2hYJTD+ghGotpGc +4yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Uzye1Hii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd5si12015205ejb.84.2020.06.16.17.06.37; Tue, 16 Jun 2020 17:07:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Uzye1Hii; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbgFQACs (ORCPT + 99 others); Tue, 16 Jun 2020 20:02:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726025AbgFQACs (ORCPT ); Tue, 16 Jun 2020 20:02:48 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EAE5C061573 for ; Tue, 16 Jun 2020 17:02:47 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id d8so74501plo.12 for ; Tue, 16 Jun 2020 17:02:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Oe/hKAKHGvJszycxiAbC2N5QfwK/kv0uW4M610gYZnY=; b=Uzye1Hii/AU8ot5ff4TsthmYVWhTUyRMrsmmfyHoIJqYq0Eczq1dwhp+mbdXjzxeAk 9wtUHLgg37QXJIUyFQ6rDtjQp3FQFt9exXKj6glBGuADuVrm6eo0dkXUYsQLogY6rCI9 BpLcmQTqsen/Cx1v4BpvB1mjEzFdSmlc8bDSU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Oe/hKAKHGvJszycxiAbC2N5QfwK/kv0uW4M610gYZnY=; b=Gm+5gXIeXtbYMWsBPMAnBaZi/J5b+Sdbvnts1IGTw7XQAgAypz9CqVFNnJOKmjlp3E 6+4SdfCs0CCmbFKOfb1efJ/ccL+/0hgGsfUw7lTXPO0cJS/NC4q5BKj4ftmtji4VL6nk 9l76fQKDYtMF1J+HvCscA/PFbmD5G9kI4G1ZzuI6L3RhH+85nlSjXzAbU9Z0A9sPiQpA OCkPUs2xidmO9fLcQn18fcl1vx/hmgSQpBPGYK5nz8lbcWIsNHkn9DZFVjnaOVY9qLfW PXerSwtIi2MusILdPj7/zWd6DCb5e1NbD5D3WZqXiTWlkSB8Q/0D4kTC64oyBHnWjYmh VPpQ== X-Gm-Message-State: AOAM53043aAA6aiXrux3U67p+nP3AoAr4Y2owUpok45Ce3V9C0SMRPg0 yY3nl8VRTsMliSDDh7FPMVVU3Q== X-Received: by 2002:a17:90a:be09:: with SMTP id a9mr4981100pjs.43.1592352166752; Tue, 16 Jun 2020 17:02:46 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 10sm17861488pfn.6.2020.06.16.17.02.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Jun 2020 17:02:45 -0700 (PDT) Date: Tue, 16 Jun 2020 17:02:45 -0700 From: Kees Cook To: "Bird, Tim" Cc: Brendan Higgins , David Gow , "shuah@kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Paolo Bonzini Subject: Re: RFC - kernel selftest result documentation (KTAP) Message-ID: <202006161701.685284F@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 16, 2020 at 08:37:18PM +0000, Bird, Tim wrote: > One thing that needs to be rationalized between KUnit and selftest > is the syntax for subtests. KUnit follows the TAP14 spec, and starts > subtests with indented "# Subtest: name of the child test" > and selftests just indents the output from the child test, so it > starts with indented "TAP version 13". One issue I have with the > TAP14/KUnit approach is that the output from the child is different > depending on whether the test is called in the context of another > test or not. Right -- I'd *really* like the subtests to be "separable", since the primary issue is actually that a subtest may not know it is a subtest, and passing that knowledge in may be difficult/disruptive. -- Kees Cook