Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WnXuZpfr0F0rncc7t1hrc7P9wVgIfMvlhQ4Q1HqOj9IrW6ZYivFA79DVk/c5BpLSA61TjY+pTt
 LxsV4E8ktrjA==
IronPort-SDR: MAkF63yb+K9N07U4j2cEULH3Hiur+Q7TSSFkmxQobO+NCSat8OsJpSg2vz/qYdwT7hIiUSIfVy
 SOgJXG7rrn3w==
Date:   Wed, 17 Jun 2020 04:05:46 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To:     amirmizi6@gmail.com
Cc:     Eyal.Cohen@nuvoton.com, oshrialkoby85@gmail.com,
        alexander.steffen@infineon.com, robh+dt@kernel.org,
        peterhuewe@gmx.de, christophe-h.richard@st.com, jgg@ziepe.ca,
        arnd@arndb.de, gregkh@linuxfoundation.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-integrity@vger.kernel.org, oshri.alkoby@nuvoton.com,
        tmaimon77@gmail.com, gcwilson@us.ibm.com, kgoldman@us.ibm.com,
        Dan.Morav@nuvoton.com, oren.tanami@nuvoton.com,
        shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com,
        Benoit Houyere <benoit.houyere@st.com>
Subject: Re: [PATCH v10 2/8] tpm: tpm_tis: Fix expected bit handling and send
 all bytes in one shot without last byte in exception
Message-ID: <20200617010546.GB5100@linux.intel.com>
References: <20200604134713.157951-1-amirmizi6@gmail.com>
 <20200604134713.157951-3-amirmizi6@gmail.com>
 <20200617010050.GA5100@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200617010050.GA5100@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 17, 2020 at 04:01:12AM +0300, Jarkko Sakkinen wrote:
> On Thu, Jun 04, 2020 at 04:47:07PM +0300, amirmizi6@gmail.com wrote:
> > From: Amir Mizinski <amirmizi6@gmail.com>
> > 
> > Detected the following incorrect implementation of the send command:
> > polling on the TPM_STS.stsValid field followed by checking the
> > TPM_STS.expect field only once. Since TPM_STS.stsValid represents the
> > TPM_STS.expect validity, both fields should be polled at the same time.
> > 
> > This fix modifies the signature of wait_for_tpm_stat(), adding an
> > additional "mask_result" parameter to its call. wait_for_tpm_stat() is now
> > polling the TPM_STS with a mask and waits for the value in mask_result.
> > The fix adds the ability to check if certain TPM_STS bits have been
> > cleared.
> > 
> > This change is also aligned to verifying the CRC on I2C TPM. The CRC
> > verification should be done after the TPM_STS.expect field is cleared
> > (TPM received all expected command bytes and set the calculated CRC value
> > in the register).
> > 
> > In addition, the send command was changed to comply with
> > TCG_DesignPrinciples_TPM2p0Driver_vp24_pubrev.pdf as follows:
> > - send all command bytes in one loop
> > - remove special handling of the last byte
> > 
> > Suggested-by: Benoit Houyere <benoit.houyere@st.com>
> > Signed-off-by: Amir Mizinski <amirmizi6@gmail.com>
> 
> Just wondering how did you come up with that name since you are not
> masking anything with 'mask_result'?

Maybe just rename it as 'stat'? That would make the whole thing a lot
less confusing looking I think.

/Jarkko