Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Bird, Tim" <Tim.Bird@sony.com>
To:     Kees Cook <keescook@chromium.org>
CC:     Brendan Higgins <brendanhiggins@google.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Paolo Bonzini <pbonzini@redhat.com>,
        David Gow <davidgow@google.com>
Subject: RE: RFC - kernel selftest result documentation (KTAP)
Thread-Topic: RFC - kernel selftest result documentation (KTAP)
Thread-Index: AdY/UfZiI2pZQBRwRN+1JBazpeVQogEzX+2AAAAmIWAABsPVgAAExn9A
Date:   Wed, 17 Jun 2020 02:30:45 +0000
Message-ID: <CY4PR13MB1175DCC4066FC0839A6B2E84FD9A0@CY4PR13MB1175.namprd13.prod.outlook.com>
References: <CY4PR13MB1175B804E31E502221BC8163FD830@CY4PR13MB1175.namprd13.prod.outlook.com>
 <20200616204817.GA212825@google.com>
 <CY4PR13MB1175A71AE3937C0786721ABFFD9D0@CY4PR13MB1175.namprd13.prod.outlook.com>
 <202006161703.B2E51605@keescook>
In-Reply-To: <202006161703.B2E51605@keescook>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cbfa04c-9439-480e-2783-08d81266706d
X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2020 02:30:45.3891
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 66c65d8a-9158-4521-a2d8-664963db48e4
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: akndlvcRFDy+Gd3ayiJdXLK2pFHc3KEBAQLudAbWoGXA37yev4/5s6hH7YveJRHEFK5zlHCbg5HP/mzsCtfJvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1301MB1957
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Kees Cook
>=20
> On Tue, Jun 16, 2020 at 09:16:01PM +0000, Bird, Tim wrote:
> > So far, most of the CI systems don't parse out diagnostic data, so it d=
oesn't
> > really matter what the format is.  If it's useful for humans, it's valu=
able as is.
> > However, it would be nice if that could change.  But without some forma=
lization
> > of the format of the diagnostic data, it's an intractable problem for C=
I systems
> > to parse it.  So it's really a chicken and egg problem.  To solve it, w=
e would have
> > to determine what exactly needs to be provided on a consistent basis fo=
r diagnostic
> > data across many tests.  I think that it's too big a problem to handle =
right now.
> > I'm not opposed to migrating to some structure with yaml in the future,=
 but free
> > form text output seems OK for now.
>=20
> For a CI system, if I see a test has failed, I expect to be able to
> click a link to get the log of that test, which includes the diagnostic
> lines. The other reason to have them there is to show progress during a
> manual run.
Agreed.  You only need machine-parsable data if you expect the CI
system to do something more with the data than just present it.
What that would be, that would be common for all tests (or at least
many test), is unclear.  Maybe there are patterns in the diagnostic
data that could lead to higher-level analysis, or even automated
fixes, that don't become apparent if the data is unstructured.  But
it's hard to know until you have lots of data.  I think just getting
the other things consistent is a good priority right now.
 -- Tim

>=20
> > > Yeah, I think it would be nice if all test frameworks/libraries for t=
he
> > > kernel output tests in the same language.
> > Agreed.
>=20
> $ git grep "TAP version"
> exec/binfmt_script:print("TAP version 1.3")
> kselftest.h:            printf("TAP version 13\n");
> kselftest/runner.sh:    echo "TAP version 13"
> resctrl/resctrl_tests.c:        printf("TAP version 13\n");
> size/get_size.c:        print("TAP version 13\n");
>=20
> Looks like there are 2 tests to convert to kselftest.h, and then we can
> just change the version to 14 in the header and the runner. ;)
>=20
> --
> Kees Cook