Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp350086ybt; Wed, 17 Jun 2020 02:34:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6/DNGMf8+u49oIZvuRdhpnGzOsfjoE5Fe2zfWM9UGHQcQodbCRbvH+UyT03kF8CtZ3bjb X-Received: by 2002:a05:6402:34e:: with SMTP id r14mr6434350edw.351.1592386493820; Wed, 17 Jun 2020 02:34:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592386493; cv=none; d=google.com; s=arc-20160816; b=NIz4YeC4LJe+2DwTvy0PbR5rmLpyoS5/GFhmcGwcLJwzkGiCuKGzg8XMgpWbFM2uQe Pw9PQ/8jGyW0C0XQWDWMvn95s1p3YcSm7o9Kv7349tcUekil8+vlJMSd1Ys7v9kS8Olc z3e0Fc76N/AYzCaUW+68t1TabDMVNRZp55gQv6pyXpmreW4ukDIaD3BZR6JYJnRYdwSn ZQLWYiUrPxJomwmAK0xphkDIwQ0ytsXD/bDFaS+Lb7eGmsJa7ySn5ASt1sxdLk461NPm dA/28Pi+PM++Zu6Y1PF3COJ7g4SjQMjfpWjOmo+ijGpsiHDKwzRWUvT8+074yXj3nRS1 ufXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:subject:autocrypt:from:references:cc:to; bh=eBz4j/zSI/XsqDRp/TAPf7zhl9YarKBt3BzTx9V7e2Q=; b=VRnfTfEPZn244z4yPItcSMEV8KybbWfwbcXlnGz+RWLeY/h+7nWlaKyCcp0R2zEKRn ydH5zp5emjAL9ckvbdyNM5slhG3wfx0JQWnYe3zGyhFykDQkdZwhOKcSoNAdDwLEjCpQ 3i5HnoKH721wB2PTjRj9mxjb+yoF0/GFCKCh4WEZZz0XevQuhsVwS6Y1+z3I3+2g1zQN kq9KZd+Faq6Sqb67VHUuq0E4urUuzsAJN4zoYC8B2nUuWPkVK5tyYc/CPrXUPyPLK/GJ 30iDVu0FYHZ/hdXq4lpug4isJjTJoz3sDb73il8za9SjRTQlURyW1GEp0gjSZTL+CDnL +HuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gt26si12624605ejb.750.2020.06.17.02.34.31; Wed, 17 Jun 2020 02:34:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725967AbgFQJca (ORCPT + 99 others); Wed, 17 Jun 2020 05:32:30 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:38579 "EHLO mail-lj1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725554AbgFQJc3 (ORCPT ); Wed, 17 Jun 2020 05:32:29 -0400 Received: by mail-lj1-f170.google.com with SMTP id 9so2021089ljv.5 for ; Wed, 17 Jun 2020 02:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:autocrypt:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eBz4j/zSI/XsqDRp/TAPf7zhl9YarKBt3BzTx9V7e2Q=; b=alwtJg1l51JEB5zRCmTFXnYn0WtD7MqMOJqkzT1Od2VHfDUY9rHUsrrW8+WOonNobT JnPgjISAHpg4L9gydvTJomX7MVK0k7UvOnFc9McyP0Nia5MzJ7df3t6PPJ5+QwLawD+k H7qUAb34NIRIIj6bnDvRLjb7SzdyFXelyXcYcl4KI3IGs3fjWnLR+jmixA+IU147nsvf SHuBxM7qKaJxjep3egvLHTh5gZ06EWwEdyTgWTKOeGRZATYfJeppm7BlutNdFCMZNLg1 1IWxD0/+LTJqr/1dlXYV+rwYRLlHajUVo9F92TyEt3qgN+Zd0RO5VlCAdtUtNme+/d1L pctQ== X-Gm-Message-State: AOAM531rGhwmsruZAug9X2KLXndfRFz1LalmFqrWZfZ537ZwqD8pMgvd 4hwTUto6fatu/krNpRLv2Z3eC0ut2Rk= X-Received: by 2002:a2e:b0d0:: with SMTP id g16mr3741722ljl.130.1592386344927; Wed, 17 Jun 2020 02:32:24 -0700 (PDT) Received: from [192.168.1.8] ([213.87.137.195]) by smtp.gmail.com with ESMTPSA id z15sm4899858ljo.102.2020.06.17.02.32.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2020 02:32:24 -0700 (PDT) To: "Gustavo A. R. Silva" , Kees Cook Cc: Julia Lawall , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org References: <20200615102045.4558-1-efremov@linux.com> <202006151123.3C2CB7782@keescook> <4dd9c371-0c37-a4bb-e957-3848cb1a13ff@embeddedor.com> From: Denis Efremov Autocrypt: addr=efremov@linux.com; keydata= mQINBFsJUXwBEADDnzbOGE/X5ZdHqpK/kNmR7AY39b/rR+2Wm/VbQHV+jpGk8ZL07iOWnVe1 ZInSp3Ze+scB4ZK+y48z0YDvKUU3L85Nb31UASB2bgWIV+8tmW4kV8a2PosqIc4wp4/Qa2A/ Ip6q+bWurxOOjyJkfzt51p6Th4FTUsuoxINKRMjHrs/0y5oEc7Wt/1qk2ljmnSocg3fMxo8+ y6IxmXt5tYvt+FfBqx/1XwXuOSd0WOku+/jscYmBPwyrLdk/pMSnnld6a2Fp1zxWIKz+4VJm QEIlCTe5SO3h5sozpXeWS916VwwCuf8oov6706yC4MlmAqsQpBdoihQEA7zgh+pk10sCvviX FYM4gIcoMkKRex/NSqmeh3VmvQunEv6P+hNMKnIlZ2eJGQpz/ezwqNtV/przO95FSMOQxvQY 11TbyNxudW4FBx6K3fzKjw5dY2PrAUGfHbpI3wtVUNxSjcE6iaJHWUA+8R6FLnTXyEObRzTS fAjfiqcta+iLPdGGkYtmW1muy/v0juldH9uLfD9OfYODsWia2Ve79RB9cHSgRv4nZcGhQmP2 wFpLqskh+qlibhAAqT3RQLRsGabiTjzUkdzO1gaNlwufwqMXjZNkLYu1KpTNUegx3MNEi2p9 CmmDxWMBSMFofgrcy8PJ0jUnn9vWmtn3gz10FgTgqC7B3UvARQARAQABtCFEZW5pcyBFZnJl bW92IDxlZnJlbW92QGxpbnV4LmNvbT6JAlcEEwEIAEECGwMFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4ACGQEWIQR2VAM2ApQN8ZIP5AO1IpWwM1AwHwUCXsQtuwUJB31DPwAKCRC1IpWwM1Aw H3dQD/9E/hFd2yPwWA5cJ5jmBeQt4lBi5wUXd2+9Y0mBIn40F17Xrjebo+D8E5y6S/wqfImW nSDYaMfIIljdjmUUanR9R7Cxd/Z548Qaa4F1AtB4XN3W1L49q21h942iu0yxSLZtq9ayeja6 flCB7a+gKjHMWFDB4nRi4gEJvZN897wdJp2tAtUfErXvvxR2/ymKsIf5L0FZBnIaGpqRbfgG Slu2RSpCkvxqlLaYGeYwGODs0QR7X2i70QGeEzznN1w1MGKLOFYw6lLeO8WPi05fHzpm5pK6 mTKkpZ53YsRfWL/HY3kLZPWm1cfAxa/rKvlhom+2V8cO4UoLYOzZLNW9HCFnNxo7zHoJ1shR gYcCq8XgiJBF6jfM2RZYkOAJd6E3mVUxctosNq6av3NOdsp1Au0CYdQ6Whi13azZ81pDlJQu Hdb0ZpDzysJKhORsf0Hr0PSlYKOdHuhl8fXKYOGQxpYrWpOnjrlEORl7NHILknXDfd8mccnf 4boKIZP7FbqSLw1RSaeoCnqH4/b+ntsIGvY3oJjzbQVq7iEpIhIoQLxeklFl1xvJAOuSQwII I9S0MsOm1uoT/mwq+wCYux4wQhALxSote/EcoUxK7DIW9ra4fCCo0bzaX7XJ+dJXBWb0Ixxm yLl39M+7gnhvZyU+wkTYERp1qBe9ngjd0QTZNVi7MbkCDQRbCVF8ARAA3ITFo8OvvzQJT2cY nPR718Npm+UL6uckm0Jr0IAFdstRZ3ZLW/R9e24nfF3A8Qga3VxJdhdEOzZKBbl1nadZ9kKU nq87te0eBJu+EbcuMv6+njT4CBdwCzJnBZ7ApFpvM8CxIUyFAvaz4EZZxkfEpxaPAivR1Sa2 2x7OMWH/78laB6KsPgwxV7fir45VjQEyJZ5ac5ydG9xndFmb76upD7HhV7fnygwf/uIPOzNZ YVElGVnqTBqisFRWg9w3Bqvqb/W6prJsoh7F0/THzCzp6PwbAnXDedN388RIuHtXJ+wTsPA0 oL0H4jQ+4XuAWvghD/+RXJI5wcsAHx7QkDcbTddrhhGdGcd06qbXe2hNVgdCtaoAgpCEetW8 /a8H+lEBBD4/iD2La39sfE+dt100cKgUP9MukDvOF2fT6GimdQ8TeEd1+RjYyG9SEJpVIxj6 H3CyGjFwtIwodfediU/ygmYfKXJIDmVpVQi598apSoWYT/ltv+NXTALjyNIVvh5cLRz8YxoF sFI2VpZ5PMrr1qo+DB1AbH00b0l2W7HGetSH8gcgpc7q3kCObmDSa3aTGTkawNHzbceEJrL6 mRD6GbjU4GPD06/dTRIhQatKgE4ekv5wnxBK6v9CVKViqpn7vIxiTI9/VtTKndzdnKE6C72+ jTwSYVa1vMxJABtOSg8AEQEAAYkCPAQYAQgAJgIbDBYhBHZUAzYClA3xkg/kA7UilbAzUDAf BQJexC4MBQkHfUOQAAoJELUilbAzUDAfPYoQAJdBGd9WZIid10FCoI30QXA82SHmxWe0Xy7h r4bbZobDPc7GbTHeDIYmUF24jI15NZ/Xy9ADAL0TpEg3fNVad2eslhCwiQViWfKOGOLLMe7v zod9dwxYdGXnNRlW+YOCdFNVPMvPDr08zgzXaZ2+QJjp44HSyzxgONmHAroFcqCFUlfAqUDO T30gV5bQ8BHqvfWyEhJT+CS3JJyP8BmmSgPa0Adlp6Do+pRsOO1YNNO78SYABhMi3fEa7X37 WxL31TrNCPnIauTgZtf/KCFQJpKaakC3ffEkPhyTjEl7oOE9xccNjccZraadi+2uHV0ULA1m ycHhb817A03n1I00QwLf2wOkckdqTqRbFFI/ik69hF9hemK/BmAHpShI+z1JsYT9cSs8D7wb aF/jQVy4URensgAPkgXsRiboqOj/rTz9F5mpd/gPU/IOUPFEMoo4TInt/+dEVECHioU3RRrW EahrGMfRngbdp/mKs9aBR56ECMfFFUPyI3VJsNbgpcIJjV/0N+JdJKQpJ/4uQ2zNm0wH/RU8 CRJvEwtKemX6fp/zLI36Gvz8zJIjSBIEqCb7vdgvWarksrhmi6/Jay5zRZ03+k6YwiqgX8t7 ANwvYa1h1dQ36OiTqm1cIxRCGl4wrypOVGx3OjCar7sBLD+NkwO4RaqFvdv0xuuy4x01VnOF Subject: Re: [Cocci] [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks Message-ID: <32248ed1-69fe-a1b1-89da-44cd4ae54804@linux.com> Date: Wed, 17 Jun 2020 12:32:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <4dd9c371-0c37-a4bb-e957-3848cb1a13ff@embeddedor.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > > > Awesome! I'll take a look into this. :) > It would be helpful to get a feedback from you after. What kind of warnings are helpful and what are not? "duplicate calls" and "opencoded expression after array_size()" look doubtful to me. I think that maintainers will not like these patches. Thanks, Denis