Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp409066ybt; Wed, 17 Jun 2020 04:20:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy678dHS5q275oFbS3NvtbUSk500D+h/uQRSghpkR4Xo98HV8IoTyQf4zbYlq3OGUIjMMVt X-Received: by 2002:a17:906:3e0c:: with SMTP id k12mr6835402eji.441.1592392818474; Wed, 17 Jun 2020 04:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592392818; cv=none; d=google.com; s=arc-20160816; b=Lx8Hzsvl9s9Doajd2E9WGMD2NEBzoVPMdydIl3vEMuKoGL/4I10Fdm+sr4EdT6qdsp jpQwQbJztBVBbc1VHkzq90lh6qAG63EMbnw02Cmkf864ICquYV5ONZJfyqYqHnrJIXOv XDfUzVI/rbuCaT+mCc9biT2IGp8BwmSfh14LUEvPRK3VKoilhh7/oHfnXqpInu3Dkg2v bTZBan/E/GiPhkvuE0obAHGKDsKHGHLGbdherJ+uTn/ezhiUs3ZfqcDwTP9e0DJIcdWr ep7JY3jq64AjNce+8JEfuEtpCrHNn6q8IH9P/hlLeQjmmAnqU1ma5Nm+14y89qNo8VKc 7VyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YPfSKQLS4lhQ31FTiIVrSIjj6rqrif/wRPJMTAwT1CA=; b=C2dmR+ZTv2ZMtEPsdG/6qP4jIVTL0fZ5mmnxIf/AlwrX+lel0UtHy/wU0ejbkrNs9p BOQ/ShoOVnJ35BUMoGdaMxAgMjoTIUZydi6j/noRI99VArv3NfuE5F6licojHPgcrest WFNsD4Fzbi85e0cwAtubkFBif0+n2O8JBV+SXrJW6JieqmaQHt6u4c33zAC3yRkcvHN4 5AiGpyDgwU3tnEUrD9qumIRdFTypKBVf93QtCjHtbHPQeALCSLkbEqtZY5s8hzBxtmoi E7eYRwEFnQbBGoHFoEnIbLWLmDGwzAGkARzVqVSTXBJcci0TZ0/qTxrUuTTxhRUw6rAq 1Ntg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ds10si15739023ejc.183.2020.06.17.04.19.55; Wed, 17 Jun 2020 04:20:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727001AbgFQLRg (ORCPT + 99 others); Wed, 17 Jun 2020 07:17:36 -0400 Received: from elvis.franken.de ([193.175.24.41]:35899 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726565AbgFQLRb (ORCPT ); Wed, 17 Jun 2020 07:17:31 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jlW4P-0006Ho-04; Wed, 17 Jun 2020 13:17:29 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 02B47C06C3; Wed, 17 Jun 2020 13:14:55 +0200 (CEST) Date: Wed, 17 Jun 2020 13:14:55 +0200 From: Thomas Bogendoerfer To: =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas Cc: f.fainelli@gmail.com, jonas.gorski@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-mips@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: BCM63xx: add endif comments Message-ID: <20200617111455.GE9940@alpha.franken.de> References: <20200608101828.3383942-1-noltari@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200608101828.3383942-1-noltari@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 08, 2020 at 12:18:28PM +0200, ?lvaro Fern?ndez Rojas wrote: > There are plenty of ifdefs in board_bcm963xx.c without endif comments. > Let's make the code easier to follow by adding proper comments. > > Signed-off-by: ?lvaro Fern?ndez Rojas > --- > arch/mips/bcm63xx/boards/board_bcm963xx.c | 33 +++++++++++------------ > 1 file changed, 15 insertions(+), 18 deletions(-) applied to mips-next. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]