Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp513040ybt; Wed, 17 Jun 2020 07:03:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2HqsvjeMFO4jdcKVWNGmCe3BEKEut/pfMFIaQGegDiLJHzRrFoi475pemV1Wgp3ZsP51V X-Received: by 2002:a05:6402:1481:: with SMTP id e1mr7427750edv.113.1592402630311; Wed, 17 Jun 2020 07:03:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592402630; cv=none; d=google.com; s=arc-20160816; b=D/BnErS40z4s7lundc/Zct13rC2VtGVhq8rfvsA+Cpb6bSFV85s4X5nHCsN3QUTkIK ewB7PAmESr8bIbFgfhC7UzXOhi+5wUwC+Q1P1oOKnUMvE++fafInY15YOhWkxlljUHqO 2ZMr5xZkHO2QvPoScrwXMKn52+q/aRZtStQy+4EIlULNP7XzNdVeuZI49yF6dAV/x1aX KMisAMBfvzRU3tcb6w7Oj7AU/o+676vAMF2sbvY28FjHexrzo9PySy8eF8wpwEGZP18s g0pdrHb34kC8wPMKl1InTdRq2A/o8ZlxnbdWvDqKj3fo2Y2quKJkrzA1poeG/2ZJilRu Gsrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=eorYSI4kx7e22DHninlhRFcMQd/uFdD7qtd2CZBW3V8=; b=TsCGz/iRJ2MoaWOdZ3EEUzB8+PWrPGk6yMeXYGrf+GUm7R3QxSz2xCONCrw4eM/m84 s55Zjdu9+XyeZY6RR2WTssV5/ikippYK3S5jiCHDrpum5YKb1qjNIaSvjLwJgtjVqL2Z /uTe23gyazEuojlH27x3xqArBjCzLvvJjxWcx3SHZeQqY1K9SBIfBHPFDaAEaQPtO7gz HaCfAgTBsvenRU2OsvkHTnl/JyFVqhKyrP0lUqbTAeGjHVG7DMbSH/98jRkkqUAbLIOT lBzioBZeHoguPsQePTLcZjiu0i+05DmD9WxnYbznjOh0iS0DPN3QSLJRQjnmB1urEt7L j2iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HcEerde5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gg10si13672203ejb.413.2020.06.17.07.03.27; Wed, 17 Jun 2020 07:03:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HcEerde5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbgFQN6s (ORCPT + 99 others); Wed, 17 Jun 2020 09:58:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726496AbgFQN6r (ORCPT ); Wed, 17 Jun 2020 09:58:47 -0400 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89305C06174E; Wed, 17 Jun 2020 06:58:47 -0700 (PDT) Received: by mail-oi1-x241.google.com with SMTP id i74so1864173oib.0; Wed, 17 Jun 2020 06:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eorYSI4kx7e22DHninlhRFcMQd/uFdD7qtd2CZBW3V8=; b=HcEerde5q4FsPwHzHd40ZoWl8VfokXhhEa3ioIzfzPYVCXdK7stl038k3iAwVxirkW HoL4+REwXuV7Ijb4LiLKpixecTvO1DlW/4JX7bqQykyH2EvcH1ubRRF9gGu8HaiXa26F +hPaBbGl9T3tmwYYe0kIg9jggMazzfJDFjayCGL3o95lyFL5lLq8JLbH43qKQTw3LdvE LoRScNGy4XBOMrSuBoJ5W4fB65TDFU+gon3hGmnhsVLWUibIjWm1xvPkdSClLhqWqgJT JhyM46YZmcueaDu4a6v1FE6qpsjbpm0Zrd/hriPUOws07+snWV7/F+YX7sFkKxPGYmyf B1SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eorYSI4kx7e22DHninlhRFcMQd/uFdD7qtd2CZBW3V8=; b=oxT1YUD7u37KzFyjhlj/3FjnXnotm6bncMPOXEvLejhq0lM5aii7R41d4VuZx19bcM TN3kecn4yKMnr1hwPu3j5AguXYd0bsg+Cd1xxeE35dqVYoBA8qKptl1h1349u84fw82p WkR2DpscwdVgilZSpeN71prdbXl3GUw+BbV/zjl38HADMuYZDeFgVDfKDMZ0X+rnHFrR ZbZ7tlzd4naNtVz+GyHLeHmreqdkTiI+g25fhMGRruOhokrDtMeRv+mKU+SKJgUo8kvH WZCcBTqNWT43CwpWlm2PSXIPBO9ydivCjsJA7EMiv9BB6BXgz8J3o6sKLksd4lpHF078 TV7g== X-Gm-Message-State: AOAM531Z6lZMy9HIStq/ZD6dJy3mPfdu//56bmKfxBQ7eK5cCPhqfYMG Q1Wbazdt6BPh5XtZqoT+LDzWRtiL9+/+1FDdsHPXAMlF X-Received: by 2002:aca:55c1:: with SMTP id j184mr7083073oib.160.1592402326786; Wed, 17 Jun 2020 06:58:46 -0700 (PDT) MIME-Version: 1.0 References: <20200617124028.14130-1-trix@redhat.com> In-Reply-To: <20200617124028.14130-1-trix@redhat.com> From: Stephen Smalley Date: Wed, 17 Jun 2020 09:58:35 -0400 Message-ID: Subject: Re: [PATCH] selinux: fix undefined return of cond_evaluate_expr To: trix@redhat.com Cc: Paul Moore , Eric Paris , Ondrej Mosnacek , weiyongjun1@huawei.com, SElinux list , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 8:40 AM wrote: > > From: Tom Rix > > clang static analysis reports an undefined return > > security/selinux/ss/conditional.c:79:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] > return s[0]; > ^~~~~~~~~~~ > > static int cond_evaluate_expr( ... > { > u32 i; > int s[COND_EXPR_MAXDEPTH]; > > for (i = 0; i < expr->len; i++) > ... > > return s[0]; > > When expr->len is 0, the loop which sets s[0] never runs. > > So return -1 if the loop never runs. > > Signed-off-by: Tom Rix Acked-by: Stephen Smalley clang didn't complain about the similar pattern in security/selinux/ss/services.c:constraint_expr_eval()?