Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp513391ybt; Wed, 17 Jun 2020 07:04:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0N33VEwJ3IsYZuSudCm5aE8/h2ToIj9ifKJEhodSm8yODdHylxOuv31UPEFV8OWG2EGP1 X-Received: by 2002:a17:906:a385:: with SMTP id k5mr8027525ejz.44.1592402658716; Wed, 17 Jun 2020 07:04:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592402658; cv=none; d=google.com; s=arc-20160816; b=gmAjpwfzomToA5LPxqEBn9vUz0rzXuqn+PQc09cIBvwTZqeR7i8gvirva8ilY++HUq V42scM7LuDHaXcv3Q6DyXXoEen1fiMxuefTmbl8xjGYs5IARb+qVF3dKsEMgQ4tVu+FL H9ri0s6mQcw4G++NjYoh02ejSxCAr08ErF6SLaSXsGCe6op6FarorTb1sWPYJBQBhpGo fCU9G1TxTAkhNJSb9uep5x25HhT4b1fZXNAtpP3ToAchfkztCkdyfQh0Z7fw5vfp2zxm DRNbE+O2I/htQT3Q0knII1i7PEgXiHIpXiNbMFHS36XMexrAs3g3WE1j+VxU/QZ6RN6F bqvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=rQ698xXvhqeaMtN5Vsq4Wnsxj/oF7odcYpyLbDdI6aI=; b=NFK7WRofugFgkYxtvt+swOsZHkmgpsb5d1WbxsuSXxkWq7Nf0JleVHt4Q75RcabR5p 9UVw5hOHemCrqYO9TVqPCpM/qIJUhFuKVXfmDvUDrs++NFSewH/h7Xn7Eq2UhH6hHkEL R7iPkj9jbTcoNJuykcmRzGeUVYm1xZNe7dgAyabwAJyM+DZLuBamBv+Jj3clXt304bHn ONExrMjrD86v1e73twrVQEt2xdbsRsEciIRF8o5ebbH7/XOgQBX7xpCO55+/wLDtI8Ov Eq01i6gOAzASIV3+1h9+juIq5UZAwBXh3HrTPyGD675YQa6HQbR1ouaBUDHHg0l6qltu 5cCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KBjmziXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si36014edv.489.2020.06.17.07.03.53; Wed, 17 Jun 2020 07:04:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KBjmziXM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726864AbgFQOBb (ORCPT + 99 others); Wed, 17 Jun 2020 10:01:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:50768 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbgFQOBb (ORCPT ); Wed, 17 Jun 2020 10:01:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C031220776; Wed, 17 Jun 2020 14:01:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592402491; bh=hUnhfUy8ysZi64MArixITUGcfaJ7UN86JMKaLY6gF8o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KBjmziXM0RwF2Wh2pT1HiesB3wYDz+I+AmA15dofUucLUfWp0L5baq6hsyufDvDlf wSye0eINt1vlm1AJjwZsiogcpo5wnrCWidFhYpkl4v6jljvwjAUOO1932SYSh8H4ck idVZC7pEb9tONm4p2szkvINVGNCEJK1I6D47A7iM= Date: Wed, 17 Jun 2020 16:01:23 +0200 From: Greg KH To: jim.cromie@gmail.com Cc: Petr Mladek , Jason Baron , LKML , akpm@linuxfoundation.org, Rasmus Villemoes Subject: Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar Message-ID: <20200617140123.GA2588750@kroah.com> References: <20200613155738.2249399-1-jim.cromie@gmail.com> <20200613155738.2249399-20-jim.cromie@gmail.com> <20200616115727.GN31238@alley> <20200617121156.GV31238@alley> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 07:32:44AM -0600, jim.cromie@gmail.com wrote: > hi Petr > > > You made to do some research and I was wrong. For example, getopt() > > operates with options and their arguments. So, 'keyword' and 'arg' names > > look good after all. > > > > Well, I still think that only one syntax should be supported. And it > > is better to distinguish keywords and arguments, so I prefer keyword=arg. > > > > hehe, Im gonna cite some RFC wisdom to convince you ;-) > > Be strict in what you emit, and permissive in what you accept. > > I see no potential for real ambiguity that would override that bias. No, the kernel should be strict in what it accepts, otherwise it is a huge maintance burden for no good reason at all. Only one syntax is a wise idea, stick with that please. thanks, greg k-h