Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp539882ybt; Wed, 17 Jun 2020 07:38:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJzl3Kwp5HuLisrPJ52bUMYmcC9tfHbC1VjIQ4mCAFbObksxnoOg4eGxVa34pgn1lrQHxF X-Received: by 2002:a17:906:4756:: with SMTP id j22mr8184639ejs.490.1592404737681; Wed, 17 Jun 2020 07:38:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592404737; cv=none; d=google.com; s=arc-20160816; b=f4x42j4mJkqDxISJvHWP2qUV7XfkHG3c9uir3aGt9Ta5OiIwmGlp5BRcjRZKur0I5K qza3M8rGRbHz2Omrt59Fj0nvUnUYlzGGics7SM5Ls4Y008u8CkgkLgBKC/HUlPF0VFNw hNgfQp6xLlJ17MJjWBxsxeJVXZSKrvnw722/Yt0FnAZd5QSogm24OYBGXQrbTtL14I5V 3LzlSa4aJk3JXJ9RnrCY/8a2vhNAk3Fs9hQIBYN1vVW7kMIO43C+dsQ9U1SwKg6ygXqe XaQ7Ejp+CUNBe1FUmh1XddNyJAdk6I0mC+iMtvfX6BbD+d1/6rypUfoYh/xyZRMGSew+ eL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=8d9VHJ/RvPgFeb2PBCwG8pI95l0nST6DCA4NM5dobCU=; b=NJV7+Cr6TT1fTSgv5N+GpfUAh5TAib5CaZzWBFkYVpZbwF5mrel0p18JnJEvDRCf7N G33qTlmeD58s860G/TPADjGIGes83fS1rJdl0DnwctW+owv1jLfXNxOVDNoqcvJGiL0F fORUkHVttTc3u38jNfcDpQtL/amTmbF3OIxCNvY22rUITKhghlDl/qxiSi2qvXxwpjSA UcJ+oth2hcWAnIPlEuQPujMW74+CiVj1gHkfXTtH4tBoRxoLbUhssKROA1LJhRlf0d1n 9b7ZdwOAPMnPHmhZ7bMS0kglXkQwAkF2mp6OR2qOnbqIv8K+gZc3Ge5rsN2wM7sZxIPd khug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p26si80120edx.191.2020.06.17.07.38.35; Wed, 17 Jun 2020 07:38:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726925AbgFQOgw (ORCPT + 99 others); Wed, 17 Jun 2020 10:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726328AbgFQOgu (ORCPT ); Wed, 17 Jun 2020 10:36:50 -0400 Received: from michel.telenet-ops.be (michel.telenet-ops.be [IPv6:2a02:1800:110:4::f00:18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39A96C06174E for ; Wed, 17 Jun 2020 07:36:50 -0700 (PDT) Received: from ramsan ([IPv6:2a02:1810:ac12:ed20:b57b:2191:a081:571d]) by michel.telenet-ops.be with bizsmtp id sEcm2200Q1Jlgh206Ecml1; Wed, 17 Jun 2020 16:36:47 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1jlZBG-0007pj-Li; Wed, 17 Jun 2020 16:36:46 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1jlZBG-0004mL-K4; Wed, 17 Jun 2020 16:36:46 +0200 From: Geert Uytterhoeven To: Yoshinori Sato , Rich Felker Cc: Andrew Morton , Mike Rapoport , Dmitry Safonov <0x7f454c46@gmail.com>, Guenter Roeck , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 1/9] sh: fault: Fix duplicate printing of "PC:" Date: Wed, 17 Jun 2020 16:36:31 +0200 Message-Id: <20200617143639.18315-2-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200617143639.18315-1-geert+renesas@glider.be> References: <20200617143639.18315-1-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Somewhere along the patch handling path, both the old "printk(KERN_ALERT ...)" and the new "pr_alert(...)" were retained, leading to the duplicate printing of "PC:". Drop the old one. Fixes: eaabf98b0932a540 ("sh: fault: modernize printing of kernel messages") Signed-off-by: Geert Uytterhoeven --- v2: - New. --- arch/sh/mm/fault.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/sh/mm/fault.c b/arch/sh/mm/fault.c index fbe1f2fe9a8c8f55..acd1c75994983825 100644 --- a/arch/sh/mm/fault.c +++ b/arch/sh/mm/fault.c @@ -208,7 +208,6 @@ show_fault_oops(struct pt_regs *regs, unsigned long address) if (!oops_may_print()) return; - printk(KERN_ALERT "PC:"); pr_alert("BUG: unable to handle kernel %s at %08lx\n", address < PAGE_SIZE ? "NULL pointer dereference" : "paging request", -- 2.17.1