Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp539892ybt; Wed, 17 Jun 2020 07:38:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwxqHaBPhrjVjRc0+Ia7MI9X1K8zkO5x/ysdSLJnFJqABt3D0pF6x7CBJts+d3dwgvV5Pix X-Received: by 2002:a50:951d:: with SMTP id u29mr7875719eda.333.1592404738303; Wed, 17 Jun 2020 07:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592404738; cv=none; d=google.com; s=arc-20160816; b=jUeFyu/J+HUT/qmPFhdM+s5afdOqT7IhelcBhrWVvT/wxSkTK5xHDZIXombZElX44p sVgK1QtI/bDc0Dh8+1Pxd/RG1u9Kexr9C3kmLMu9Xi3MvZzgmdCW8Cpx0ErbrcCur+kI 00H0xMFWbSkj/ZtIDVmLkh04Vel7pg5id+YL+rfAKVtNY4Lm5YDuoNG8tG3HdOmq1DLo PFNGQQh0F6C/TKMyhtWjDLCpr97bt+W4xIJeftyrRuF2oaRXZ7a8GRehiN/x1CcsqlyZ vNhR5N/ZEp/Q2jFUpKROwxtCyNkyvmwtO4xSNA7j7Pb5BbmcIT7UJymvv/AuTOiDfnsq JHrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=oSka2DVZPiels4d0qTcCdJ84R6TEOVEFIAry/KfOxhA=; b=CxB7wwJtXUM/Tu/cKMx9A1kh30v6+0aS2SUpTuWSG6dFO3QVVWM5zJY0X8Ftr/+xis VSSiIIyFTBmRYDCkW0GEmgjG2ur9RPJI38rnoqcfC80pLkoZC6f0hPbWC6cmlv+NHhWE Ayt6X3D8rQAkBo/veDn1i/KHrXkPzcjekXzTVXsSxHP55HYfuhnnE+q3/TDTc6u1jGeA D7RqHyBoZHY012+cI3MZirbj74bTTcEuxmhB3vU7PfW0tG1Eh853WporXUXTOVIeoBQS BsqTftYRHUpkCAWRDy30lniERUcNKixkDjvk3sAD/FFGojBtRc05roJZS0N50zQiU7vq oPIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v1si18165ejd.509.2020.06.17.07.38.35; Wed, 17 Jun 2020 07:38:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbgFQOgv (ORCPT + 99 others); Wed, 17 Jun 2020 10:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbgFQOgu (ORCPT ); Wed, 17 Jun 2020 10:36:50 -0400 Received: from baptiste.telenet-ops.be (baptiste.telenet-ops.be [IPv6:2a02:1800:120:4::f00:13]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4EDCAC0613EE for ; Wed, 17 Jun 2020 07:36:50 -0700 (PDT) Received: from ramsan ([IPv6:2a02:1810:ac12:ed20:b57b:2191:a081:571d]) by baptiste.telenet-ops.be with bizsmtp id sEcm2200s1Jlgh201Ecm8M; Wed, 17 Jun 2020 16:36:47 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan with esmtp (Exim 4.90_1) (envelope-from ) id 1jlZBG-0007pn-OO; Wed, 17 Jun 2020 16:36:46 +0200 Received: from geert by rox.of.borg with local (Exim 4.90_1) (envelope-from ) id 1jlZBG-0004mR-N0; Wed, 17 Jun 2020 16:36:46 +0200 From: Geert Uytterhoeven To: Yoshinori Sato , Rich Felker Cc: Andrew Morton , Mike Rapoport , Dmitry Safonov <0x7f454c46@gmail.com>, Guenter Roeck , linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven Subject: [PATCH v2 3/9] Revert "sh: remove needless printk()" Date: Wed, 17 Jun 2020 16:36:33 +0200 Message-Id: <20200617143639.18315-4-geert+renesas@glider.be> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200617143639.18315-1-geert+renesas@glider.be> References: <20200617143639.18315-1-geert+renesas@glider.be> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 8b92f34877225c8eb85e3ab7f1177fc248ba26d0. "data" became the log level in commit 539e786cc37ee5cb ("sh: add loglvl to show_trace()"), so we do need to keep the printk() before the continuation in print_trace_address(). Signed-off-by: Geert Uytterhoeven --- v2: - New. --- arch/sh/kernel/dumpstack.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/sh/kernel/dumpstack.c b/arch/sh/kernel/dumpstack.c index ad548fc976350c50..cc8063a01284bf64 100644 --- a/arch/sh/kernel/dumpstack.c +++ b/arch/sh/kernel/dumpstack.c @@ -118,6 +118,7 @@ static int print_trace_stack(void *data, char *name) */ static void print_trace_address(void *data, unsigned long addr, int reliable) { + printk("%s", (char *)data); printk_address(addr, reliable); } -- 2.17.1