Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred
 probe
To:     Krzysztof Kozlowski <krzk@kernel.org>,
        Rob Herring <robh@kernel.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
References: <20200527200544.7849-1-krzk@kernel.org>
 <20200527204334.GA15485@kevin> <20200617141547.GA30516@kozik-lap>
From:   Steven Price <steven.price@arm.com>
Message-ID: <b41bfead-7b73-be78-c63f-79a0a7e23b2a@arm.com>
Date:   Wed, 17 Jun 2020 15:35:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <20200617141547.GA30516@kozik-lap>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 17/06/2020 15:15, Krzysztof Kozlowski wrote:
> On Wed, May 27, 2020 at 04:43:34PM -0400, Alyssa Rosenzweig wrote:
>> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
>>
>> On Wed, May 27, 2020 at 10:05:44PM +0200, Krzysztof Kozlowski wrote:
>>> There is no point to print deferred probe (and its failures to get
>>> resources) as an error.  Also there is no need to print regulator errors
>>> twice.
>>>
>>> In case of multiple probe tries this would pollute the dmesg.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>>> Reviewed-by: Steven Price <steven.price@arm.com>
>>>
>>> ---
>>>
>>> Changes since v2:
>>> 1. Rebase
>>> 2. Add Steven's review
>>>
>>> Changes since v1:
>>> 1. Remove second error message from calling panfrost_regulator_init()
>>> ---
>>>   drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++----
>>>   1 file changed, 4 insertions(+), 4 deletions(-)
>>>
> 
> Hi Rob, Tomeu and Steven,
> 
> You're listed as maintainers for panfrost. Is anyone going to pick this
> up?

I'm only a reviewer so I've been leaving it for Rob or Tomeu, but I can 
pick it up if Rob/Tomeu are happy for me to do that.

> Maybe I sent it to wrong mailing list or forgot about anything?

No, there's actually a few Panfrost commits waiting, it was on my todo 
list to ask if Rob/Tomeu needed some help with merging patches.

Steve