Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp576407ybt; Wed, 17 Jun 2020 08:30:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzicLR7ClsZ6pQe4zTAbhgKPpVHrjejXdC+j1zeH7CKF98b/2Ys7lb80yekN+eyF+oH68fN X-Received: by 2002:a05:6402:17ce:: with SMTP id s14mr7695393edy.53.1592407820763; Wed, 17 Jun 2020 08:30:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592407820; cv=none; d=google.com; s=arc-20160816; b=aP5Dw2suTzaVo5VrjgX9PICcC//hQQV+29WOjUE36bQctlVUiaC3xjn/MgETWLKqep 3l/gGHdbgyTN/KPA5MltZgDY874ofXoC3eaVA/YtN9CVyYu4YG2sW8a9ZoswxCXMln8a P8l+8qaWYuX7YSDkjI4s6YOWJSonT9YLfbHobB5hhdwrH7kcAU5jzd3je4whDH18tAgd XFfXTb9gxF1dSapUgTom0SNGZW7RpAhGU9UgRLzXbgePm4bfsc/SawZMJk2OUtnPHqGb y9zfg9kLgd8YRp9VHusd/UZkKtktX6e6ghZBMq0LRIxdwQg0eYeV8DrHdOZbgl7YeXQl C99g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=OFZ3Buuy0iNY7W8vFFy+8OImisbIanFPBpkxtqxcDVk=; b=JKZgZioaAIwX/MpsMBTg+1R7VNl23mFvURtH8tzHRLu97R4MKipYvlEXrypdwmv6k0 vPRBh4uD8vYaOmjvg3pJls303xJ0cydrdVFME1eVLfNwEF1AdNp5y43yE9S6nHOwx+9S IC1at7XcaBiRY5qp6te3EPIgjoNLdw0QoRrEQRJAYF3IcrMQjTe7nWnGqQuS7syDmei+ PDjPYiXDFjSMb/nt/X0fr3kjvHk9L1UTeOfer3CzzMV60JH3ycazyQMCk1C5KSH6Xaia omyWnP4gpGU7Y5Dkv5atMClboH5+viFOIAt5fFEwhk8tC8/6DY2oJpJ6WymbEyYdgJiF r/wA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si180954edt.28.2020.06.17.08.29.57; Wed, 17 Jun 2020 08:30:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=aculab.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbgFQPZq convert rfc822-to-8bit (ORCPT + 99 others); Wed, 17 Jun 2020 11:25:46 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:56302 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726960AbgFQPZq (ORCPT ); Wed, 17 Jun 2020 11:25:46 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-25-eup2Bh-aNyW7TJye3x3ncg-1; Wed, 17 Jun 2020 16:25:42 +0100 X-MC-Unique: eup2Bh-aNyW7TJye3x3ncg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 17 Jun 2020 16:25:41 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Wed, 17 Jun 2020 16:25:41 +0100 From: David Laight To: 'Kees Cook' , "linux-kernel@vger.kernel.org" CC: Sargun Dhillon , Christian Brauner , "David S. Miller" , "Christoph Hellwig" , Tycho Andersen , Jakub Kicinski , Alexander Viro , Aleksa Sarai , Matt Denton , Jann Horn , Chris Palmer , Robert Sesek , Giuseppe Scrivano , "Greg Kroah-Hartman" , Andy Lutomirski , Will Drewry , Shuah Khan , "netdev@vger.kernel.org" , "containers@lists.linux-foundation.org" , "linux-api@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" Subject: RE: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received() Thread-Topic: [PATCH v4 02/11] fs: Move __scm_install_fd() to __fd_install_received() Thread-Index: AQHWQ43M27/IXY9H5E6A6toMY/N8aajc78uQ Date: Wed, 17 Jun 2020 15:25:41 +0000 Message-ID: References: <20200616032524.460144-1-keescook@chromium.org> <20200616032524.460144-3-keescook@chromium.org> In-Reply-To: <20200616032524.460144-3-keescook@chromium.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook > Sent: 16 June 2020 04:25 > In preparation for users of the "install a received file" logic outside > of net/ (pidfd and seccomp), relocate and rename __scm_install_fd() from > net/core/scm.c to __fd_install_received() in fs/file.c, and provide a > wrapper named fd_install_received_user(), as future patches will change > the interface to __fd_install_received(). Any reason for the leading __ ?? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)