Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200616180123.GL13515@zn.tnic> <1D569B6B-B8C3-497E-8A74-2E1A3D46299E@amacapital.net>
 <20200617083314.GC10118@zn.tnic>
In-Reply-To: <20200617083314.GC10118@zn.tnic>
From:   Andy Lutomirski <luto@amacapital.net>
Date:   Wed, 17 Jun 2020 08:30:42 -0700
Message-ID: <CALCETrXQB2ZuDno1E70spamt30ix3kf8gShdNCM7Ua3xqWbZdQ@mail.gmail.com>
Subject: Re: [PATCH] x86/fpu: Reset MXCSR to default in kernel_fpu_begin()
To:     Borislav Petkov <bp@alien8.de>
Cc:     x86-ml <x86@kernel.org>, jpa@kernelbug.mail.kapsi.fi,
        Dave Hansen <dave.hansen@intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        lkml <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 17, 2020 at 1:33 AM Borislav Petkov <bp@alien8.de> wrote:
>
> On Tue, Jun 16, 2020 at 02:17:16PM -0700, Andy Lutomirski wrote:
> > We definitely need to sanitize MXCSR for kernel fpu if kernel fpu
> > means SSE2. If kernel fpu means x87, we need to fix the fpu control
> > word.
>
> Bah, there's no need to beat around the bush - let's just do:
>
>         if (boot_cpu_has(X86_FEATURE_XMM))
>                 ldmxcsr(MXCSR_DEFAULT);
>
>         if (boot_cpu_has(X86_FEATURE_FPU))
>                 asm volatile ("fninit");
>
> and be sure that kernel users get a squeaky-clean FPU.
>
> > On x86_64, I suspect the UEFI ABI technically requires a clean x87
> > control word too. If we=E2=80=99re willing to declare that the kernel p=
roper
> > won=E2=80=99t use x87, then we could shove that into the UEFI code.
>
> Nah, we don't trust the firmware.

What I mean is: if we trust ourselves to have no x87 instructions in
the kernel, we could put the FNINIT in the UEFI stubs to save some
cycles.  I don't know how slow FNINIT is.

>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette


--=20
Andy Lutomirski
AMA Capital Management, LLC