Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Jun 2020 09:32:17 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Antoine Tenart <antoine.tenart@bootlin.com>
Cc:     davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com,
        hkallweit1@gmail.com, richardcochran@gmail.com,
        alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        thomas.petazzoni@bootlin.com, allan.nielsen@microchip.com,
        foss@0leil.net
Subject: Re: [PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC
 support
Message-ID: <20200617093217.2a664161@kicinski-fedora-PC1C0HJN>
In-Reply-To: <20200617133127.628454-7-antoine.tenart@bootlin.com>
References: <20200617133127.628454-1-antoine.tenart@bootlin.com>
        <20200617133127.628454-7-antoine.tenart@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 17 Jun 2020 15:31:25 +0200 Antoine Tenart wrote:
> This patch adds support for PHC and timestamping operations for the MSCC
> PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP.
> 
> To get and set the PHC time, a GPIO has to be used and changes are only
> retrieved or committed when on a rising edge. The same GPIO is shared by
> all PHYs, so the granularity of the lock protecting it has to be
> different from the ones protecting the 1588 registers (the VSC8584 PHY
> has 2 1588 blocks, and a single load/save pin).
> 
> Co-developed-by: Quentin Schulz <quentin.schulz@bootlin.com>
> Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>

drivers/net/phy/mscc/mscc_ptp.c:406:24: warning: restricted __be16 degrades to integer
drivers/net/phy/mscc/mscc_ptp.c:407:24: warning: restricted __be16 degrades to integer
drivers/net/phy/mscc/mscc_ptp.c:1213:23: warning: symbol 'vsc85xx_clk_caps' was not declared. Should it be static?

Please make sure you don't add warnings when built with W=1 C=1 flags.