Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp673758ybt; Wed, 17 Jun 2020 10:55:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzNUBzaq/Pv/3TdDXOt8bDNjDPO614yCctULkwfAh1gSFk/uJZSu/67vsBoCvpvM9P8FtX2 X-Received: by 2002:a50:9f27:: with SMTP id b36mr295155edf.211.1592416550436; Wed, 17 Jun 2020 10:55:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592416550; cv=none; d=google.com; s=arc-20160816; b=BaPBLX+FyCJC6fgLTSx/h5lE/Fhp6UZJqdIyg8jAnStGZASXBTd7tWhtk4metOPytg 0Tq9akUnIqf9lpIJl0zIPd0jh7BEeHObsXjV3VYHya3Qq7I0MFopBxqXM5Er3mhA/87T 6qTBJQAAEFDGy42BTar/HO2pb5+8PYo4YIXoxxa0keotxymOPlOCwBqYx91Bb4aL48PU RV8u1pr8l0whyB33Z45Ae9CJ7IxG9GflG6AUD8L2zAXX9zufPgwQIx8l4u26ZB2jvz2O nHyU5NO+0MQ2DP5dWevBfBEEqhfaBI7Cyb0WrDFrS8Rl/HdbO4R/h/duBi7a6nTPU6hW eI3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=nZ5C14WBF2RL2CpjdWeV+6NmODm1y6ubQinAU14aVrY=; b=dAhT849ruqY+hDxJ0l4atD8buBKI7He7c7TKpWA0ZGcuLjzVd7m6sVCCH2sCLxbn/L lONBOMvMUPglvt/rBQLyokGJh2G5eAjTNGaxfjGCkuyREaXQeNDbJ0Pwi+nG4S/sMHHo /jFpQFJ+XNwJvfGZ45g9NnD0oSQ9GMjetCI1AEVnrSRmlu4R5AShEkXznIsLCBHCmkHl 3q66ueW5ocrLCVE+s4Ra6jMTiL71Yw9ZAn/lHkFIyqG3cY/G9k4GLhyfcRGNz297d3ML pzRiDutddc+CxsQ3PMOQMuPntDf2H8YTEmkOXogRGUAyYhps8ePJZ545lI0Ni3i5la40 yQ8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B5Ai5zIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t15si419630edy.62.2020.06.17.10.55.27; Wed, 17 Jun 2020 10:55:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=B5Ai5zIp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbgFQRxj (ORCPT + 99 others); Wed, 17 Jun 2020 13:53:39 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:41442 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726971AbgFQRxh (ORCPT ); Wed, 17 Jun 2020 13:53:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592416416; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=nZ5C14WBF2RL2CpjdWeV+6NmODm1y6ubQinAU14aVrY=; b=B5Ai5zIp9pO9v9BoIa2hhRHRGfZN6o8lpesf9WhAtor1EE3LtqooqJWLI+HHBoZrWomWDW h7qZGE+g2a2VHTe/9wFRcEDX31O7Vi22DPlit1Or01V5WZhBwOljlvqmaC8UOSdhKQN6Nw 9v8VfqO0fjEjl2U0AH0bA5zSgHAKz/A= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-G7VIZtFjOPOhpOG9I6HNZg-1; Wed, 17 Jun 2020 13:53:32 -0400 X-MC-Unique: G7VIZtFjOPOhpOG9I6HNZg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 11244100CCC0; Wed, 17 Jun 2020 17:53:30 +0000 (UTC) Received: from llong.com (ovpn-117-167.rdu2.redhat.com [10.10.117.167]) by smtp.corp.redhat.com (Postfix) with ESMTP id 64B6580880; Wed, 17 Jun 2020 17:53:19 +0000 (UTC) From: Waiman Long To: "Darrick J. Wong" , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Dave Chinner , Qian Cai , Eric Sandeen , Andrew Morton , Waiman Long Subject: [PATCH v2 0/2] sched, xfs: Add PF_MEMALLOC_NOLOCKDEP to fix lockdep problem in xfs Date: Wed, 17 Jun 2020 13:53:08 -0400 Message-Id: <20200617175310.20912-1-longman@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v2: - Update patch to add the frozen flag check as the XFS_TRANS_NO_WRITECOUNT check alone is insufficient. There is a false positive lockdep warning in how the xfs code handle filesystem freeze: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_internal); lock(fs_reclaim); lock(sb_internal); lock(fs_reclaim); *** DEADLOCK *** This patch series works around this problem by adding a PF_MEMALLOC_NOLOCKDEP flag and set during filesystem freeze to avoid the lockdep splat. Waiman Long (2): sched: Add PF_MEMALLOC_NOLOCKDEP flag xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim fs/xfs/xfs_log.c | 9 +++++++++ fs/xfs/xfs_trans.c | 31 +++++++++++++++++++++++++++---- include/linux/sched.h | 7 +++++++ include/linux/sched/mm.h | 15 ++++++++++----- 4 files changed, 53 insertions(+), 9 deletions(-) -- 2.18.1