Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423139AbWCXFSD (ORCPT ); Fri, 24 Mar 2006 00:18:03 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965025AbWCXFSD (ORCPT ); Fri, 24 Mar 2006 00:18:03 -0500 Received: from mail06.syd.optusnet.com.au ([211.29.132.187]:32219 "EHLO mail06.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S965030AbWCXFSC (ORCPT ); Fri, 24 Mar 2006 00:18:02 -0500 From: Con Kolivas To: "Rafael J. Wysocki" Subject: Re: [PATCH] swswsup: return correct load_image error Date: Fri, 24 Mar 2006 16:17:23 +1100 User-Agent: KMail/1.9.1 Cc: linux list , ck list , Andrew Morton , Pavel Machek , linux-mm@kvack.org References: <200603200234.01472.kernel@kolivas.org> <200603210022.32985.rjw@sisk.pl> <200603241600.56144.kernel@kolivas.org> In-Reply-To: <200603241600.56144.kernel@kolivas.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603241617.24434.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1550 Lines: 48 > On Tuesday 21 March 2006 10:22, Rafael J. Wysocki wrote: > > Basically, yes. swsusp.c and snapshot.c contain common functions, > > disk.c and swap.c contain the code used by the built-in swsusp only, > > and user.c contains the userland interface. If you want something to > > be run by the built-in swsusp only, place it in disk.c. Would this patch suffice? Cheers, Con --- Swsusp reclaims a lot of memory during the suspend cycle and can benefit from the aggressive_swap_prefetch mode immediately upon resuming. Signed-off-by: Con Kolivas --- kernel/power/disk.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletion(-) Index: linux-2.6.16-mm1/kernel/power/disk.c =================================================================== --- linux-2.6.16-mm1.orig/kernel/power/disk.c 2006-03-24 15:48:14.000000000 +1100 +++ linux-2.6.16-mm1/kernel/power/disk.c 2006-03-24 16:15:05.000000000 +1100 @@ -19,6 +19,7 @@ #include #include #include +#include #include "power.h" @@ -138,8 +139,10 @@ int pm_suspend_disk(void) unprepare_processes(); return error; } - } else + } else { pr_debug("PM: Image restored successfully.\n"); + aggressive_swap_prefetch(); + } swsusp_free(); Done: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/