Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp781152ybt; Wed, 17 Jun 2020 13:56:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8xsNXEq40AKTNIRX5jZVO2pI8bFuGJafWbzjG5ctH/zHGAhGp77iQ5hf4MiVb35QBjr7f X-Received: by 2002:a50:d7de:: with SMTP id m30mr938687edj.183.1592427402435; Wed, 17 Jun 2020 13:56:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592427402; cv=none; d=google.com; s=arc-20160816; b=WnmNkFa0tMLeXvy26kY7x/+9iUaPMw8EK/f4GBBa5CIw3tO4NX2LjEeCBYsFA47E0O 9pJzFViWfpKuQbx8Ljf9W2736P7uHkNacO08xZ9Wp8oLH9oamryg1m2Om2TdUCheDS2j /VMSF+eZKekFdW6UsuBJmXN66KQnlAXCXN+1Om8t6ciBtq+EMOQnQu2qSQGrPVWCMMy2 6pQtDih6KbSO5dJWqZlteeFgwWFsYGChYo3FiUJH3hkoZpEdBVW+9kkfPi/LO9VNHLm7 XiIt2t7A4EvvsO/GL1Ropyrb0rAeHZtfu1XISs2hozFR7YEcx1DwyYgXPWETT6eTQFsy 8Vnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=8J5BNAt5Yt4UkjDxM/I4nNXojnzOrIFIUlZmtAyGljM=; b=Nr8tbLXvHbqsnzOuffUui+buqc6hhF/RE5IQ449FeuUIsX+jpILK4todxCmTj/HUXN G6QUZbMEleDd7Rkj7iuMYvV4fbDd2aIMntFldUzfzBIz8rLWobs8Kgb2wAhYRepNTojC 5+K/NwmGVSh5jj06FL2yQp1PlZ3OtxRzotDmoZyf9KUnD1mCWX7nq/s7uZhMO71w08br E2mIOvXCU0q43GGskdliGKRLfnCCIkCrOZVnb8F1qO5wEt0ly9Q+rrQn5ILrPBsZjHpm OYtHsxCHXdWCK6jCHtr05ZS8bsyYO6slbhG3RZ8sCaRsaQCgl20T/jmk6wPrYWjdepC6 XOQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dd24si617095edb.336.2020.06.17.13.56.20; Wed, 17 Jun 2020 13:56:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726928AbgFQUwS (ORCPT + 99 others); Wed, 17 Jun 2020 16:52:18 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:49844 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbgFQUwS (ORCPT ); Wed, 17 Jun 2020 16:52:18 -0400 X-IronPort-AV: E=Sophos;i="5.73,523,1583190000"; d="scan'208";a="351906721" Received: from abo-173-121-68.mrs.modulonet.fr (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jun 2020 22:52:16 +0200 Date: Wed, 17 Jun 2020 22:52:16 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Denis Efremov cc: Kees Cook , cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: Re: [Cocci] [PATCH] coccinelle: misc: add array_size_dup script to detect missed overlow checks In-Reply-To: <7c7b22f8-722c-60f5-db5d-290bea2b499c@linux.com> Message-ID: References: <20200615102045.4558-1-efremov@linux.com> <7c7b22f8-722c-60f5-db5d-290bea2b499c@linux.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 17 Jun 2020, Denis Efremov wrote: > > > On 6/17/20 11:30 PM, Julia Lawall wrote: > > > > > > On Mon, 15 Jun 2020, Denis Efremov wrote: > > > >> Detect an opencoded expression that is used before or after > >> array_size()/array3_size()/struct_size() to compute the same size. > > > > This would benefit from the assignemnt operator metavariables as well. > > > > Also, it could be better to put the python rules up next the SmPL pattern > > matching rules that they are associated with. > > > > Thanks, I will send v2. > Here is the KSPP ticket with patches https://github.com/KSPP/linux/issues/83 Thanks! julia