Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp934214ybt; Wed, 17 Jun 2020 18:18:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxe2ep6IJTCl6G99DgtR1MWwFgAGrgDlMPNU/UcS1XiDZDRlZXM3zz4Dd9MM8yDZmAjZ97v X-Received: by 2002:a17:906:7693:: with SMTP id o19mr1644337ejm.295.1592443128509; Wed, 17 Jun 2020 18:18:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592443128; cv=none; d=google.com; s=arc-20160816; b=MvVoUSRtGzkDO9Rw5WjrkbBxAZFsFYR0FUN6zGqfuw3XL52bJAZbli12KkbJ/zwkMo ldfQ/w1eRUR47ut8I7FK0MN5GvkXbtnXuFGc8g76cbpXQ1JabJIJBiiCXOy0ZSVj00i5 piqOKQbPkZpXAWs2DS5rACoIeBTjx8eJiQuM1mYKtXx47bMBepykwOL/Kw0BLhaMBQ2d nY3iq+2UT7f5RJsuDpkVYu80YeHjSS46Gbhc2aF0isAEgGfCfPTaaRKwE9XQ3Tvd8OM1 H3ks9TFEARZu9AjhVZu/tObphG3U/s+xYB8TuRohCZgi/94+la1Yj5VOd4jYE849ukAP knnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=017O+UW9g1NCzRTJZBU/MzjP/8IC5aY3SAALWOAfi7s=; b=oZpD2464kD27At0r0jcQ5a4Yu/IeUJpwLLJPI3DmWaKK7/VADcYux61Pphb+/F8xKL 0gQ7Bw9hwVhOSuH5JGzpGrkLVdEaNvemRtBJRs610dHY5eBTjOjc+NlKYnWP2HK1HTeg ygJoqxo40iLvcEnE5+fk1Rn92j/coZ461625XqSfW/vsdC4t8nTlg+wSHxGvHjLnh8Ef 0qfpkIq/ENAovsZXaPvpnrclDX4fX9mPj6eI4JNTnkSwX5zJcTBmnaCarP0wDJCxb+VZ PEf95oKJFfhENqGTqiu+tWuBIeHOX/wtfe/pZdCjk68iP9sdkE3P2QIu73LR9+2mOu20 0mUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Oyfh1tAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h10si859634eja.608.2020.06.17.18.18.26; Wed, 17 Jun 2020 18:18:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Oyfh1tAP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728504AbgFRBOb (ORCPT + 99 others); Wed, 17 Jun 2020 21:14:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:42164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgFRBNK (ORCPT ); Wed, 17 Jun 2020 21:13:10 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5930620CC7; Thu, 18 Jun 2020 01:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442790; bh=0V7dE6479ka7p+b1cgEb56ZJP10pjJxIG98AhJLSwms=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oyfh1tAP8QLJlTVR7PTOsNpLv3Wp5bu7nxdhaDkQ0lMeVL6cfmJcgUoe9myOHknmE osySGuxvUwt88LNZ7tH2QcYai5Liv9VG9qz2KAvZSs4+mG7Je/xnvR6s++K1Qr3VoL XhXEvnZB/jhOQHhUPP27TEij1v2Ot2RWbKfzYYqY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Tang Bin , Zhang Shengju , Peter Chen , Greg Kroah-Hartman , Sasha Levin , linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 233/388] USB: host: ehci-mxc: Add error handling in ehci_mxc_drv_probe() Date: Wed, 17 Jun 2020 21:05:30 -0400 Message-Id: <20200618010805.600873-233-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tang Bin [ Upstream commit d49292025f79693d3348f8e2029a8b4703be0f0a ] The function ehci_mxc_drv_probe() does not perform sufficient error checking after executing platform_get_irq(), thus fix it. Fixes: 7e8d5cd93fac ("USB: Add EHCI support for MX27 and MX31 based boards") Signed-off-by: Zhang Shengju Signed-off-by: Tang Bin Reviewed-by: Peter Chen Link: https://lore.kernel.org/r/20200513132647.5456-1-tangbin@cmss.chinamobile.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/host/ehci-mxc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/host/ehci-mxc.c b/drivers/usb/host/ehci-mxc.c index c9f91e6c72b6..7f65c86047dd 100644 --- a/drivers/usb/host/ehci-mxc.c +++ b/drivers/usb/host/ehci-mxc.c @@ -50,6 +50,8 @@ static int ehci_mxc_drv_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); + if (irq < 0) + return irq; hcd = usb_create_hcd(&ehci_mxc_hc_driver, dev, dev_name(dev)); if (!hcd) -- 2.25.1