Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: [RFC PATCH v2 3/5] scsi: ufs: Introduce HPB module
Reply-To: daejun7.park@samsung.com
From:   Daejun Park <daejun7.park@samsung.com>
To:     Avri Altman <Avri.Altman@wdc.com>,
        Daejun Park <daejun7.park@samsung.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "beanhuo@micron.com" <beanhuo@micron.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "tomas.winkler@intel.com" <tomas.winkler@intel.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Sang-yoon Oh <sangyoon.oh@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Adel Choi <adel.choi@samsung.com>,
        BoRam Shin <boram.shin@samsung.com>
In-Reply-To: <SN6PR04MB4640350209C30F578945492CFC9A0@SN6PR04MB4640.namprd04.prod.outlook.com>
Message-ID: <231786897.01592444701916.JavaMail.epsvc@epcpadp1>
Date:   Thu, 18 Jun 2020 09:53:44 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
References: <SN6PR04MB4640350209C30F578945492CFC9A0@SN6PR04MB4640.namprd04.prod.outlook.com>
        <231786897.01592212081335.JavaMail.epsvc@epcpadp2>
        <336371513.41592205783606.JavaMail.epsvc@epcpadp2>
        <231786897.01592205482200.JavaMail.epsvc@epcpadp2>
        <231786897.01592213402355.JavaMail.epsvc@epcpadp1>
        <CGME20200615062708epcms2p19a7fbc051bcd5e843c29dcd58fff4210@epcms2p5>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> +static int ufshpb_lu_hpb_init(struct ufs_hba *hba, struct ufshpb_lu *hpb,
> > +                             struct ufshpb_dev_info *hpb_dev_info)
> > +{
> > +       int ret;
> > +
> > +       spin_lock_init(&hpb->hpb_state_lock);
> > +
> > +       ret = ufshpb_alloc_region_tbl(hba, hpb);
> > +       if (ret)
> > +               goto release_m_page_cache;
> This label is added only on 4/5
> 
> > +static int __init ufshpb_init(void)
> > +{
> > +       unsigned int pool_size;
> Unused variable
> 
> > +       int ret;
> > +
> > +       ret = driver_register(&ufshpb_drv.drv);
> > +       if (ret)
> > +               pr_err("ufshpb: driver register failed\n");
> > +
> > +       return ret;
> > +}

OK, I will fix it.