Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 17 Jun 2020 18:18:58 -0700
From:   Roman Gushchin <guro@fb.com>
To:     Shakeel Butt <shakeelb@google.com>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Christoph Lameter <cl@linux.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Linux MM <linux-mm@kvack.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Kernel Team <kernel-team@fb.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 00/19] The new cgroup slab memory controller
Message-ID: <20200618011858.GC24694@carbon.DHCP.thefacebook.com>
References: <20200608230654.828134-1-guro@fb.com>
 <CALvZod7ThL=yMwxzCLvrTtq=+Dr5ooUSX-iFP8AhiAGURByFBA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALvZod7ThL=yMwxzCLvrTtq=+Dr5ooUSX-iFP8AhiAGURByFBA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.DHCP.thefacebook.com (2620:10d:c090:400::5:9687) by BY3PR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:217::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3109.21 via Frontend Transport; Thu, 18 Jun 2020 01:19:01 +0000
X-Originating-IP: [2620:10d:c090:400::5:9687]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: a16ada88-6052-41bf-40d3-08d8132595e9
X-MS-TrafficTypeDiagnostic: SN6PR15MB2397:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <SN6PR15MB23973B4B55E575057CAFD85BBE9B0@SN6PR15MB2397.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-Forefront-PRVS: 0438F90F17
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 8zFTndWHVNNGtD9y2m0Evv0yC/XMLRqOqGiVQrTnT679IiCntvn9KJtZ9uPQik8yuAPctq6Bowh3uU0yEI4TbWzIuUpQIOj6KJ84jxM7xc+znrEBHwhKZgwU0i0+ng+MvpNWAsgu/mgY002bxKuW3lRPbvTR55mny/Tb9yX9JYSzwdLmhUyipxKiSqL8ZtCLiAFmJzyzlDGmXzSG/BhV87K9v4JeXHaIsW7KYj44C6tvKE2EbD1iXGijUYVjcimGf/4ab20Y0haLpGNrNOJ4ZLadk5DT/AAkc0WoWPle7Ji6eiisqdaI1AT8qNEMfVBLdctN905kQhgP996Rf9IcKA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR1501MB4141.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(366004)(136003)(39860400002)(396003)(346002)(376002)(54906003)(2906002)(83380400001)(316002)(5660300002)(478600001)(4326008)(186003)(16526019)(86362001)(6666004)(7696005)(8676002)(52116002)(66476007)(66556008)(33656002)(66946007)(6916009)(6506007)(53546011)(4744005)(9686003)(8936002)(1076003)(55016002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: YXQPT9FQjdzZyLAL/fTffFAeV9ae3ww88rEXWnY41N0DB43YYc0NLa5UXGwObXZiTkspAvPIslfsep4tSMYXXV520hsrs2BdyqyTPVcE3Ln+VpX9BiLfpUNwkk/TYMrZXLTvuGr32h+3xvpX/cnuIAeLleB1nKXjjyiC2Bf/P+7KJSkjbFnN153UrkO+1SnCjdsDwCRx3qjMNcVteLMvjw2izddt5vCv1CrUWNnmPuJdi/dlo0K7ZL6c7QwJoFXtuJwYXm+r5JYtoqPrMzozvqyM8SuUvWotapBY1HX+RocZhMMvH7FQwp1O94+ocWgVOCl+7zov+olFUTYsAM8Y5B4Y55+6UasEtKqA3qq8lDGyoQfHuuvoPKdYtsV4ZuewQBPdnwuirqhuL2dpX7VBgXm0v1u4MQGtKIwKWEGuneRRmoMO0Ro3oTegeFk+ZvtJR/Uyr+vt2GIaUj1VNll4prk+jyrtmBxF0PZbPpUMvs2wxYPPCikwZTgs65HmiIzOA51UCuXb2gcNyrtjZcp02A==
X-MS-Exchange-CrossTenant-Network-Message-Id: a16ada88-6052-41bf-40d3-08d8132595e9
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jun 2020 01:19:02.4393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kwdRVfYvtKnaJrROtiVC5Vd+nizCR6BzkGgVXgQyaXN1vZwIX+zjRggBK7av6XyK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR15MB2397
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687
 definitions=2020-06-17_12:2020-06-17,2020-06-17 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0
 mlxlogscore=999 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0
 cotscore=-2147483648 suspectscore=1 adultscore=0 impostorscore=0
 lowpriorityscore=0 malwarescore=0 priorityscore=1501 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000
 definitions=main-2006180007
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 16, 2020 at 06:46:56PM -0700, Shakeel Butt wrote:
> On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin <guro@fb.com> wrote:
> >
> > This is v6 of the slab cgroup controller rework.
> >
> > The patchset moves the accounting from the page level to the object
> > level. It allows to share slab pages between memory cgroups.
> > This leads to a significant win in the slab utilization (up to 45%)
> > and the corresponding drop in the total kernel memory footprint.
> 
> Is this based on just SLUB or does this have a similar impact on SLAB as well?


Just got some fresh numbers on my desktop running 5.8-rc1 + slab controller v6.
It's 8-cores Ryzen 1700 with 32 GB RAM running Fedora 32.

I measured the size of slab memory just after logging into the system.

                   SLUB           SLAB
Original:     463232 kB      312880 kB
Patched:      194840 kB      193392 kB
                   -58%           -38%

Plus perpcu memory usage is also a bit lower.

Thanks!