Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp970371ybt; Wed, 17 Jun 2020 19:27:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMMF5W8Zj7kGQJAX2lUtGQkC3jPSBhMNKBAJ34BnR9rGY3kVG4P4K7MLTLhed8/UdjW2ly X-Received: by 2002:a17:906:aac8:: with SMTP id kt8mr1999454ejb.460.1592447261806; Wed, 17 Jun 2020 19:27:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592447261; cv=none; d=google.com; s=arc-20160816; b=z0FmhYbcW0Gi2wnNk4dtZkHR0VG8Umo6BnNhq1ZJH9ZjKxUWqYMIXhKlshib6Psj7R AbuzhZ5rOGNQNHhz24oCP9WtKuHmPdAPBM28BeO6OPNnS6CpzjCbO8HEglzHkDY19Glo 1a2n6YE3xoLjEKPhNAp/n/zK1660okO7fs/02Rw0TPZuSYettD9SJxPKu9CoNg405Q30 Vh3TwuPzw3xgeMsVkUU8LsNaA+sCXW/kgR0/K0jngIjZRl4h9fCg6vxPunOGoQtxht6X G0bQoM5tmFiXqUoFNzLoJ89MQVEVQQcxQsz6oGNZAlDGS7ZIwKbRFesVv+Vm3d/T83eJ tCdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xeXAQHI+srUoFl4mrG5xbTYgKdPl0RsroeE/cBU5dxA=; b=XCQ7XoeFPs/41aZM+3yzJMr1wVFxviI1+fiF2dbBWx5vk6AaHRSjCUmYOAd44bzW/i 51V245m0kAsYuFVnP00vSc0FercC521gFpZSLs2uhHkClWwYGWm90AoksSwC4vQg/qnN FDWJq3z2NYJmK8FJA+nnJ6C/sC5/p3gaia5g0BIRMI4x+hAUAdXFKafdvZDqN0nsKiyU awoB6S9pfKWS7fvOu0kRC65Xj38M2AxC9uKArphqbgD1EcF7d4ZxUb9ooqTrHSXzndPS f3PHlvCPrw8K6vL76bgpZu9SrI1F2kZQ8RXRDUenoxwLDFCBYI5Ie99oFKkfsHOzWfYx yVgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cHRfdvLq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f13si901699ejr.6.2020.06.17.19.27.19; Wed, 17 Jun 2020 19:27:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cHRfdvLq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728322AbgFRBRV (ORCPT + 99 others); Wed, 17 Jun 2020 21:17:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:44596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729380AbgFRBOu (ORCPT ); Wed, 17 Jun 2020 21:14:50 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0009B2193E; Thu, 18 Jun 2020 01:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442890; bh=gcYIdJSBndXo8ib41qkOp7IDNKCp6T94n1aw+8dxIIM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cHRfdvLqjyZsW6g99eM1+psSgkitdeKAGnxLTD8c6VwttLrH4Wy5Y9NyD+V0zNWaG unnA3eH0b9PIQ56xZZrlLzNzVqIbOJrU2Wf4VyESzbpJU7DLkZwWAke5MMjaNtfOuh l0KuCXWKWnMw+YSp3XHG+JniHPEL40vZDv1NYUH4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Stafford Horne , Sasha Levin , openrisc@lists.librecores.org Subject: [PATCH AUTOSEL 5.7 313/388] openrisc: Fix issue with argument clobbering for clone/fork Date: Wed, 17 Jun 2020 21:06:50 -0400 Message-Id: <20200618010805.600873-313-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stafford Horne [ Upstream commit 6bd140e14d9aaa734ec37985b8b20a96c0ece948 ] Working on the OpenRISC glibc port I found that sometimes clone was working strange. That the tls data argument sent in r7 was always wrong. Further investigation revealed that the arguments were getting clobbered in the entry code. This patch removes the code that writes to the argument registers. This was likely due to some old code hanging around. This patch fixes this up for clone and fork. This fork clobber is harmless but also useless so remove. Signed-off-by: Stafford Horne Signed-off-by: Sasha Levin --- arch/openrisc/kernel/entry.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/openrisc/kernel/entry.S b/arch/openrisc/kernel/entry.S index e4a78571f883..c6481cfc5220 100644 --- a/arch/openrisc/kernel/entry.S +++ b/arch/openrisc/kernel/entry.S @@ -1166,13 +1166,13 @@ ENTRY(__sys_clone) l.movhi r29,hi(sys_clone) l.ori r29,r29,lo(sys_clone) l.j _fork_save_extra_regs_and_call - l.addi r7,r1,0 + l.nop ENTRY(__sys_fork) l.movhi r29,hi(sys_fork) l.ori r29,r29,lo(sys_fork) l.j _fork_save_extra_regs_and_call - l.addi r3,r1,0 + l.nop ENTRY(sys_rt_sigreturn) l.jal _sys_rt_sigreturn -- 2.25.1