Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp973683ybt; Wed, 17 Jun 2020 19:34:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx+YQqKN4tJm7MwyjI9rXfa0fSvk6gjOpuD1n/0YyMZpKnZgpm2h4yP/qDSceXMjOv/Tsp5 X-Received: by 2002:aa7:c6c7:: with SMTP id b7mr1968846eds.213.1592447666888; Wed, 17 Jun 2020 19:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592447666; cv=none; d=google.com; s=arc-20160816; b=wz04lHnxa8+4ZknJ5xzpWaZZuuXKi+0hd5z8LxBE9FTYk+zm7OF+A4jxGiDaNzpb5q UzsUsbd2UG2Uki39lHebBByKCPTVPyIry8DZ1xRuT25S+1Pzr/JvTggn0XZObuB7OZlL LjnjhqscvUys4hfnid0BGWBA3ojtrcGCtPs5WLJXHNrOzgagzwdm/mScU07ss2QgpHbi JV9IUo2GRB96xfa6uOLs011LDUofrT0TPkUhEIkNB9JtAqNzs0lIa7OE3fSGjFZJAyFZ rKGu3+2U1Jdbiv4RQThriHJWvauInkT8psFIITfpj0V/AFF4vnRnuyKBjOYBn1QQ7t/z 5i7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MIsDlX94h9uPS4fiwJUMgtkndtRO9QpKXTRI0ktw6qw=; b=xmYQ6UegU7J2BXcCBFjGPwGsfkFV9oKnkJDe4ZQPdE8384c6mQFzZLsrl1lehsUjs6 zFzDQbtHzNc3IYWwuW1KuLYPZiHmAe8/P14hMoPugCVHzEuxV0BAWRTiRQE/L/TliXp5 UuvAh3i4dDbactpg8Rdu2wgjdbXwYBK0+eDuMPKg5hyG/+ZB1J0OcJ5gctwzDeqVUjZK U2eo3lHxKlpCJn/UHmcvVqQCL0eJqN116N7+4qEDjCxAvm4+onownusfL8XpJkjzXNbV s7cyd9ltZT9J+izojvQCwtiTUQaq3HjFj3bHPngcB/gtrSpwV9tQRzINO11D8sdOm4PZ yWRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H2Xa4GOG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r3si1118240edq.265.2020.06.17.19.34.04; Wed, 17 Jun 2020 19:34:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=H2Xa4GOG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbgFRCa1 (ORCPT + 99 others); Wed, 17 Jun 2020 22:30:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:46168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727901AbgFRBPy (ORCPT ); Wed, 17 Jun 2020 21:15:54 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02D9A221F6; Thu, 18 Jun 2020 01:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442952; bh=wSXH/t1nm9cYgnXHIJs3ya+RyoRsiYYIX2/TKeLDJgc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H2Xa4GOGm8aVol+iRzuH6pyoI0M/NEfcxp/WD66rp/WE4kzaFM5KrKSzPXC5IfLBp gE4iMaG/rOxsCAo8yNxbOIX0X03YMpEmF54KLXeVaRUP4hS8qZkxl/Dfjv26Dn9bz9 2g3HZ7R9hjRGSMWaAY8XWJdQ9QFP5FrFMWxz+28w= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Zhihao Cheng , David Howells , Sasha Levin , linux-afs@lists.infradead.org Subject: [PATCH AUTOSEL 5.7 361/388] afs: Fix memory leak in afs_put_sysnames() Date: Wed, 17 Jun 2020 21:07:38 -0400 Message-Id: <20200618010805.600873-361-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhihao Cheng [ Upstream commit 2ca068be09bf8e285036603823696140026dcbe7 ] Fix afs_put_sysnames() to actually free the specified afs_sysnames object after its reference count has been decreased to zero and its contents have been released. Fixes: 6f8880d8e681557 ("afs: Implement @sys substitution handling") Signed-off-by: Zhihao Cheng Signed-off-by: David Howells Signed-off-by: Sasha Levin --- fs/afs/proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/afs/proc.c b/fs/afs/proc.c index 468e1713bce1..6f34c84a0fd0 100644 --- a/fs/afs/proc.c +++ b/fs/afs/proc.c @@ -563,6 +563,7 @@ void afs_put_sysnames(struct afs_sysnames *sysnames) if (sysnames->subs[i] != afs_init_sysname && sysnames->subs[i] != sysnames->blank) kfree(sysnames->subs[i]); + kfree(sysnames); } } -- 2.25.1