Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp973949ybt; Wed, 17 Jun 2020 19:35:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBS03FiBli+ShZZkMOfli4M2P0epZfSvApZXycM/1IDyDizML8YmBSkVPTl+mCQCn4w7BH X-Received: by 2002:a17:906:1b1b:: with SMTP id o27mr1841457ejg.264.1592447705014; Wed, 17 Jun 2020 19:35:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592447705; cv=none; d=google.com; s=arc-20160816; b=qNk56GeAfwqwqjc+aUYaUa8muIv/c2A5SoHBAC3zXWe41NIRmGIalRXzCxZcwa1ZXC tffvqjZ7TIEuA4KvKms/ToWXxCcYiH4Ubn9QtQBZXMPDPxWRXHUxDoqNJUGM59UauIq/ zsZbsdpUpKH1NhLHq+bY9y7b/PCbCdj0NJjwbqJdA7oooG0TqBc21NEqbM1i3NdLprlW mcZkLwv8pzhmaBTsuQPyf2JQXTGwIW4g/FO6nMcQQHnjdqiDuLC96WuDTAK1IxdmT5lh Eiio/SBgVNbbgOeP/b9/hzzGYzLFRrm5erjfycmCFfSAYy1GcDCQ5wRuWGTPug8B0Fo+ AbwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4GzK0to+1+/pogn2swbI7gbXo6Vac58buY7ZA6pBlAY=; b=q4ddrNfHy5MnaFeTxhvNc+FhEb3ALLecV2oOiIfAUmd/chIg6NI0eDrI6Ub3k2KF9X 9rVZZZBKP2Uv9zJ8/sJgxaAFMYtxn4pe3nNRII5Nz6BrkQb8wgRT0B5KllBSnqsqRz70 Hgz9Re2KmUEY1YNR8TCbz5Q1XbxplWgxW/ykNN09o7goCFPUE2BcG+lSrEl0wr/qY7N1 MW+ZkyVB/5gJh7AfRUfQ2OqSxbHqtCbj4dMNy1KW4eMXbpVMZLRjnwud3E/DqyPH7ZKH PgAMB5x3Cc4EDURH9NC3RDEjhvU8O1vpTmpWlr9eK1n2HFQqfElCnReCUmlxBxbJvvnB bw8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QXAstZZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l8si949491ejb.670.2020.06.17.19.34.42; Wed, 17 Jun 2020 19:35:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QXAstZZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387453AbgFRCc6 (ORCPT + 99 others); Wed, 17 Jun 2020 22:32:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:44908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729422AbgFRBPB (ORCPT ); Wed, 17 Jun 2020 21:15:01 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B63A0221EA; Thu, 18 Jun 2020 01:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442900; bh=wrZIAq9fTJ3Dp9QQKIdlPNcKPKFcJ2C93L8OCBXtUY0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QXAstZZ32zyB4Ric27htcX0hbTVvbr2STrlrhF3YHDYDG9IWcz/KtR7yAUZuYHXmj nPeIMndQJKg1ayGKGcHrpEJXVglTRXW08cw06LKynvsHFBYXaei9/COEfxearpckm6 srRxvK2Qu2XqsGOs2HhKgdjxrrNV/6GR0acWAIRI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Can Guo , Stanley Chu , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH AUTOSEL 5.7 321/388] scsi: ufs: Don't update urgent bkops level when toggling auto bkops Date: Wed, 17 Jun 2020 21:06:58 -0400 Message-Id: <20200618010805.600873-321-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Can Guo [ Upstream commit be32acff43800c87dc5c707f5d47cc607b76b653 ] Urgent bkops level is used to compare against actual bkops status read from UFS device. Urgent bkops level is set during initialization and might be updated in exception event handler during runtime. But it should not be updated to the actual bkops status every time when auto bkops is toggled. Otherwise, if urgent bkops level is updated to 0, auto bkops shall always be kept enabled. Link: https://lore.kernel.org/r/1590632686-17866-1-git-send-email-cang@codeaurora.org Fixes: 24366c2afbb0 ("scsi: ufs: Recheck bkops level if bkops is disabled") Reviewed-by: Stanley Chu Signed-off-by: Can Guo Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufshcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 698e8d20b4ba..52740b60d786 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -5098,7 +5098,6 @@ static int ufshcd_bkops_ctrl(struct ufs_hba *hba, err = ufshcd_enable_auto_bkops(hba); else err = ufshcd_disable_auto_bkops(hba); - hba->urgent_bkops_lvl = curr_status; out: return err; } -- 2.25.1