Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp979078ybt; Wed, 17 Jun 2020 19:46:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxNKLHju7zzhsr5GAG+KzHSH4dfkNz+n6dgYrMEK/HR9EUhKu2mY+4knAhZfPQsBAmONuxM X-Received: by 2002:a17:906:6a4b:: with SMTP id n11mr1925864ejs.198.1592448361008; Wed, 17 Jun 2020 19:46:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592448361; cv=none; d=google.com; s=arc-20160816; b=WzD012v4U1bWLN3SCDp0cqpEvncbdcAyafTu4CdOf6qTK8opU4kK51dSma7do9ndf0 8qmMjJEJv+IwKkNGSUzr4I+efHCRj8tFZ8xtt8Y/jfzJC2Zy9QyQykb9CciJfBeaUXAd qamfZO15N4+rWfr9SuqIJb49kZ+lLWaakRpX181+25RJ9T1XH7v0C2Ebo1t0xe0QCo4w 3vzdCbI7a1n66XTRFTr5n1jDW4gmBWS1MFE4zc8jBj336HaRppArBoH85UiLEuPmdn4t uA6DV/TePrtDTuZCuzbLC86710EqDeR+82cyZ1/rCQ3eEdCiPvb9/OOn28gCRIoqw4we eAmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LxD0w+KSuMi65ykAm+3tmKYQ1X7ytF4eq7nCrTlnTJs=; b=ydU7pj1HBotxfLYm8TMM5rSpb/NnajCFW3lWamJL6mMwotMvmNO/T6Et4ZhLp5810D UeJby+OjBHa3DqlyOLY1AKvIH+UKYZROEhEjqTmhA0sjJf7LhmdrAjOjeWsI6HScIq5q 3SSh/i+kl+ReKCwpCzA5co9AqMDZVBu4WdM1dM/bsUckw8L4jjq640PutO4bRT4RbiYY AQQXsfTl/ETEIUEFOerIBFjnCs8bKnPFLP2gU4SDDosZF7PtcEV/zVpDUUdvPWMe1tqE 12MPkMCDoMN3TbhPpxt8a29FzUHAi2leDkFUoyC599dh3xgxM5pBbVBlnUigv2HX1GXz BVrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lt4OpY2k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt9si1028363ejb.65.2020.06.17.19.45.39; Wed, 17 Jun 2020 19:46:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Lt4OpY2k; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730179AbgFRCmE (ORCPT + 99 others); Wed, 17 Jun 2020 22:42:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:40662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728863AbgFRBMM (ORCPT ); Wed, 17 Jun 2020 21:12:12 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AFFEB20B1F; Thu, 18 Jun 2020 01:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442731; bh=z22Di1OaYRhfoLSdQDUT6FgZNUHWs+7Pv+CcZyeFtLQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lt4OpY2kEuc70Cm1uPEc9kcLWKoHg/aFVIEUjGWCCW8IS3FOUz1YtnnwhwHBwzlyf O1HLTccr4OeX4xUqGgaqxosBRQfUIujvPlm4Qyidqm71ARBQvdxqRL5s7BeINwpT4g Cj8mdJK9mmSwJw24Nb0hdxn13/9/t2w+36kDRQxg= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Suganath Prabu S , Dan Carpenter , "Martin K . Petersen" , Sasha Levin , MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 187/388] scsi: mpt3sas: Fix double free warnings Date: Wed, 17 Jun 2020 21:04:44 -0400 Message-Id: <20200618010805.600873-187-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Suganath Prabu S [ Upstream commit cbbfdb2a2416c9f0cde913cf09670097ac281282 ] Fix following warning from Smatch static analyser: drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->hpr_lookup' double freed drivers/scsi/mpt3sas/mpt3sas_base.c:5256 _base_allocate_memory_pools() warn: 'ioc->internal_lookup' double freed Link: https://lore.kernel.org/r/20200508110738.30732-1-suganath-prabu.subramani@broadcom.com Reported-by: Dan Carpenter Signed-off-by: Suganath Prabu S Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/mpt3sas/mpt3sas_base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c index 663782bb790d..39d233262039 100644 --- a/drivers/scsi/mpt3sas/mpt3sas_base.c +++ b/drivers/scsi/mpt3sas/mpt3sas_base.c @@ -4915,7 +4915,9 @@ _base_release_memory_pools(struct MPT3SAS_ADAPTER *ioc) } kfree(ioc->hpr_lookup); + ioc->hpr_lookup = NULL; kfree(ioc->internal_lookup); + ioc->internal_lookup = NULL; if (ioc->chain_lookup) { for (i = 0; i < ioc->scsiio_depth; i++) { for (j = ioc->chains_per_prp_buffer; -- 2.25.1