Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp980145ybt; Wed, 17 Jun 2020 19:48:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAa9YVS6tiMX0QdeGADv+IdGCuU7lgRo+UwC0usgDeRf0Vg6tH166OLqMY8ZKq528MKnu8 X-Received: by 2002:a50:a207:: with SMTP id 7mr2119586edl.92.1592448489793; Wed, 17 Jun 2020 19:48:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592448489; cv=none; d=google.com; s=arc-20160816; b=lQhWrx7iAuOIh9No5zxB9Ldo+xXtujKpLaM55InATF6rksn193cTTwIWcc5yczB9Fw 1fjHzqgDN/j6mTFQ9fUqoWTmu2s/yhUjujwZb/BtPutrHWRdNjaYR7PiRcOm7biCw2/k SThKQzgniOKyM5b92phhhIh/8FOoESzIQSAVAkNK8pB8+WQt9j7szQwwB0CKFaEm2C9Z sX59XcnUAH+lEO+dttUSbX9N2EyF+fZ5j48HT5gp/vdnDqPQnw42BveayN66DExiXxcD /+/yNdw+YrGw4jE8kjnLCj/eWbAxyFZQT3Tscayzxcsokbm6yG+uzj/eDW6Fm/d+FSZ6 0NLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vFx0Bca+/DG8eBbvplEdKeaof7WtYySr6hY3WkHzyic=; b=uqLEjggrAyLTosZneA4RQ5qU1vMUyfSxsoZu55yOHXIEPFvfbjQDG29sLs6/JkspAp oAnOjzkZpwPZYWIlx6rXGowySIqVfxJoABFNxS98FHYZyP6MzNdfP+mp8LEZrb1odcgo hyWytDya5LxNWid9cxGNHQo+paaN43R6jiQQMtJ1bF/bRWngIZEJ0iwOru9nIK6XhakE IptowHwUe3ZA6Ss7PnUB0ajMkHBCBV8tHinOKkcGk6FKHfZhBPkXZ+WAQpeHAxL77DTM +2gX4wxGcWyrwIAFnLLVodRyUEH10Gqfk87Igw0ZZDQrSs3OFhklBkvGbym/kJGzHNA/ CeXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b9QrIRui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si1212563edh.53.2020.06.17.19.47.47; Wed, 17 Jun 2020 19:48:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=b9QrIRui; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728600AbgFRBKp (ORCPT + 99 others); Wed, 17 Jun 2020 21:10:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:38094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727779AbgFRBKl (ORCPT ); Wed, 17 Jun 2020 21:10:41 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9105F214DB; Thu, 18 Jun 2020 01:10:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442641; bh=uPBiJ4AumncjvZcxAi3pEEIlqWJqyQ0HKHJnDQw2Iqo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=b9QrIRuiiy/mnzf8KqGK0WAOVOcXAZ/jgmdK6OkUllNxfnDFRwcTr4YWeZzOVHuPA 4Uj41nQ1SexKcbirfdPwRpkLKeoIj+eTq+r+0Qe+jgPYkpn6Osqp0QhYuwPZAGWUhu GhbU7Zb3mRWz2xmgC8/LLhWoXUa0ysOOx5YcMkRI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chen Zhou , Rui Miguel Silva , Greg Kroah-Hartman , Sasha Levin , greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org Subject: [PATCH AUTOSEL 5.7 116/388] staging: greybus: fix a missing-check bug in gb_lights_light_config() Date: Wed, 17 Jun 2020 21:03:33 -0400 Message-Id: <20200618010805.600873-116-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chen Zhou [ Upstream commit 9bb086e5ba9495ac150fbbcc5c8c2bccc06261dd ] In gb_lights_light_config(), 'light->name' is allocated by kstrndup(). It returns NULL when fails, add check for it. Signed-off-by: Chen Zhou Acked-by: Rui Miguel Silva Link: https://lore.kernel.org/r/20200401030017.100274-1-chenzhou10@huawei.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/staging/greybus/light.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c index d6ba25f21d80..d2672b65c3f4 100644 --- a/drivers/staging/greybus/light.c +++ b/drivers/staging/greybus/light.c @@ -1026,7 +1026,8 @@ static int gb_lights_light_config(struct gb_lights *glights, u8 id) light->channels_count = conf.channel_count; light->name = kstrndup(conf.name, NAMES_MAX, GFP_KERNEL); - + if (!light->name) + return -ENOMEM; light->channels = kcalloc(light->channels_count, sizeof(struct gb_channel), GFP_KERNEL); if (!light->channels) -- 2.25.1