Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp980804ybt; Wed, 17 Jun 2020 19:49:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyRLheMk8N8cAmn1O16+70q/BlD0M9RMIdVHmvXUh1g7khYbzb6u4e21HRtfuFwv1iJVJUH X-Received: by 2002:a50:cd17:: with SMTP id z23mr2000131edi.326.1592448572279; Wed, 17 Jun 2020 19:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592448572; cv=none; d=google.com; s=arc-20160816; b=dVv2r9HCJHRGgbAOYKUkBa05cuf9G0KHwFH4aBIhlD382uegjNnOaUoZVnxKO+nfWr 50RIcwsGTOZj4G30s88V7zdYj7fxNvMh2PpabnkUawCeLn3WYXvvkNDAWyNfcnkQNUed +XiaZatA5xHHr7WBxH06gjao7Ey6FMP1wiinbsFZDURt25cB0FL8jf761zea5UmnSWxV BFQYNe9Iw4QpgLHkzo0fx38caTf4LNjp6IRA40lQZ5YL+fhIkRoWKkIw8HgulJvjKXy6 CU5OS7SUIbmscNUcY6rdDuoSmqroMh4Jg1GICp8teevbIdHRvp28GTv1VESO/mjq6D7C C7pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cgQQ0/pVSRPRvgif/tflM86gLkZSdgJBm5TrMiuRjzk=; b=MIBCcNjEVDPsxC4lERwqR5c6yUZ7YbloXbSFLcBZ3Ne+ij28UEAkXWQJL98RpdsRDa K5jFEWRehS4eP3yIw2DM860J5KPHH/JKYQd3e3J4OaFZxDj1XnwykVS8PjCquResC2fu N/hefr6IydazXa5j4iuyrPn9EUKmGOj0vvmbHvCRSmupMbMSt1pxdwU5kyh0pS9s9SYZ ttC/uY8dId7vywrJoLlyxuz7BNc0BMRnoh+jHNjz+zQTyC8MlOI+2c6WSyiAiiPHUZ7E yHI/tsv8gAHBNQB0qiaypUFiZProZrIUX5uVXy8Gs51NYqCXACu7CIV2ic4G3leYnu1J kiFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q941rdES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gv16si1107624ejb.437.2020.06.17.19.49.10; Wed, 17 Jun 2020 19:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=q941rdES; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730891AbgFRCrX (ORCPT + 99 others); Wed, 17 Jun 2020 22:47:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:37514 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726975AbgFRBKW (ORCPT ); Wed, 17 Jun 2020 21:10:22 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31C6F20CC7; Thu, 18 Jun 2020 01:10:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442621; bh=BbJ617bFOG+Jd2fPEGqvE+hziquN3k6VXqs2Y9KUipg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q941rdESgU4LRztrie8L0aE0drD7vLvHqiHCq+8TbJ1JYPfbZkISTHmWmQ5cQrQX4 ML7Q9U6sZad9VMH9Gpz0/fIOT4eD4j7+swDZYSgGE3PzkcGvankFjOgbtdaPPYMguK +ey2uMtitT4hNVsswLdA36s4O/biOe4D/w67URT4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Chao Yu , Jaegeuk Kim , Sasha Levin , linux-f2fs-devel@lists.sourceforge.net Subject: [PATCH AUTOSEL 5.7 101/388] f2fs: handle readonly filesystem in f2fs_ioc_shutdown() Date: Wed, 17 Jun 2020 21:03:18 -0400 Message-Id: <20200618010805.600873-101-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit 8626441f05dc45a2f4693ee6863d02456ce39e60 ] If mountpoint is readonly, we should allow shutdowning filesystem successfully, this fixes issue found by generic/599 testcase of xfstest. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/file.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 6ab8f621a3c5..30b35915fa3a 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -2219,8 +2219,15 @@ static int f2fs_ioc_shutdown(struct file *filp, unsigned long arg) if (in != F2FS_GOING_DOWN_FULLSYNC) { ret = mnt_want_write_file(filp); - if (ret) + if (ret) { + if (ret == -EROFS) { + ret = 0; + f2fs_stop_checkpoint(sbi, false); + set_sbi_flag(sbi, SBI_IS_SHUTDOWN); + trace_f2fs_shutdown(sbi, in, ret); + } return ret; + } } switch (in) { -- 2.25.1