Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932633AbWCXOTq (ORCPT ); Fri, 24 Mar 2006 09:19:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422855AbWCXOTq (ORCPT ); Fri, 24 Mar 2006 09:19:46 -0500 Received: from mx02.cybersurf.com ([209.197.145.105]:9637 "EHLO mx02.cybersurf.com") by vger.kernel.org with ESMTP id S932633AbWCXOTp (ORCPT ); Fri, 24 Mar 2006 09:19:45 -0500 Subject: Re: [RFC][UPDATED PATCH 2.6.16] [Patch 9/9] Generic netlink interface for delay accounting From: jamal Reply-To: hadi@cyberus.ca To: balbir@in.ibm.com Cc: Matt Helsley , Shailabh Nagar , linux-kernel , netdev In-Reply-To: <1143209518.5076.21.camel@jzny2> References: <1142296834.5858.3.camel@elinux04.optonline.net> <1142297791.5858.31.camel@elinux04.optonline.net> <1142303607.24621.63.camel@stark> <1142304506.5219.34.camel@jzny2> <20060322074922.GA1164@in.ibm.com> <1143122686.5186.27.camel@jzny2> <20060324013229.GD13159@in.ibm.com> <1143209518.5076.21.camel@jzny2> Content-Type: text/plain Organization: unknown Date: Fri, 24 Mar 2006 09:19:42 -0500 Message-Id: <1143209982.5076.24.camel@jzny2> Mime-Version: 1.0 X-Mailer: Evolution 2.2.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 635 Lines: 21 On Fri, 2006-24-03 at 09:11 -0500, jamal wrote: > Look at using proper macros instead of hard coding like you did. > grep for something like RTA_SPACE and perhaps send a patch to make it > generic for netlink.h > actually Thomas already has this in netlink.h Look at using things like: nla_attr_size() make sure padding is taken care of etc (read: use the right macros). cheers, jamal - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/