Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp983935ybt; Wed, 17 Jun 2020 19:56:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGkpz3R515oDT/XmQOvW0R70GGSaJJiAnK0q6Grsextei7xr6QvEXKd0/aFwiQiiK6vYQ0 X-Received: by 2002:a17:907:abb:: with SMTP id bz27mr2135132ejc.170.1592448981199; Wed, 17 Jun 2020 19:56:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592448981; cv=none; d=google.com; s=arc-20160816; b=Dt6tdAmi7oo5juosUwtKyvYcMfMQZHwFgU0vMGBaPKAUk5BVpBUN/vJo/lG71RDaN7 oz/E1HAljjF+IPuXl6evWXUYRST+VAoRNu/a5e/iWo1e0czLLdTDy+9Lzz9R2BXwfL6u cZEWvP2BhJ2rKU7jNjn2wLmZN/0uP4G0xnGOj1dIHNp4VzhgC0K3UI+HqnnlgsWJ1Mnh 5pJMRtTSkc/0UtTdbFjgqubJnhFIW/nmkfkWpjJ5Ots7phre78IiX9BOf4oN1o2gDoC5 /7dcliyNl7lX679k4WPprQr5VVX5dEY4z3Btwoimk6SXXr09W36GZ8k8iMtXCgnqaudg IOGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i+K0d/7IE5hu4u401nKNYjFNv5Rx0GgvZckRYdHrJK8=; b=jVrV8isljBFAQ1ccc8rC/hK2xI+gpEG4tBX8Nzt8XljzLZfWgnLKXI51Cxk+AKuBrX q3NWos2DHpmKBn2Fq4kx4blknJzxA/BLnlCBLOsoRmXr0sXVGCcq+YL34shKtobsA20u 3EbDtQAC3q2AB9iTp1jLy0dX35KMdN0kuhzDRpBrD/J00aMLijXSHAUWT9Qmry/X8voc jW5yWXiEa1z5Q8M5kA4kX0kmaBwD+6/MC+hgCvCagG3JxcrHpGj1cRcf3pfZFvtAsslx nQbckjEO5fvEq2El3F3BCnPWycikiIrOig9p5veOlOLdd15pb1j0qh3i68Tb98WLb1/P aNeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t5PIg5ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k26si1118338edq.512.2020.06.17.19.55.59; Wed, 17 Jun 2020 19:56:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t5PIg5ez; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387923AbgFRCwb (ORCPT + 99 others); Wed, 17 Jun 2020 22:52:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:34468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727850AbgFRBIi (ORCPT ); Wed, 17 Jun 2020 21:08:38 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 073F021D7B; Thu, 18 Jun 2020 01:08:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592442517; bh=62UpoBMOicIDb08JuJpbBMu5XKtfAtF6zirRNTmWJvc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t5PIg5ezNWEHrEcrUPkusT9OO11yf+chj8AgqpxXWqN+1KLHq32fTfDbSB3cmBg5s 339NebfBmtIwy2Knne4ipLlNrPGREwiNwV4/BDLtFu6IBjjdOACSh6680QEkrLtMmi P4tJykqfsSEEdXoqy/SpULU1IhdtdX6lfrnK036Y= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Manish Rangankar , "Martin K . Petersen" , Sasha Levin , linux-scsi@vger.kernel.org Subject: [PATCH AUTOSEL 5.7 023/388] scsi: qedi: Check for buffer overflow in qedi_set_path() Date: Wed, 17 Jun 2020 21:02:00 -0400 Message-Id: <20200618010805.600873-23-sashal@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200618010805.600873-1-sashal@kernel.org> References: <20200618010805.600873-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 4a4c0cfb4be74e216dd4446b254594707455bfc6 ] Smatch complains that the "path_data->handle" variable is user controlled. It comes from iscsi_set_path() so that seems possible. It's harmless to add a limit check. The qedi->ep_tbl[] array has qedi->max_active_conns elements (which is always ISCSI_MAX_SESS_PER_HBA (4096) elements). The array is allocated in the qedi_cm_alloc_mem() function. Link: https://lore.kernel.org/r/20200428131939.GA696531@mwanda Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") Acked-by: Manish Rangankar Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qedi/qedi_iscsi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c index 1f4a5fb00a05..d2e5b485afeb 100644 --- a/drivers/scsi/qedi/qedi_iscsi.c +++ b/drivers/scsi/qedi/qedi_iscsi.c @@ -1218,6 +1218,10 @@ static int qedi_set_path(struct Scsi_Host *shost, struct iscsi_path *path_data) } iscsi_cid = (u32)path_data->handle; + if (iscsi_cid >= qedi->max_active_conns) { + ret = -EINVAL; + goto set_path_exit; + } qedi_ep = qedi->ep_tbl[iscsi_cid]; QEDI_INFO(&qedi->dbg_ctx, QEDI_LOG_INFO, "iscsi_cid=0x%x, qedi_ep=%p\n", iscsi_cid, qedi_ep); -- 2.25.1