Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1114324ybt; Thu, 18 Jun 2020 00:26:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxO05qrJkeF0JJKV48rHOrjvLNq2Dm6lnNEBCHcZgv0Yej5jrhhiBRDlAH3BJnx0xYvvyGG X-Received: by 2002:a05:6402:1d29:: with SMTP id dh9mr2744079edb.269.1592465161456; Thu, 18 Jun 2020 00:26:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592465161; cv=none; d=google.com; s=arc-20160816; b=0Z6VR/eiBwutDUqYFmx4pxRh8xGQFphVdIJhWZCXB4oAODLwcH+B3pcbgqU9i51Gyw b/obCM9AyXoRuADoXmjmw8UmYlIChGw8LoOYfK0u7tQDPianCGuwY1y+ABMM3Y+n4WHa zW0iKcbuAe/VmkDpMWOGWmY1yNHz3DtnfnW5GdboHl6p7FmK5WjRX2jh9AZxmnsQDgXy hrga6HXHTMGjfhFlET1WzHXnLYPj0mWdFOT/qP6+b7vzJpT2Dz5xXfC4/BcUtIK4nij+ YMZleABY44DtzwYQJ6u2JkN0vSTJpqE+tXpfAcHgENNj3EfYUM8QG3G9sYzRm3yugI5H rj+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=SGtDpfxMHQbywUz0plTDFXQixs7+Hkk8sa/dzdor54s=; b=j7MB3NXTS36lT1NRIA5IW8ndXihlOLJPzhmPctlK2t78or2E82/4pumGcSGtEvjdtd ceSfGlCSO0Uz7cRMi8QVbmijqTxpb5HKe+4e5dS0E7eNa2uWb6SJZHa/ZR/su6KWdh8Q +kfhKU7UY6i9+Cow+nZUBvykcm/6miD2W/N8B4SJqew5FTAdtxtIIOsPGe/pYs0pkGGh +dcrSNy0iCygL6S01EnXTxi/sN9nFT1+0B5XCYuqQdWbZrzH4BoO9bPTzu0S85ivsMoO TnUnN2i1FUXKQlnnmnI3msNpDFythldelLxuA0Sf8sUHOwixdzV8MWpDDlplXS7gEAie zq+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="K/Y1Mo+b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly19si1337301ejb.394.2020.06.18.00.25.38; Thu, 18 Jun 2020 00:26:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="K/Y1Mo+b"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbgFRHVv (ORCPT + 99 others); Thu, 18 Jun 2020 03:21:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbgFRHVv (ORCPT ); Thu, 18 Jun 2020 03:21:51 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 516FDC06174E; Thu, 18 Jun 2020 00:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SGtDpfxMHQbywUz0plTDFXQixs7+Hkk8sa/dzdor54s=; b=K/Y1Mo+bZsxTblvcVjJiA9gV5+ MzOZRiBDfBUvWaexqhmu9wsY2I6JID5+ZydqA93N1IhQ28pGSu+O2a7QCK7ei5NwIuFMGp8PrDhcd /WIwW53QUj1Arvvi9ubZxqziyRY6eEYG56Lo75LpotlitRTMUSBKE5ITCfhg6lsBSfuncNGLLeIMu P9wCosLl7O88mEt/GIQpf6JPA6O0dgB914R1ziNLVcpRWpzIMmngW3Xs31oVwsXFwVlPht7AWTdjC W7gygTlMwcr7pIwMr8KgV3g6/nabcfGDeaYsdljkX3J7gtdOEk5/z9XAzL+K5SW6bd2MYrMhUw4jZ CrMZt3Cg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlori-0002MA-6Q; Thu, 18 Jun 2020 07:21:38 +0000 Date: Thu, 18 Jun 2020 00:21:38 -0700 From: Christoph Hellwig To: Simon Arlott Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Jonathan Corbet , Linux Kernel Mailing List , linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH] scsi: sd: stop SSD (non-rotational) disks before reboot Message-ID: <20200618072138.GA11778@infradead.org> References: <499138c8-b6d5-ef4a-2780-4f750ed337d3@0882a8b5-c6c3-11e9-b005-00805fc181fe> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <499138c8-b6d5-ef4a-2780-4f750ed337d3@0882a8b5-c6c3-11e9-b005-00805fc181fe> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 17, 2020 at 07:49:57PM +0100, Simon Arlott wrote: > Avoiding a stop of the disk on a reboot is appropriate for HDDs because > they're likely to continue to be powered (and should not be told to spin > down only to spin up again) but the default behaviour for SSDs should > be changed to stop them before the reboot. I don't think that is true in general. At least for most current server class and older desktop and laptop class systems they use the same format factors and enclosures, although they are slightly divering now. So I think this needs to be quirked based on the platform and/or enclosure. I don't have ATA SSDs any more, but at least in my laptops the NVMe SSDs do see unsafe shutdowns during reboots.