Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: BYHn6QN5h9R3n9mCFBVAMmQAWyhR5+6/9ru9SGuKlceSGfcMsWG762ZwOwR/8FlyjB82+TaEk2
 MT5lLN2L28tjLqwk+JfHWb4H18h/PqELfRxyYf0agU7wm3Eyq1t3BDZx4tB8Inxrsx+2GB80ml
 nANoML5gx4aIY4rsYrnPpar7LeLguHvO7EaQOByi0ykKThCZ33RIZ525PFzOlUX/tJomvhS9+8
 g9p7W86wXMK0KjqaigtFsRt8lXy7gbkl3IE/uAIfpP9+F/XhjPOYC5eRgynIipve8e8yQhLxrK
 8y8=
From:   Damien Le Moal <Damien.LeMoal@wdc.com>
To:     Kanchan Joshi <joshi.k@samsung.com>,
        "axboe@kernel.dk" <axboe@kernel.dk>,
        "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
        "bcrl@kvack.org" <bcrl@kvack.org>
CC:     "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-aio@kvack.org" <linux-aio@kvack.org>,
        "io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "selvakuma.s1@samsung.com" <selvakuma.s1@samsung.com>,
        "nj.shetty@samsung.com" <nj.shetty@samsung.com>,
        "javier.gonz@samsung.com" <javier.gonz@samsung.com>,
        Arnav Dawn <a.dawn@samsung.com>
Subject: Re: [PATCH 2/3] aio: add support for zone-append
Thread-Topic: [PATCH 2/3] aio: add support for zone-append
Thread-Index: AQHWRMyOokzJw5oqGEuSZawTmRChPw==
Date:   Thu, 18 Jun 2020 07:33:57 +0000
Message-ID: <CY4PR04MB3751B6D692F59810AF6D52D7E79B0@CY4PR04MB3751.namprd04.prod.outlook.com>
References: <1592414619-5646-1-git-send-email-joshi.k@samsung.com>
 <CGME20200617172706epcas5p4dcbc164063f58bad95b211b9d6dfbfa9@epcas5p4.samsung.com>
 <1592414619-5646-3-git-send-email-joshi.k@samsung.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a8a0e410-a02f-46cf-c38b-08d81359f640
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jun 2020 07:33:57.5292
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: smPS/Rh1zGKTJFYZ275wTM4NCv5Ld1vd96HwxyX59hTFT9nfj/UO3auKEfiDFV9Q2pPuPxYSud2QR8IzW9kKJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR04MB0566
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2020/06/18 2:27, Kanchan Joshi wrote:=0A=
> Introduce IOCB_CMD_ZONE_APPEND opcode for zone-append. On append=0A=
> completion zone-relative offset is returned using io_event->res2.=0A=
> =0A=
> Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>=0A=
> Signed-off-by: Arnav Dawn <a.dawn@samsung.com>=0A=
> Signed-off-by: SelvaKumar S <selvakuma.s1@samsung.com>=0A=
> Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>=0A=
> Signed-off-by: Javier Gonzalez <javier.gonz@samsung.com>=0A=
> ---=0A=
>  fs/aio.c                     | 8 ++++++++=0A=
>  include/uapi/linux/aio_abi.h | 1 +=0A=
>  2 files changed, 9 insertions(+)=0A=
> =0A=
> diff --git a/fs/aio.c b/fs/aio.c=0A=
> index 7ecddc2..8b10a55d 100644=0A=
> --- a/fs/aio.c=0A=
> +++ b/fs/aio.c=0A=
> @@ -1579,6 +1579,10 @@ static int aio_write(struct kiocb *req, const stru=
ct iocb *iocb,=0A=
>  			__sb_start_write(file_inode(file)->i_sb, SB_FREEZE_WRITE, true);=0A=
>  			__sb_writers_release(file_inode(file)->i_sb, SB_FREEZE_WRITE);=0A=
>  		}=0A=
> +#ifdef CONFIG_BLK_DEV_ZONED=0A=
> +		if (iocb->aio_lio_opcode =3D=3D IOCB_CMD_ZONE_APPEND)=0A=
> +			req->ki_flags |=3D IOCB_ZONE_APPEND;=0A=
> +#endif=0A=
>  		req->ki_flags |=3D IOCB_WRITE;=0A=
>  		aio_rw_done(req, call_write_iter(file, req, &iter));=0A=
>  	}=0A=
> @@ -1846,6 +1850,10 @@ static int __io_submit_one(struct kioctx *ctx, con=
st struct iocb *iocb,=0A=
>  		return aio_fsync(&req->fsync, iocb, true);=0A=
>  	case IOCB_CMD_POLL:=0A=
>  		return aio_poll(req, iocb);=0A=
> +#ifdef CONFIG_BLK_DEV_ZONED=0A=
> +	case IOCB_CMD_ZONE_APPEND:=0A=
> +		return aio_write(&req->rw, iocb, false, compat);=0A=
> +#endif=0A=
>  	default:=0A=
>  		pr_debug("invalid aio operation %d\n", iocb->aio_lio_opcode);=0A=
>  		return -EINVAL;=0A=
> diff --git a/include/uapi/linux/aio_abi.h b/include/uapi/linux/aio_abi.h=
=0A=
> index 8387e0a..541d96a 100644=0A=
> --- a/include/uapi/linux/aio_abi.h=0A=
> +++ b/include/uapi/linux/aio_abi.h=0A=
> @@ -43,6 +43,7 @@ enum {=0A=
>  	IOCB_CMD_NOOP =3D 6,=0A=
>  	IOCB_CMD_PREADV =3D 7,=0A=
>  	IOCB_CMD_PWRITEV =3D 8,=0A=
> +	IOCB_CMD_ZONE_APPEND =3D 9,=0A=
>  };=0A=
>  =0A=
>  /*=0A=
> =0A=
=0A=
No need for all the #ifdefs.=0A=
=0A=
-- =0A=
Damien Le Moal=0A=
Western Digital Research=0A=