Date: Fri, 24 Mar 2006 07:22:51 -0800
From: Ashok Raj <ashok.raj@intel.com>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Andi Kleen <ak@suse.de>, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] Ignore MCFG if the mmconfig area isn't reserved in thee820 table
Message-ID: <20060324072250.A13756@unix-os.sc.intel.com>
References: <1143138170.3147.43.camel@laptopd505.fenrus.org> <200603231856.12227.ak@suse.de> <1143140539.3147.44.camel@laptopd505.fenrus.org> <1143141320.3147.47.camel@laptopd505.fenrus.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <1143141320.3147.47.camel@laptopd505.fenrus.org>; from arjan@linux.intel.com on Thu, Mar 23, 2006 at 11:15:19AM -0800
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 803
Lines: 23

On Thu, Mar 23, 2006 at 11:15:19AM -0800, Arjan van de Ven wrote:
> 
>    >
>    > I'll do a new patch using this for x86_64 though, no need to make a
>    > second function like this.
> 
>     int  __init  e820_mapped(unsigned  long  start,  unsigned  long  end,
>    unsigned type)


Why not use the same type of function like x86_64 as well instead of the newly
added is_820_mapped()? If the purpose of both functions is the same, i386 could benefit 
with same style code instead of a slight variant.

-- 
Cheers,
Ashok Raj
- Open Source Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/