Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1151107ybt; Thu, 18 Jun 2020 01:36:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYZWYj8AMizH0QpZile/bB8r9SqBNGwvSPBG+CYp0EzAU3MQ7oDPc415R15T8rzogso6Hh X-Received: by 2002:a17:906:f49:: with SMTP id h9mr3064146ejj.155.1592469393735; Thu, 18 Jun 2020 01:36:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592469393; cv=none; d=google.com; s=arc-20160816; b=0FAOYZO1s8LYszwXJos7pncdO1+ROv6cHYbx6ktJ+9ff8NxC5YPTRAdcSU4Zqvp+QH EkGYy0KDFITYlp32vMlTMhvIjVc38nGqAVKeegdtFL8Mg6U8Yd0WAeUVbxVB14wTiPLo orLB8OhQ+TsWrvRyEvOJU97ltj6kBkPE6TfpmZsLCAFj1KDeoP7N+57wcWTYTp1NdLtr RmmAGaQYkq8021MeONQ7efxF5R+AUh3BeKq7HTV9aB7eUAHBO3PZ0XCbr/YJySglnCdQ TiDMLNHItHn6klvuUJIs2VaTPGNtk8ah7sfrB9/LDS6x6Pdt9d+tCCQniZ2G+0TLuemK Y6vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=mBaOTic59RjsjLgo2G8JEZ2HjlmP5tRj9DOckjIFG3U=; b=w0ick9/THpv51hS+pDO9ffRxElIBl1R4souTon8/9G/0CQ9aaDxPWroOYNSmDSE5Zd Vv4spuBI8O6yscTyL8NwNwZNQO2V6GPpvtEd9XZrrLPNCLa6aQb580Fe4zrLy+94ro3s JauneEC1QzizZ97M3VbMGQqLqTiglZezuORVfo4mmkKTDK5iYvRkAEqC/GGvC1KovqTD +6EpEFvuNQTgz8i3nIchxJBIfz6wDzvLmKttkOFs4Lft8b6xxGVh2gduvkR0HurZ6L95 L6cGEm6MO+Kuyy1c30+NCciSDBE1ShGElXCWfRQe7GdkO7x08jAw2uJyRrNR2S0LmsNk YXIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=VeZchB1Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha26si1492217ejb.533.2020.06.18.01.36.10; Thu, 18 Jun 2020 01:36:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=VeZchB1Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728713AbgFRIcE (ORCPT + 99 others); Thu, 18 Jun 2020 04:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbgFRIcC (ORCPT ); Thu, 18 Jun 2020 04:32:02 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3933C06174E for ; Thu, 18 Jun 2020 01:32:01 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id b6so5070651wrs.11 for ; Thu, 18 Jun 2020 01:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=mBaOTic59RjsjLgo2G8JEZ2HjlmP5tRj9DOckjIFG3U=; b=VeZchB1Zk+81qlHhjvzg9LHD2TBm3ByGBy0IW8ORikdh0NwKJNt9P+kqDslvMSk8SW nw6/o4F3Qx8D4bVOI2IfZ8m1HhI57HG0Hg2hsWb4vVk65rZ6pzUgW4hpY/6HTTXzKFdC NMqgGuUBaGfuv0iTTGMcyXJYvYBSsw79YzG0M47LU23y2Akz4LEVPk1bFN9SVP9Ah+Qq xv5s2DSDOEC1vdjyoTIdHq3HLLEG6tnDZdPLqGpNCtH1KfYSZsnsmu65lt61g5qsxtk9 tNk90RsdiXSIUxAFNTAEUhx/jhs/r0f5LxK0bU6VAb6V8yPKshxlErMCndviPPQOs6c+ LH/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=mBaOTic59RjsjLgo2G8JEZ2HjlmP5tRj9DOckjIFG3U=; b=nR38it29qdGSvLpn0gm2gXt7yHTDMY8vaCpQ4ju/YDGxIjHFvGe8qzMlnqbShRwXYq psMS+1O6YZjvMe8Xd4Chpo/MeRoFjb1nAt35uFXvwVAyJ4H7oQ4c4zzjefi6DVzs9KQs vEISYzHXs7Iam3jTOqgXXqKPnTUNKBmxupe0UTqnx5yIY0V8rzalzjk/8rWsUrFrD3Rw N6ieD87Pi39hJu8RC5/QiT0rHqLtNIkohkKDNLO8QteothuGXED/iJAowNVnvqJn5mPM o5ekzgQpqXLgbxz3aojEB0Go9x4xp5K8r1hHIxT8A26K4kwg3PCGFy3YHSZf3OkvYYAh QMLQ== X-Gm-Message-State: AOAM530xMfr6bS4Tu4MkqqCb6oQd1KPHKNPyytzLYsXhYRLMFfASPcaz +nFg1zZDl9TETESW+XLKQQ/eYg== X-Received: by 2002:adf:a306:: with SMTP id c6mr3397910wrb.122.1592469120621; Thu, 18 Jun 2020 01:32:00 -0700 (PDT) Received: from [10.0.0.6] (xb932c246.cust.hiper.dk. [185.50.194.70]) by smtp.gmail.com with ESMTPSA id t14sm2653507wrb.94.2020.06.18.01.31.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2020 01:32:00 -0700 (PDT) Subject: Re: [PATCH 0/3] zone-append support in aio and io-uring To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= Cc: Kanchan Joshi , axboe@kernel.dk, viro@zeniv.linux.org.uk, bcrl@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aio@kvack.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, selvakuma.s1@samsung.com, nj.shetty@samsung.com, Damien Le Moal , Keith Busch , Christoph Hellwig References: <1592414619-5646-1-git-send-email-joshi.k@samsung.com> <20200618082740.i4sfoi54aed6sxnk@mpHalley.local> From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: Date: Thu, 18 Jun 2020 10:32:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200618082740.i4sfoi54aed6sxnk@mpHalley.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/06/2020 10.27, Javier González wrote: > On 18.06.2020 10:04, Matias Bjørling wrote: >> On 17/06/2020 19.23, Kanchan Joshi wrote: >>> This patchset enables issuing zone-append using aio and io-uring >>> direct-io interface. >>> >>> For aio, this introduces opcode IOCB_CMD_ZONE_APPEND. Application >>> uses start LBA >>> of the zone to issue append. On completion 'res2' field is used to >>> return >>> zone-relative offset. >>> >>> For io-uring, this introduces three opcodes: >>> IORING_OP_ZONE_APPEND/APPENDV/APPENDV_FIXED. >>> Since io_uring does not have aio-like res2, cqe->flags are >>> repurposed to return zone-relative offset >> >> Please provide a pointers to applications that are updated and ready >> to take advantage of zone append. > > Good point. We are posting a RFC with fio support for append. We wanted > to start the conversation here before. > > We can post a fork for improve the reviews in V2. Christoph's response points that it is not exactly clear how this matches with the POSIX API. fio support is great - but I was thinking along the lines of applications that not only benchmark performance. fio should be part of the supported applications, but should not be the sole reason the API is added.