Received: by 2002:a05:6902:102b:0:0:0:0 with SMTP id x11csp1178929ybt; Thu, 18 Jun 2020 02:28:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrKroFf3R3FHP5lr5b+iTFnC02NM1YKSAE5/ZOoOP6MIB1DwJMlhFXYHBtIUtaCAP0F+vp X-Received: by 2002:a17:906:d93c:: with SMTP id rn28mr3291410ejb.190.1592472488199; Thu, 18 Jun 2020 02:28:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592472488; cv=none; d=google.com; s=arc-20160816; b=q5himyW9c+sQKYawFt/HIGiaF74KjCGiOX8cmaB49ajoSZCgYid07k62Rgkn43FY5x uWuHvcC8DN2dbUmq7QmFrly1WFAUP70ZhUbuMrRHFBqh7FoKLn3jmmfLGCvORqL0Fbv0 vLZVOQAswJGwtvv2YijSyRCp1nzr8Yc82rqvwWboiwz3NBKw7ihAfdGENDR0jeAOqVET sx57yFeTJH5yCEAory7q67aWaKnNwmus7BfPqcnvBvtKHkNijvqDzfmwpuamviPhmgds 1h0yboTRzVV33ZLqSWkahPVcL5CqRnwWpFTXWPQbUu3FQS9rtsw0NJlidFqHv+GedSum zyTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:message-id:date:subject:cc:to :from:ironport-sdr:dkim-signature; bh=NqBQVyg4uwgGurJD1OK/0Mw40EovCNrpIfD1ESnsdgw=; b=1JMBsNqbVlONrVviW8CayZEBpjhUQyzrcG0m0IaZQkpuvSRPMhk8Br98zX+TOOi8F+ nFUFEkj0Wkx/Kjh0rsgr45TdfztQv+zapPNvMaNtSYzVY7QW09tc+9ganeedt8jtY7Mi sdCPOHPTCkFHurUAXud1moezyA96Fck/lJmbCwB+xo6atE7aqN/fEeE2zU5Gil7nfocC epd30zhDjAvAmrcg2+3R9p4b0gcqkyIn6EFyQWkqUM/XjdPHK9/tb9El8DIq+aJfsD+2 LQ51VH4W4oE3wH7n1oEOaLuP0O6fUqaqp5TkQQwGD84HTaXVdTFnTpRG20UMlmarAwdW mNgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=c8rsaieI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si1667119ejx.146.2020.06.18.02.27.45; Thu, 18 Jun 2020 02:28:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=c8rsaieI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729137AbgFRJYG (ORCPT + 99 others); Thu, 18 Jun 2020 05:24:06 -0400 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]:44585 "EHLO smtp-fw-9101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729082AbgFRJYB (ORCPT ); Thu, 18 Jun 2020 05:24:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1592472241; x=1624008241; h=from:to:cc:subject:date:message-id:in-reply-to; bh=NqBQVyg4uwgGurJD1OK/0Mw40EovCNrpIfD1ESnsdgw=; b=c8rsaieIO4PpiACctGZ7+8ZVUgneBdnZ699vbiitoy4jg4ntf363L9JX 7nRaeqtetTX0AEXlRGpK55bRPdKNmw1eTlks3kKACugHxQkHSagEHeeoX hQ1DrLRHApVQvHZdfWjeLPlPWH5sB085KcY1g22JQkkBxc/Q4gu27FICu k=; IronPort-SDR: B0IbgC/i6TutrZWpQCAdEPzC6VImJL1/IRg3ksa2yKAXwgXG/KWUrOopEC3lxZIb0h2TMjvrzp o72ggBtlW7og== X-IronPort-AV: E=Sophos;i="5.73,526,1583193600"; d="scan'208";a="44956919" Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-2b-859fe132.us-west-2.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-9101.sea19.amazon.com with ESMTP; 18 Jun 2020 09:23:58 +0000 Received: from uc85b765ebdd8595b4b67.ant.amazon.com (pdx2-ws-svc-lb17-vlan3.amazon.com [10.247.140.70]) by email-inbound-relay-2b-859fe132.us-west-2.amazon.com (Postfix) with ESMTPS id 69BEC221CE4; Thu, 18 Jun 2020 09:23:55 +0000 (UTC) Received: from uc85b765ebdd8595b4b67.ant.amazon.com (localhost [127.0.0.1]) by uc85b765ebdd8595b4b67.ant.amazon.com (8.15.2/8.15.2/Debian-3) with ESMTP id 05I9NrKA022961; Thu, 18 Jun 2020 11:23:53 +0200 Received: (from foersleo@localhost) by uc85b765ebdd8595b4b67.ant.amazon.com (8.15.2/8.15.2/Submit) id 05I9NqB5022955; Thu, 18 Jun 2020 11:23:52 +0200 From: Leonard Foerster To: SeongJae Park Cc: akpm@linux-foundation.org, SeongJae Park , Jonathan.Cameron@Huawei.com, aarcange@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, amit@kernel.org, benh@kernel.crashing.org, brendan.d.gregg@gmail.com, brendanhiggins@google.com, cai@lca.pw, colin.king@canonical.com, corbet@lwn.net, dwmw@amazon.com, foersleo@amazon.de, irogers@google.com, jolsa@redhat.com, kirill@shutemov.name, mark.rutland@arm.com, mgorman@suse.de, minchan@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org, rdunlap@infradead.org, riel@surriel.com, rientjes@google.com, rostedt@goodmis.org, sblbir@amazon.com, shakeelb@google.com, shuah@kernel.org, sj38.park@gmail.com, snu@amazon.de, vbabka@suse.cz, vdavydov.dev@gmail.com, yang.shi@linux.alibaba.com, ying.huang@intel.com, david@redhat.com, linux-damon@amazon.com, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v16 06/14] mm/damon: Implement callbacks for the virtual memory address spaces Date: Thu, 18 Jun 2020 11:23:51 +0200 Message-Id: <1592472232-22839-1-git-send-email-foersleo@amazon.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <20200615161927.12637-7-sjpark@amazon.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-06-15T18:19:19+02:00 SeongJae Park wrote: > From: SeongJae Park > > This commit implements the four essential callbacks of DAMON, > '->init_target_regions', '->update_target_regions', > '->prepare_access_checks', and '->check_accesses' for virtual memory > address spaces. Those internally use PTE Accessed bit. Using these > callbacks, users can easily monitor the virtual address space data > accesses of specific processes. Nonetheless, these are just reference > implementations. Users can implement and use their own callbacks for > their special use case, if required. > > Signed-off-by: SeongJae Park > --- Reviewed-by: Leonard Foerster